Skip to content

[camera] Removed the microphone permission request from availableCameras on Web - #4263

Merged
auto-submit[bot] merged 9 commits into
flutter:mainfrom
maciejbrzezinski:available_cameras_microphone_permission
Jul 31, 2023
Merged

[camera] Removed the microphone permission request from availableCameras on Web#4263
auto-submit[bot] merged 9 commits into
flutter:mainfrom
maciejbrzezinski:available_cameras_microphone_permission

Conversation

@maciejbrzezinski

@maciejbrzezinskimaciejbrzezinski commented Jun 21, 2023•
edited by stuartmorgan-g
Loading

Copy link
Copy Markdown
Contributor

I've removed the microphone permission request from availableCameras on Web.
Adding an additional parameter would break either web or android/ios, so in my opinion it is better to change the web behavior.

Fixesflutter/flutter#112277

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@maciejbrzezinskimaciejbrzezinski mentioned this pull request Jun 21, 2023
Closed
@stuartmorgan-g

stuartmorgan-g commented Jun 29, 2023

Copy link
Copy Markdown
Collaborator

Thanks for the contribution! Please take a look at the failing tests; analysis, unit tests, and several of our other automated checks are currently failing for this PR.

@razzlakki

razzlakki commented Jul 10, 2023

Copy link
Copy Markdown

Waiting for this fix.

@ditmanditman mentioned this pull request Jul 11, 2023
Closed
ditman
ditman reviewed Jul 11, 2023
View reviewed changes
Comment threadpackages/camera/camera_web/CHANGELOG.md Outdated
ditman
ditman reviewed Jul 14, 2023
View reviewed changes
Comment threadpackages/camera/camera_web/pubspec.yaml Outdated
@ditman

ditman commented Jul 17, 2023

Copy link
Copy Markdown
Member

I'll tweak this branch to fix the CI. It needs to be rebased with the latest main, and the pubspec.yaml and CHANGELOG.md versions must be made to match (at least).

@ditman
ditmanforce-pushed the available_cameras_microphone_permission branch from 05b8c71 to 6176027CompareJuly 17, 2023 22:42
ditman
ditman approved these changes Jul 17, 2023
View reviewed changes

@ditmanditman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't need much more to land. LGTM!

stuartmorgan-g
stuartmorgan-g requested changes Jul 18, 2023
View reviewed changes
Comment threadpackages/camera/camera_web/lib/src/camera_web.dart Outdated
@@ -98,11 +98,7 @@ class CameraPlugin extends CameraPlatform {

// Request video and audio permissions.

@stuartmorgan-gstuartmorgan-gJul 18, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is now incorrect.

Comment threadpackages/camera/camera_web/lib/src/camera_web.dart Outdated
);
await _cameraService.getMediaStreamForOptions(const CameraOptions());

// Release the camera stream used to request video and audio permissions.

@stuartmorgan-gstuartmorgan-gJul 18, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As is this one.

@ditman

ditman commented Jul 18, 2023

Copy link
Copy Markdown
Member

Addressed the comments regarding audio permissions, which are not explicitly requested anymore. PTAL @stuartmorgan!

stuartmorgan-g
stuartmorgan-g approved these changes Jul 31, 2023
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 31, 2023
@auto-submit
auto-submitBot merged commit 9074ea9 into flutter:mainJul 31, 2023
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Aug 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 1, 2023
@engine-flutter-autoroll
9074ea9[camera] Removed the microphone permission request from avail…
45fec1d
…ableCameras on Web (flutter/packages#4263)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Aug 1, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 1, 2023
@engine-flutter-autoroll
9074ea9[camera] Removed the microphone permission request from avail…
d1d6836
…ableCameras on Web (flutter/packages#4263)
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Aug 1, 2023
@engine-flutter-autoroll
Roll Packages from60e9a54to3dc00c1(5 revisions) (#131692)
abb1e4c
flutter/packages@60e9a54...3dc00c1
2023-08-01 engine-flutter-autoroll@skia.org Manual roll Flutter from 1d44fbd to 1d59196 (18 revisions) (flutter/packages#4621)
2023-07-31 32242716+ricardoamador@users.noreply.github.com Update the cirrus key jul-31-2023 (flutter/packages#4618)
2023-07-31 jpnurmi@gmail.com [path_provider_platform_interface] Add getApplicationCachePath() (flutter/packages#4614)
2023-07-31 elitree@gmail.com [google_maps_flutter_web] Initial support for custom overlays (flutter/packages#3538)
2023-07-31 34410554+maciejbrzezinski@users.noreply.github.com [camera] Removed the microphone permission request from availableCameras on Web (flutter/packages#4263)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth pushed a commit to vashworth/flutter that referenced this pull request Aug 2, 2023
@engine-flutter-autoroll@vashworth
Roll Packages from60e9a54to3dc00c1(5 revisions) (flutter#131692)
f24cc47
flutter/packages@60e9a54...3dc00c1
2023-08-01 engine-flutter-autoroll@skia.org Manual roll Flutter from 1d44fbd to 1d59196 (18 revisions) (flutter/packages#4621)
2023-07-31 32242716+ricardoamador@users.noreply.github.com Update the cirrus key jul-31-2023 (flutter/packages#4618)
2023-07-31 jpnurmi@gmail.com [path_provider_platform_interface] Add getApplicationCachePath() (flutter/packages#4614)
2023-07-31 elitree@gmail.com [google_maps_flutter_web] Initial support for custom overlays (flutter/packages#3538)
2023-07-31 34410554+maciejbrzezinski@users.noreply.github.com [camera] Removed the microphone permission request from availableCameras on Web (flutter/packages#4263)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbakerreidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
@darshankawardarshankawar mentioned this pull request Mar 20, 2024
Closed
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@maciejbrzezinski
[camera] Removed the microphone permission request from availableCame…
444b7bb
…ras on Web (flutter#4263)
I've removed the microphone permission request from availableCameras on Web. Adding an additional parameter would break either web or android/ios, so in my opinion it is better to change the web behavior.
Changes were made based on this issue: flutter/flutter#112277
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@maciejbrzezinski
[camera] Removed the microphone permission request from availableCame…
88f5af9
…ras on Web (flutter#4263)
I've removed the microphone permission request from availableCameras on Web. Adding an additional parameter would break either web or android/ios, so in my opinion it is better to change the web behavior.
Changes were made based on this issue: flutter/flutter#112277
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes
@ditmanditmanditman approved these changes
@bparrishMinesbparrishMinesAwaiting requested review from bparrishMines

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: cameraplatform-web

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Camera plugin requesting audio access in web even with enableAudio set to false

4 participants

@maciejbrzezinski@stuartmorgan-g@razzlakki@ditman