Skip to content

go_router: docs: fix typo in StatefulShellRoute.indexedStack(...) docs - #4341

Merged
auto-submit[bot] merged 3 commits into
flutter:mainfrom
Goddchen:docs/go-router-route-typo
Jul 10, 2023
Merged

go_router: docs: fix typo in StatefulShellRoute.indexedStack(...) docs#4341
auto-submit[bot] merged 3 commits into
flutter:mainfrom
Goddchen:docs/go-router-route-typo

Conversation

@Goddchen

Copy link
Copy Markdown
Contributor

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Goddchen

Copy link
Copy Markdown
ContributorAuthor

Hm, interesting, those failed jobs don't seem to be related to my change, are they?

@chunhtaichunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtaichunhtai added the override: no versioning needed Override the check requiring version bumps for most changes label Jun 29, 2023
@chunhtai

Copy link
Copy Markdown
Contributor

Can you add a ## NEXT entry in change log?

@chunhtai
chunhtai requested a review from hannah-hyjJune 29, 2023 15:22
@Goddchen

Copy link
Copy Markdown
ContributorAuthor

👌 like that?

@hannah-hyjhannah-hyj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannah-hyj

Copy link
Copy Markdown
Member

@Goddchen Can you resolve the conflict?

@Goddchen

Copy link
Copy Markdown
ContributorAuthor

@Hangyujin Of course ✅

@Goddchen

Copy link
Copy Markdown
ContributorAuthor

Not sure what this failing job exactly does or how I could fix it.

@chunhtaichunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 10, 2023
@auto-submit
auto-submitBot merged commit 8181bbe into flutter:mainJul 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 11, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 11, 2023
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Jul 11, 2023
flutter/packages@4469c5e...188a846
2023-07-11 32538273+ValentinVignal@users.noreply.github.com [go_router] Fix some typos in the comments and asserts (flutter/packages#4412)
2023-07-11 tarrinneal@gmail.com [pigeon] `Object` type in class integration tests (flutter/packages#4384)
2023-07-11 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.8.22 to 1.9.0 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#4419)
2023-07-10 stuartmorgan@google.com [ci] Add initial LUCI legacy analysis (flutter/packages#4428)
2023-07-10 stuartmorgan@google.com [web_benchmarks] Migrate custom test to `custom_package_tests` (flutter/packages#4429)
2023-07-10 goddchen@gmail.com go_router: docs: fix typo in StatefulShellRoute.indexedStack(...) docs (flutter/packages#4341)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbakerreidbaker mentioned this pull request Aug 4, 2023
11 tasks
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appoverride: no versioning neededOverride the check requiring version bumps for most changesp: go_router

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Goddchen@chunhtai@hannah-hyj