Skip to content

[tool] Add a flag to skip cleanup - #4357

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
stuartmorgan-g:tool-excerpt-no-cleanup-flag
Jul 1, 2023
Merged

[tool] Add a flag to skip cleanup#4357
auto-submit[bot] merged 1 commit into
flutter:mainfrom
stuartmorgan-g:tool-excerpt-no-cleanup-flag

Conversation

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

It can be useful in debugging snippet setup to look at the extraction output, but the tool cleans that up automatically. Running the extraction manually is complicated due to the on-the-fly pubspec modifications, so this adds a --no-cleanup flag that can be used to skip the deletion of the extraction output, and instead log its location to the terminal.

It can be useful in debugging snippet setup to look at the extraction
output, but the tool cleans that up automatically. Running the
extraction manually is complicated due to the on-the-fly pubspec
modifications, so this adds a `--no-cleanup` flag that can be used to
skip the deletion of the extraction output, and instead log its location
to the terminal.
@stuartmorgan-g
stuartmorgan-g requested a review from HixieJuly 1, 2023 01:09

@HixieHixie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HixieHixie added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 1, 2023
@auto-submit

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/packages, pr: 4357, due to - The status or check suite android-platform_tests CHANNEL:master PACKAGE_SHARDING:--shardIndex 2 --shardCount 8 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 1, 2023
@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 1, 2023
@auto-submit
auto-submitBot merged commit 8b3b1ef into flutter:mainJul 1, 2023
@stuartmorgan-g
stuartmorgan-g deleted the tool-excerpt-no-cleanup-flag branch July 1, 2023 10:54
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 3, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 3, 2023
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Jul 3, 2023
flutter/packages@53ed5a0...cdae854
2023-07-01 engine-flutter-autoroll@skia.org Roll Flutter from ff838bc to aa5f4a2 (29 revisions) (flutter/packages#4363)
2023-07-01 stuartmorgan@google.com [tool] Add a flag to skip cleanup (flutter/packages#4357)
2023-07-01 stuartmorgan@google.com [file_selector] Endorse Android (flutter/packages#4329)
2023-07-01 stuartmorgan@google.com [google_sign_in] Convert Android to Pigeon (flutter/packages#4344)
2023-06-30 tarrinneal@gmail.com [Pigeon] readme updates (flutter/packages#3705)
2023-06-30 43054281+camsim99@users.noreply.github.com [camera_android] Support concurrently image capture and image streaming (flutter/packages#4332)
2023-06-30 kustermann.martin@gmail.com Prepare for utf8.encode() to return more precise Uint8List type (flutter/packages#4342)
2023-06-30 tarrinneal@gmail.com [shared_preferences] Adds allowList to setPrefix method. (flutter/packages#3794)
2023-06-30 engine-flutter-autoroll@skia.org Roll Flutter from 51bef1b to ff838bc (12 revisions) (flutter/packages#4346)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbakerreidbaker mentioned this pull request Aug 4, 2023
11 tasks
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
It can be useful in debugging snippet setup to look at the extraction output, but the tool cleans that up automatically. Running the extraction manually is complicated due to the on-the-fly pubspec modifications, so this adds a `--no-cleanup` flag that can be used to skip the deletion of the extraction output, and instead log its location to the terminal.
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
It can be useful in debugging snippet setup to look at the extraction output, but the tool cleans that up automatically. Running the extraction manually is complicated due to the on-the-fly pubspec modifications, so this adds a `--no-cleanup` flag that can be used to skip the deletion of the extraction output, and instead log its location to the terminal.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@stuartmorgan-g@Hixie