Uh oh!
There was an error while loading. Please reload this page.
[go_router] Adds a parentNavigatorKey parameter to ShellRouteData. - #4409
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
hannah-hyj
commented
Jul 12, 2023
Member
Add parentNavigatorKey to StatefulShellRouteData too? |
chunhtai
commented
Jul 13, 2023
ContributorAuthor
done |
hannah-hyj
approved these changes
Jul 18, 2023
johnpryan
approved these changes
Jul 18, 2023
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 20, 2023
auto-submitBot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 20, 2023
flutter/packages@209db21...674179f 2023-07-19 stuartmorgan@google.com [image_picker] Deprecate platform interface methods (flutter/packages#4520) 2023-07-19 47866232+chunhtai@users.noreply.github.com [go_router] Adds a parentNavigatorKey parameter to ShellRouteData. (flutter/packages#4409) 2023-07-19 stuartmorgan@google.com [ci] Shard Windows Dart unit tests (flutter/packages#4519) 2023-07-19 engine-flutter-autoroll@skia.org Roll Flutter from 6f09064 to d07e8ae (60 revisions) (flutter/packages#4522) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
LouiseHsu pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
flutter/packages@209db21...674179f 2023-07-19 stuartmorgan@google.com [image_picker] Deprecate platform interface methods (flutter/packages#4520) 2023-07-19 47866232+chunhtai@users.noreply.github.com [go_router] Adds a parentNavigatorKey parameter to ShellRouteData. (flutter/packages#4409) 2023-07-19 stuartmorgan@google.com [ci] Shard Windows Dart unit tests (flutter/packages#4519) 2023-07-19 engine-flutter-autoroll@skia.org Roll Flutter from 6f09064 to d07e8ae (60 revisions) (flutter/packages#4522) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
bisor0627 pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supports #4356
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.