[image_picker_web] Listens to file input cancel event. by ditman · Pull Request #4453 · flutter/packages

ditman · 2023-07-13T02:33:26Z

Changes

This PR listens to the cancel event from the input type=file used by the web implementation of the image_picker plugin, so apps don't end up endlessly awaiting for a file that will never come in modern browsers (Chrome 113, Safari 16.4, or newer). Same API as #3683.

Additionally, this PR:

Removes all code and tests mentioning PickedFile. (Deprecated years ago, and unused since [image_picker] Update to 1.0 #4285) (Breaking change)
Updates README to mention XFile which is the current return type of the package.
Updates the dependency on image_picker_platform_interface to ^2.9.0.
- Implements all non-deprecated methods from the interface, and makes deprecated methods use the fresh ones.
- Updates tests.

Issues

Fixes[image_picker][web] cancel cause picker to never return flutter#92176

Testing

Added integration testing coverage for the 'cancel' event.
Tested manually in Chrome with the example app running on web.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

ditman · 2023-07-17T21:24:23Z

I've updated the README to mention the current methods (not the ones I'm removing), and marked this change as a major version to prevent any issues with package resolution (I'll send a PR updating image_picker to v.3 of the web implementation after this lands). PTAL @stuartmorgan!

stuartmorgan-g

LGTM modulo the version constraint.

* Delegates deprecated methods to non-deprecated ones.

* Moves tests of old methods to a "Deprecated" group so they can be cleaned up easily later.

…iguration object can do.

ditman · 2023-08-04T00:55:42Z

Hey @stuartmorgan, here's the refresh to the image_picker_web to implement the latest platform interface! PTAL (and change/merge at will)

stuartmorgan-g

StillLGTM

…er/packages#4453)

flutter/packages@d00c1f9...ce53da1 2023-08-04 ditman@gmail.com [image_picker_web] Listens to file input cancel event. (flutter/packages#4453) 2023-08-04 maurits@vnbskm.nl [in_app_purchase] Updates handling of subscription price changes in README. (flutter/packages#4643) 2023-08-03 stuartmorgan@google.com [pigeon] Consolidate main Dart unit tests (flutter/packages#4641) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

## Changes This PR listens to the `cancel` event from the `input type=file` used by the web implementation of the image_picker plugin, so apps don't end up endlessly awaiting for a file that will never come **in modern browsers** (Chrome 113, Safari 16.4, or newer). _Same API as flutter#3683 Additionally, this PR: * Removes all code and tests mentioning `PickedFile`. (Deprecated years ago, and unused since flutter#4285) **(Breaking change)** * Updates README to mention `XFile` which is the current return type of the package. * Updates the dependency on `image_picker_platform_interface` to `^2.9.0`. * Implements all non-deprecated methods from the interface, and makes deprecated methods use the fresh ones. * Updates tests. ### Issues * Fixesflutter/flutter#92176 ### Testing * Added integration testing coverage for the 'cancel' event. * Tested manually in Chrome with the example app running on web.

ditman requested a review from stuartmorgan-g July 13, 2023 02:33

github-actionsBot added p: image_picker platform-web labels Jul 13, 2023

ditman mentioned this pull request Jul 13, 2023
[image_picker][web] cancel cause picker to never return flutter/flutter#92176
Closed

ditman commented Jul 13, 2023
View reviewed changes

Comment threadpackages/image_picker/image_picker_for_web/CHANGELOG.md Outdated

stuartmorgan-g requested changes Jul 17, 2023
View reviewed changes

Comment threadpackages/image_picker/image_picker_for_web/README.md Outdated

ditman force-pushed the image-picker-web-cancel-event branch from f8c9ba3 to 4f1047fCompare July 17, 2023 21:16

ditman requested a review from stuartmorgan-g July 17, 2023 21:24

stuartmorgan-g mentioned this pull request Jul 18, 2023
[image_picker] Update Android example #4504
Merged
11 tasks

ditman force-pushed the image-picker-web-cancel-event branch from 4f1047f to 08eb6d1Compare July 19, 2023 18:06

stuartmorgan-g approved these changes Jul 20, 2023
View reviewed changes

Comment threadpackages/image_picker/image_picker_for_web/pubspec.yaml Outdated
Comment threadpackages/image_picker/image_picker_for_web/README.md Outdated

ditman added 3 commits August 3, 2023 16:13

[image_picker_web] Listens to file input cancel event.
f6103fc

Remove deprecated method names from README.
2cba588

Mark as a major change.
c40b18c

ditman force-pushed the image-picker-web-cancel-event branch from 08eb6d1 to c40b18cCompare August 3, 2023 23:13

ditman added 5 commits August 3, 2023 17:34

Implements non-deprecated methods.
35170c9
* Delegates deprecated methods to non-deprecated ones.

Updates tests to use new methods.
c4792e8
* Moves tests of old methods to a "Deprecated" group so they can be cleaned up easily later.

Updates platform_interface dependency.
aec29c5

Stop talking about deprecated methods, and describe what the new conf…
b5a6215
…iguration object can do.

Blob in backticks
bc7c707

ditman requested a review from stuartmorgan-g August 4, 2023 00:55

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 4, 2023

stuartmorgan-g approved these changes Aug 4, 2023
View reviewed changes

auto-submitBot merged commit ce53da1 into flutter:mainAug 4, 2023

engine-flutter-autoroll mentioned this pull request Aug 4, 2023
Roll Packages from d00c1f9eb01c to ce53da1bd741 (3 revisions) flutter/flutter#131935
Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 4, 2023
ce53da1[image_picker_web] Listens to file input cancel event. (flutt…
c2b7c44
…er/packages#4453)

loic-hamdi mentioned this pull request Sep 29, 2023
Doesn't seem to work flutter/flutter#135733
Closed

Navigation Menu

Uh oh!

[image_picker_web] Listens to file input cancel event. - #4453

[image_picker_web] Listens to file input cancel event.#4453
auto-submit[bot] merged 8 commits into
flutter:mainfrom
ditman:image-picker-web-cancel-event

ditman commented Jul 13, 2023•
edited
Loading

Uh oh!

Uh oh!

Uh oh!

ditman commented Jul 17, 2023•
edited
Loading

Uh oh!

stuartmorgan-g left a comment

Uh oh!

Uh oh!

Uh oh!

ditman commented Aug 4, 2023

Uh oh!

stuartmorgan-g left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

ditman commented Jul 13, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Issues

Testing

Pre-launch Checklist

Uh oh!

Uh oh!

Uh oh!

ditman commented Jul 17, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ditman commented Aug 4, 2023

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ditman commented Jul 13, 2023•
edited
Loading

ditman commented Jul 17, 2023•
edited
Loading