Skip to content

[xdg_directories] Remove process dependency - #4460

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
stuartmorgan-g:xdg-remove-process
Jul 14, 2023
Merged

[xdg_directories] Remove process dependency#4460
auto-submit[bot] merged 1 commit into
flutter:mainfrom
stuartmorgan-g:xdg-remove-process

Conversation

@stuartmorgan-g

@stuartmorgan-gstuartmorgan-g commented Jul 13, 2023

Copy link
Copy Markdown
Collaborator

Replaces the process dependency with direct use of io.Process, to reduce external dependencies, since this is a path_provider dependency and thus a core package.

Fixesflutter/flutter#129787

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan-g
[xdg_directories] Remove process dependency
adfb789
Replaces the `process` dependency with direct use of `io.Process`, to
reduce external dependencies, since this is a `path_provider` dependency
and thus a core package.
Fixesflutter/flutter#129787
gspencergoog
gspencergoog approved these changes Jul 13, 2023
View reviewed changes

@gspencergooggspencergoog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Thanks for doing this. Seems like a good idea all around.

@stuartmorgan-gstuartmorgan-g added autosubmit Merge PR when tree becomes green via auto submit App emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label. labels Jul 13, 2023
@stuartmorgan-g

stuartmorgan-g commented Jul 14, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Overriding stale tree status check.

@auto-submit
auto-submitBot merged commit b166a0f into flutter:mainJul 14, 2023
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
b166a0f[xdg_directories] Removeprocessdependency (flutter/packag…
c095b56
…es#4460)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
b166a0f[xdg_directories] Removeprocessdependency (flutter/packag…
100c1f2
…es#4460)
@reidbakerreidbaker mentioned this pull request Jul 14, 2023
Merged
11 tasks
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jul 14, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
b166a0f[xdg_directories] Removeprocessdependency (flutter/packag…
fea5a25
…es#4460)
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
Roll Packages fromaa1eaceto369ee7e(10 revisions) (#130605)
41d137f
flutter/packages@aa1eace...369ee7e
2023-07-14 reidbaker@google.com [Tool] New tool to download android dependencies (flutter/packages#4408)
2023-07-14 zaldypagaduanjr@gmail.com [video_player] added iOS exception on incorrect asset path (flutter/packages#4318)
2023-07-14 joonas.kerttula@codemate.com [google_maps_flutter_platform_interface] Add support for cloud-based map styling (flutter/packages#4141)
2023-07-14 10687576+bparrishMines@users.noreply.github.com [webview_flutter] Adds support for receiving a url with WebResourceError (flutter/packages#3884)
2023-07-14 stuartmorgan@google.com [xdg_directories] Remove `process` dependency (flutter/packages#4460)
2023-07-13 stuartmorgan@google.com [various] Update Pigeon in Swift plugins (flutter/packages#4461)
2023-07-13 engine-flutter-autoroll@skia.org Roll Flutter from 544d30d to c40173f (10 revisions) (flutter/packages#4457)
2023-07-13 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 796c8ef to f468f33 (2 revisions) (flutter/packages#4456)
2023-07-13 bisor0627@gmail.com Fix Router Config Issues #4300 (go_router_builder/example) (flutter/packages#4369)
2023-07-13 10687576+bparrishMines@users.noreply.github.com [webview_flutter_platform_interface] Adds url to `WebResourceError` (flutter/packages#4439)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbakerreidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
@engine-flutter-autoroll@LouiseHsu
Roll Packages fromaa1eaceto369ee7e(10 revisions) (flutter#130605)
5e100a1
flutter/packages@aa1eace...369ee7e
2023-07-14 reidbaker@google.com [Tool] New tool to download android dependencies (flutter/packages#4408)
2023-07-14 zaldypagaduanjr@gmail.com [video_player] added iOS exception on incorrect asset path (flutter/packages#4318)
2023-07-14 joonas.kerttula@codemate.com [google_maps_flutter_platform_interface] Add support for cloud-based map styling (flutter/packages#4141)
2023-07-14 10687576+bparrishMines@users.noreply.github.com [webview_flutter] Adds support for receiving a url with WebResourceError (flutter/packages#3884)
2023-07-14 stuartmorgan@google.com [xdg_directories] Remove `process` dependency (flutter/packages#4460)
2023-07-13 stuartmorgan@google.com [various] Update Pigeon in Swift plugins (flutter/packages#4461)
2023-07-13 engine-flutter-autoroll@skia.org Roll Flutter from 544d30d to c40173f (10 revisions) (flutter/packages#4457)
2023-07-13 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 796c8ef to f468f33 (2 revisions) (flutter/packages#4456)
2023-07-13 bisor0627@gmail.com Fix Router Config Issues flutter#4300 (go_router_builder/example) (flutter/packages#4369)
2023-07-13 10687576+bparrishMines@users.noreply.github.com [webview_flutter_platform_interface] Adds url to `WebResourceError` (flutter/packages#4439)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbakerreidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@stuartmorgan-g
[xdg_directories] Removeprocessdependency (flutter#4460)
1b53e8d
Replaces the `process` dependency with direct use of `io.Process`, to reduce external dependencies, since this is a `path_provider` dependency and thus a core package.
Fixesflutter/flutter#129787
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@stuartmorgan-g
[xdg_directories] Removeprocessdependency (flutter#4460)
9dc0f22
Replaces the `process` dependency with direct use of `io.Process`, to reduce external dependencies, since this is a `path_provider` dependency and thus a core package.
Fixesflutter/flutter#129787
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergooggspencergooggspencergoog approved these changes

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit AppemergencyOverride tree-status signal (land even with closed tree), combine with the autosubmit label.p: xdg_directories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[xdg_directories] Remove process dependency

2 participants

@stuartmorgan-g@gspencergoog