Uh oh!
There was an error while loading. Please reload this page.
[cross_file] Document mime type is not made for io implementations - #4549
Closed
ValentinVignal wants to merge 14 commits into
Closed
[cross_file] Document mime type is not made for io implementations #4549ValentinVignal wants to merge 14 commits into
ValentinVignal wants to merge 14 commits into
Conversation
ValentinVignal
commented
Jul 22, 2023
ContributorAuthor
That "fix" seems a bit "small" / "light" to me. Can you help me figure out what else should be good to be done about that? |
ditman
commented
Jul 24, 2023
Member
@ValentinVignal this is very similar to #4416, any chance of collaborating with @andreacioni to render all doc improvements to |
andreacioni
commented
Jul 25, 2023
Contributor
Hello, no problem for me. I can integrate your changes in my PR @ValentinVignal . Let me know if this solution works for you 😊 |
ValentinVignal
commented
Jul 26, 2023
ContributorAuthor
Should I create the PR on your branch then @andreacioni ? |
andreacioni
commented
Jul 26, 2023
Contributor
Yeah, I think it would work. Feel free to open it. |
ValentinVignal
commented
Jul 31, 2023
ContributorAuthor
Closing in favor of andreacioni#1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixesflutter/flutter#93379
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.