Uh oh!
There was an error while loading. Please reload this page.
[dynamic_layouts] relax layout test to fix tree - #4677
Merged
Conversation
Piinks
approved these changes
Aug 10, 2023
Piinks
left a comment
Contributor
There was a problem hiding this comment.
LGTM, I will file an issue to follow up on these tests. Thy appear to have become rather brittle to text changes.
Piinks
commented
Aug 10, 2023
Contributor
Filed flutter/flutter#132321 |
Contributor
auto label is removed for flutter/packages/4677, due to - The status or check suite Linux_web web_dart_unit_test_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 11, 2023
auto-submitBot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 11, 2023
flutter/packages@881c1f5...9b15c2e 2023-08-10 tarrinneal@gmail.com [dynamic_layouts] relax layout test to fix tree (flutter/packages#4677) 2023-08-10 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.2 to 2.21.3 (flutter/packages#4664) 2023-08-09 jhy03261997@gmail.com go_router should allow setting requestFocus (flutter/packages#4636) 2023-08-09 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android][webview_flutter_wkwebview] Fixes widget rebuild bug caused by key type (flutter/packages#4667) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
auto-submitBot
pushed a commit
that referenced
this pull request
Aug 11, 2023
This refactors a test for the example of a wrapped layout in dynamic_tests. This test had become brittle to small text changes because it would check the precise layout offset of the text. It was patched in these cases in #4513 and #4677 to address tiny text variations across platforms and material 2/3 defaults. This refactor changes the test to check the layout offset of the parent Container of the text, which should not have these subtle variations. Fixesflutter/flutter#132321
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
A current roll from the engine to flutter/flutter to packages has broken this test value by a small amount. I wrote a small function to manage tolerances. Let me know if this is a reasonable way to manage this for now.
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
This refactors a test for the example of a wrapped layout in dynamic_tests. This test had become brittle to small text changes because it would check the precise layout offset of the text. It was patched in these cases in flutter#4513 and flutter#4677 to address tiny text variations across platforms and material 2/3 defaults. This refactor changes the test to check the layout offset of the parent Container of the text, which should not have these subtle variations. Fixesflutter/flutter#132321
bisor0627 pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
A current roll from the engine to flutter/flutter to packages has broken this test value by a small amount. I wrote a small function to manage tolerances. Let me know if this is a reasonable way to manage this for now.
bisor0627 pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
This refactors a test for the example of a wrapped layout in dynamic_tests. This test had become brittle to small text changes because it would check the precise layout offset of the text. It was patched in these cases in flutter#4513 and flutter#4677 to address tiny text variations across platforms and material 2/3 defaults. This refactor changes the test to check the layout offset of the parent Container of the text, which should not have these subtle variations. Fixesflutter/flutter#132321
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A current roll from the engine to flutter/flutter to packages has broken this test value by a small amount.
I wrote a small function to manage tolerances.
Let me know if this is a reasonable way to manage this for now.