Uh oh!
There was an error while loading. Please reload this page.
[webview_flutter] Update sample code. - #4727
Merged
Merged
Conversation
opxdelwin
commented
Aug 17, 2023
ContributorAuthor
@bparrishMines requesting test-exempt |
bparrishMines
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing this. I just had one small comment.
cc @stuartmorgan or @tarrinneal for a quick secondary review
Uh oh!
There was an error while loading. Please reload this page.
stuartmorgan-g
approved these changes
Aug 18, 2023
stuartmorgan-g
left a comment
Collaborator
There was a problem hiding this comment.
LGTM with the suggested change.
Co-authored-by: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com>
opxdelwin
commented
Aug 22, 2023
ContributorAuthor
@stuartmorgan@bparrishMines ready to merge |
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 23, 2023
auto-submitBot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 23, 2023
flutter/packages@c730a90...3060b1a 2023-08-23 ian@hixie.ch [rfw] Support web (as JS) (flutter/packages#4650) 2023-08-22 84124091+opxdelwin@users.noreply.github.com [webview_flutter] Update sample code. (flutter/packages#4727) 2023-08-22 ctrysbita@outlook.com [flutter_adaptive_scaffold] Fix top padding for NavigationBar (flutter/packages#4661) 2023-08-22 31859944+LongCatIsLooong@users.noreply.github.com Remove deprecated `ImageProvider` methods (flutter/packages#4725) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
Documentation was updated in app-example file but not in `webview_controller.dart`. 'output' is a positional parameter now, and `JavascriptMessage` changed to `JavaScriptMessage` Fixes issue flutter/flutter#132727
bisor0627 pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
Documentation was updated in app-example file but not in `webview_controller.dart`. 'output' is a positional parameter now, and `JavascriptMessage` changed to `JavaScriptMessage` Fixes issue flutter/flutter#132727
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation was updated in app-example file but not in
webview_controller.dart.'output' is a positional parameter now, and
JavascriptMessagechanged toJavaScriptMessageFixes issue flutter/flutter#132727
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.