Skip to content

[flutter_markdown] Remove ignore: avoid_init_to_null since the package uses Dart 3 - #4852

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
nilsreichardt:refactor-ignore-avoid_init_to_null
Sep 7, 2023
Merged

[flutter_markdown] Remove ignore: avoid_init_to_null since the package uses Dart 3#4852
auto-submit[bot] merged 1 commit into
flutter:mainfrom
nilsreichardt:refactor-ignore-avoid_init_to_null

Conversation

@nilsreichardt

@nilsreichardtnilsreichardt commented Sep 5, 2023

Copy link
Copy Markdown
Contributor

As the removed comment says, since the package uses Dart 3 we can remove the ignore: avoid_init_to_null.

Fixesflutter/flutter#134058

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@nilsreichardt

nilsreichardt commented Sep 5, 2023

Copy link
Copy Markdown
ContributorAuthor

Let me know if this change also requires a bump of the package version.

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 7, 2023
@auto-submit
auto-submitBot merged commit 85d9ce3 into flutter:mainSep 7, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2023
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Sep 8, 2023
flutter/packages@22d4754...aaae5ef
2023-09-08 43054281+camsim99@users.noreply.github.com [tool] Add Android dependency (gradle) option to update dependencies command (flutter/packages#4757)
2023-09-08 43054281+camsim99@users.noreply.github.com [camerax] Implement resolution configuration (flutter/packages#3799)
2023-09-07 engine-flutter-autoroll@skia.org Manual roll Flutter from 685ce14 to aea4552 (64 revisions) (flutter/packages#4870)
2023-09-07 ditman@gmail.com [rfw, ci] Regenerate goldens, manually roll #4835 (flutter/packages#4862)
2023-09-07 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.6.0 to 4.0.0 (flutter/packages#4845)
2023-09-07 defuncart@gmail.com [video_player] Add optional web options [web] (flutter/packages#4551)
2023-09-07 me@nils.re [flutter_markdown] Remove `ignore: avoid_init_to_null` since the package uses Dart 3 (flutter/packages#4852)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbakerreidbaker mentioned this pull request Sep 15, 2023
11 tasks
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…age uses Dart 3 (flutter#4852)
As the removed comment says, since the package uses Dart 3 we can remove the `ignore: avoid_init_to_null`. Fixesflutter/flutter#134058
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
…age uses Dart 3 (flutter#4852)
As the removed comment says, since the package uses Dart 3 we can remove the `ignore: avoid_init_to_null`. Fixesflutter/flutter#134058
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: flutter_markdown

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ignore: avoid_init_to_null can be removed in flutter_markdown

3 participants

@nilsreichardt@domesticmouse@stuartmorgan-g