Skip to content

[camera] Fix Android autofocus state reading - #5025

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
stuartmorgan-g:camera-android-af-fix
Sep 28, 2023
Merged

[camera] Fix Android autofocus state reading#5025
auto-submit[bot] merged 1 commit into
flutter:mainfrom
stuartmorgan-g:camera-android-af-fix

Conversation

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

Fixes a typo introduced during a testability refactor that caused the capture state machine to read the wrong value for autofocus state, breaking the state machine.

Fixesflutter/flutter#135554
Part of flutter/flutter#84957

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Fixes a typo introduced during a testability refactor that caused the
capture state machine to read the wrong value for autofocus state,
breaking the state machine.
Fixesflutter/flutter#135554
Part of flutter/flutter#84957

@camsim99camsim99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a good catch!!

@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 28, 2023
@auto-submit
auto-submitBot merged commit 245a8a0 into flutter:mainSep 28, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 29, 2023
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Sep 29, 2023
flutter/packages@c070b0a...d0e9a0e
2023-09-28 stuartmorgan@google.com [video_player] Endorse macOS (flutter/packages#5021)
2023-09-28 engine-flutter-autoroll@skia.org Manual roll Flutter from f92884c to ff4a0f6 (107 revisions) (flutter/packages#5011)
2023-09-28 stuartmorgan@google.com [camera] Fix Android autofocus state reading (flutter/packages#5025)
2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 12fccda to ead4559 (1 revision) (flutter/packages#5022)
2023-09-28 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.8 to 2.21.9 (flutter/packages#5020)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
flutter/packages@c070b0a...d0e9a0e
2023-09-28 stuartmorgan@google.com [video_player] Endorse macOS (flutter/packages#5021)
2023-09-28 engine-flutter-autoroll@skia.org Manual roll Flutter from f92884c to ff4a0f6 (107 revisions) (flutter/packages#5011)
2023-09-28 stuartmorgan@google.com [camera] Fix Android autofocus state reading (flutter/packages#5025)
2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 12fccda to ead4559 (1 revision) (flutter/packages#5022)
2023-09-28 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.8 to 2.21.9 (flutter/packages#5020)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
Fixes a typo introduced during a testability refactor that caused the capture state machine to read the wrong value for autofocus state, breaking the state machine.
Fixesflutter/flutter#135554
Part of flutter/flutter#84957
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
Fixes a typo introduced during a testability refactor that caused the capture state machine to read the wrong value for autofocus state, breaking the state machine.
Fixesflutter/flutter#135554
Part of flutter/flutter#84957
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: cameraplatform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AutoFocus timing out in Android

2 participants

@stuartmorgan-g@camsim99