Skip to content

[path_provider] Fix integration tests - #5075

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
stuartmorgan-g:path-provider-test-update
Oct 4, 2023
Merged

[path_provider] Fix integration tests#5075
auto-submit[bot] merged 1 commit into
flutter:mainfrom
stuartmorgan-g:path-provider-test-update

Conversation

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator
  • Fix the throwsA test to properly await.
  • Updates the getDownloadsDirectory test to not assume that Android will throw, since that is no longer true.

- Fix the `throwsA` test to properly await.
- Updates the `getDownloadsDirectory` test to not assume that Android
will throw, since that is no longer true.

@cyanglazcyanglaz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanglazcyanglaz added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 4, 2023
@auto-submit
auto-submitBot merged commit 5badf97 into flutter:mainOct 4, 2023
@stuartmorgan-g
stuartmorgan-g deleted the path-provider-test-update branch October 4, 2023 20:45
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 5, 2023
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Oct 5, 2023
flutter/packages@d654f75...6714d50
2023-10-04 stuartmorgan@google.com [webview_flutter] Fix XCUITest in Xcode 15 (flutter/packages#5071)
2023-10-04 stuartmorgan@google.com [path_provider] Fix integration tests (flutter/packages#5075)
2023-10-04 dawidope@gmail.com [flutter_markdown] Footnote support (flutter/packages#5058)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
flutter/packages@d654f75...6714d50
2023-10-04 stuartmorgan@google.com [webview_flutter] Fix XCUITest in Xcode 15 (flutter/packages#5071)
2023-10-04 stuartmorgan@google.com [path_provider] Fix integration tests (flutter/packages#5075)
2023-10-04 dawidope@gmail.com [flutter_markdown] Footnote support (flutter/packages#5058)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
- Fix the `throwsA` test to properly await.
- Updates the `getDownloadsDirectory` test to not assume that Android will throw, since that is no longer true.
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
- Fix the `throwsA` test to properly await.
- Updates the `getDownloadsDirectory` test to not assume that Android will throw, since that is no longer true.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: path_provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@stuartmorgan-g@cyanglaz