Skip to content

[flutter_markdown] Fix typo in readme - #5096

Merged
auto-submit[bot] merged 8 commits into
flutter:mainfrom
nohli:typo
Oct 10, 2023
Merged

[flutter_markdown] Fix typo in readme#5096
auto-submit[bot] merged 8 commits into
flutter:mainfrom
nohli:typo

Conversation

@nohli

@nohlinohli commented Oct 9, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Since HTML is pronounced with an A at the beginning (at least by around 85% of people), it should probably be spelled an HTML.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

domesticmouse
domesticmouse reviewed Oct 9, 2023
View reviewed changes
Comment threadpackages/flutter_markdown/README.md
HTML representation of the Markdown data.

## Flutter Isn't a HTML Renderer
## Flutter Isn't an HTML Renderer

@domesticmousedomesticmouseOct 9, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd argue the H in HTML is sounded, and thus a is correct in this position per https://owl.purdue.edu/owl/general_writing/grammar/articles_a_versus_an.html

Hey @sfshaza2 or @atsansone wanna tie break?

@nohlinohliOct 10, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the link, there is no instance of "a h", but twice "an h"

Exceptions
Use "an" before a silent or unsounded "h." Because the "h" does not have any phonetic representation or audible sound, the sound that follows the article is a vowel; consequently, "an" is used.
an honorable peace
an honest error

@stuartmorgan-gstuartmorgan-gOct 10, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd argue the H in HTML is sounded

For an initialism it doesn't really make sense to say a letter is sounded or unsounded; the sound of the letters isn't used at all.

The deciding factor is the pronunciation of the letter H as a word. Since Flutter style uses US English spelling, we should spell this based on prevailing US pronunciation (which starts with an "ay"/"ai" sound), making "an" correct.

stuartmorgan-g
stuartmorgan-g reviewed Oct 10, 2023
View reviewed changes
Comment threadpackages/flutter_markdown/CHANGELOG.md
nohli
nohli commented Oct 10, 2023
View reviewed changes
Comment threadpackages/flutter_markdown/CHANGELOG.md
nohli
nohli commented Oct 10, 2023
View reviewed changes
Comment threadpackages/flutter_markdown/pubspec.yaml
stuartmorgan-g
stuartmorgan-g requested changes Oct 10, 2023
View reviewed changes
Comment threadpackages/flutter_markdown/CHANGELOG.md
nohli
nohli commented Oct 10, 2023
View reviewed changes
Comment threadpackages/flutter_markdown/CHANGELOG.md Outdated
nohli
nohli commented Oct 10, 2023
View reviewed changes
Comment threadpackages/flutter_markdown/pubspec.yaml Outdated
@domesticmouse
domesticmouse removed the request for review from sfshaza2October 10, 2023 22:03
@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 10, 2023
@auto-submit
auto-submitBot merged commit 69d3985 into flutter:mainOct 10, 2023
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
69d3985[flutter_markdown] Fix typo in readme (flutter/packages#5096)
6ca9708
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
69d3985[flutter_markdown] Fix typo in readme (flutter/packages#5096)
d47d679
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Oct 12, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
69d3985[flutter_markdown] Fix typo in readme (flutter/packages#5096)
c33b107
fluttermirroringbot pushed a commit to flutter/flutter that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
Roll Packages from4b483f2to93c3f69(9 revisions) (#136461)
ee7e41f
flutter/packages@4b483f2...93c3f69
2023-10-12 goderbauer@google.com [shared_preferences] update file version constraints (flutter/packages#5121)
2023-10-12 supercionci@hotmail.it [cross_file] Improved documentation about ignored parameters in IO module. (flutter/packages#4416)
2023-10-11 41873024+droidbg@users.noreply.github.com [in_app_purchase] [#135759] Fix. doc reference finishPurchase to completePurchase. (flutter/packages#5081)
2023-10-10 zeucxb@gmail.com Update repo README issues link (flutter/packages#5106)
2023-10-10 43643339+nohli@users.noreply.github.com [flutter_markdown] Fix typo in readme (flutter/packages#5096)
2023-10-10 43054281+camsim99@users.noreply.github.com [camerax] Implements torch mode (flutter/packages#4903)
2023-10-10 25266387+Leptopoda@users.noreply.github.com [shared_preferences] fix documentation wording (flutter/packages#4986)
2023-10-10 katelovett@google.com [two_dimensional_scrollables] Fix paint bug when rows/columns are pinned and axes are reversed (flutter/packages#5038)
2023-10-10 engine-flutter-autoroll@skia.org Roll Flutter from f52fe4f to 83134ac (25 revisions) (flutter/packages#5104)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@nohli
[flutter_markdown] Fix typo in readme (flutter#5096)
f97e390
Since HTML is pronounced with an A at the beginning (at least by around [85%](https://english.stackexchange.com/a/23762) of people), it should [probably](https://english.stackexchange.com/a/25746) be spelled `an HTML`.
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@nohli
[flutter_markdown] Fix typo in readme (flutter#5096)
9efa596
Since HTML is pronounced with an A at the beginning (at least by around [85%](https://english.stackexchange.com/a/23762) of people), it should [probably](https://english.stackexchange.com/a/25746) be spelled `an HTML`.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domesticmousedomesticmousedomesticmouse approved these changes
@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: flutter_markdown

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nohli@domesticmouse@stuartmorgan-g