Skip to content

[quick_actions] Convert android to pigeon - #5099

Merged
auto-submit[bot] merged 6 commits into
flutter:mainfrom
tarrinneal:QA-pigeon
Oct 17, 2023
Merged

[quick_actions] Convert android to pigeon#5099
auto-submit[bot] merged 6 commits into
flutter:mainfrom
tarrinneal:QA-pigeon

Conversation

@tarrinneal

@tarrinnealtarrinneal commented Oct 10, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Converts from direct use of method channels to using Pigeon.

Part of flutter/flutter#117844
part of flutter/flutter#117913

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@tarrinneal
tarrinnealforce-pushed the QA-pigeon branch 2 times, most recently from 62579ff to b294b3cCompareOctober 13, 2023 01:56
@tarrinnealtarrinneal changed the title Qa pigeon[quick_actions] Convert android to pigeonOct 13, 2023
@tarrinneal
tarrinneal marked this pull request as ready for review October 13, 2023 02:12
stuartmorgan-g
stuartmorgan-g requested changes Oct 13, 2023
View reviewed changes
Comment thread...ctions_android/android/src/main/java/io/flutter/plugins/quickactions/QuickActionsPlugin.java Outdated
Comment thread...ctions_android/android/src/main/java/io/flutter/plugins/quickactions/QuickActionsPlugin.java Outdated
Comment thread...ctions_android/android/src/main/java/io/flutter/plugins/quickactions/QuickActionsPlugin.java Outdated
Comment thread...ctions_android/android/src/main/java/io/flutter/plugins/quickactions/QuickActionsPlugin.java Outdated
Comment thread..._actions_android/android/src/test/java/io/flutter/plugins/quickactions/QuickActionsTest.java Outdated
Comment thread...uick_actions_android/android/src/main/java/io/flutter/plugins/quickactions/QuickActions.java Outdated
Comment thread...uick_actions_android/android/src/main/java/io/flutter/plugins/quickactions/QuickActions.java Outdated
Comment thread...uick_actions_android/android/src/main/java/io/flutter/plugins/quickactions/QuickActions.java Outdated
Comment thread...uick_actions_android/android/src/main/java/io/flutter/plugins/quickactions/QuickActions.java Outdated
Comment thread...uick_actions_android/android/src/main/java/io/flutter/plugins/quickactions/QuickActions.java Outdated
stuartmorgan-g
stuartmorgan-g requested changes Oct 16, 2023
View reviewed changes
Comment thread...uick_actions_android/android/src/main/java/io/flutter/plugins/quickactions/QuickActions.java Outdated
Comment thread...uick_actions_android/android/src/main/java/io/flutter/plugins/quickactions/QuickActions.java Outdated
Comment threadpackages/quick_actions/quick_actions_android/lib/quick_actions_android.dart Outdated
Comment threadpackages/quick_actions/quick_actions_android/lib/quick_actions_android.dart Outdated
Comment threadpackages/quick_actions/quick_actions_android/test/quick_actions_android_test.dart Outdated
stuartmorgan-g
stuartmorgan-g approved these changes Oct 17, 2023
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tarrinnealtarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 17, 2023
@auto-submit
auto-submitBot merged commit e8127e7 into flutter:mainOct 17, 2023
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Oct 17, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 17, 2023
@engine-flutter-autoroll
e8127e7[quick_actions] Convert android to pigeon (flutter/packages#5099
a5b4fc6
)
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Oct 17, 2023
@engine-flutter-autoroll
Roll Packages from872d6d2tod439062(4 revisions) (#136724)
5739397
flutter/packages@872d6d2...d439062
2023-10-17 ditman@gmail.com [gis_web] Adds FedCM toggle. (flutter/packages#5123)
2023-10-17 tarrinneal@gmail.com [quick_actions] Convert android to pigeon (flutter/packages#5099)
2023-10-16 70025277+Nitin-Poojary@users.noreply.github.com [flutter_image] added example app (flutter/packages#4353)
2023-10-16 engine-flutter-autoroll@skia.org Roll Flutter from b00216b to afc3916 (12 revisions) (flutter/packages#5156)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@tarrinneal
[quick_actions] Convert android to pigeon (flutter#5099)
70bb108
Converts from direct use of method channels to using Pigeon.
Part of flutter/flutter#117844
part of flutter/flutter#117913
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@tarrinneal
[quick_actions] Convert android to pigeon (flutter#5099)
6364237
Converts from direct use of method channels to using Pigeon.
Part of flutter/flutter#117844
part of flutter/flutter#117913
@SembaukeSembauke mentioned this pull request Jul 31, 2026
Open
11 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes
@camsim99camsim99Awaiting requested review from camsim99

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: quick_actionsplatform-android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tarrinneal@stuartmorgan-g