Skip to content

[2 pkgs] migrate to pkg:web - #5407

Closed
kevmoo wants to merge 24 commits into
mainfrom
pkg_web_wip
Closed

[2 pkgs] migrate to pkg:web#5407
kevmoo wants to merge 24 commits into
mainfrom
pkg_web_wip

Conversation

@kevmoo

@kevmookevmoo commented Nov 15, 2023

Copy link
Copy Markdown
Contributor

Migrated from dart:html to pkg:web for

  • file_selector_web
  • url_launcher_web

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@kevmookevmoo changed the title Migrate several packages to pkg:web[many] packages to pkg:webNov 15, 2023
@kevmoo
kevmoo marked this pull request as draft November 15, 2023 21:42
@kevmoo

Copy link
Copy Markdown
ContributorAuthor

Blocked on the flutter autoroller updating stable to...latest stable

@kevmoo
kevmoo marked this pull request as ready for review November 15, 2023 23:40
@kevmookevmoo changed the title [many] packages to pkg:web[2 pkgs] migrate to pkg:webNov 16, 2023
@kevmookevmoo closed this Nov 20, 2023
@kevmoo
kevmoo deleted the pkg_web_wip branch November 20, 2023 20:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@kevmoo