Uh oh!
There was an error while loading. Please reload this page.
[camerax] Wrap Android classes/methods required for implementing setting focus & exposure points and offset - #5659
Merged
Merged
Conversation
camsim99
marked this pull request as ready for review
January 9, 2024 01:15
gmackall
approved these changes
Jan 23, 2024
gmackall
left a comment
Member
There was a problem hiding this comment.
LGTM! Just 3 typo fix suggestions
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
….dart Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>
…o/flutter/plugins/camerax/CameraControlTest.java Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>
…dart Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>
Contributor
auto label is removed for flutter/packages/5659, due to - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 25, 2024
…ing setting focus & exposure points and offset (flutter/packages#5659)
auto-submitBot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 25, 2024
flutter/packages@8fbdf65...21b5abb 2024-01-24 pageli328@gmail.com Add rfw widgets (flutter/packages#5661) 2024-01-24 50643541+Mairramer@users.noreply.github.com [camera] add heif support image iOS (flutter/packages#4586) 2024-01-24 jsharp83@gmail.com [webview_flutter_android] Add javascript panel interface for android (flutter/packages#5796) 2024-01-24 43054281+camsim99@users.noreply.github.com [camerax] Wrap Android classes/methods required for implementing setting focus & exposure points and offset (flutter/packages#5659) 2024-01-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.2.0 to 4.3.0 (flutter/packages#5967) 2024-01-24 engine-flutter-autoroll@skia.org Roll Flutter from 5b673c2 to 19b06f4 (21 revisions) (flutter/packages#5968) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
16 tasks
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…ing focus & exposure points and offset (flutter#5659) Wraps CameraX APIs needed to at least implement setting focus and exposure points and offset (`setFocusPoint`,`setExposurePoint`, `setExposureOffset`). Listed by class: `CameraControl` - [`startFocusAndMetering`](https://developer.android.com/reference/androidx/camera/core/CameraControl#startFocusAndMetering(androidx.camera.core.FocusMeteringAction)) - [`cancelFocusAndMetering`](https://developer.android.com/reference/androidx/camera/core/CameraControl#cancelFocusAndMetering()) - [`setExposureCompensationIndex`](https://developer.android.com/reference/androidx/camera/core/CameraControl#setExposureCompensationIndex(int)) `FocusMeteringAction` - `create` method for [this class](https://developer.android.com/reference/androidx/camera/core/FocusMeteringAction.Builder#Builder(androidx.camera.core.MeteringPoint,int)) `FocusMeteringResult` - `create` method for [this class](https://developer.android.com/reference/androidx/camera/core/FocusMeteringResult) - [`isFocusSuccessful`](https://developer.android.com/reference/kotlin/androidx/camera/core/FocusMeteringResult#isFocusSuccessful()) `MeteringPoint` - `create` method for the points that [`SurfaceOrientedMeteringPointFactory`](https://developer.android.com/reference/androidx/camera/core/SurfaceOrientedMeteringPointFactory) creates - [`getDefaultPointSize`](https://developer.android.com/reference/androidx/camera/core/MeteringPointFactory#getDefaultPointSize()) Part of flutter/flutter#120468 and flutter/flutter#120467.
bisor0627 pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
…ing focus & exposure points and offset (flutter#5659) Wraps CameraX APIs needed to at least implement setting focus and exposure points and offset (`setFocusPoint`,`setExposurePoint`, `setExposureOffset`). Listed by class: `CameraControl` - [`startFocusAndMetering`](https://developer.android.com/reference/androidx/camera/core/CameraControl#startFocusAndMetering(androidx.camera.core.FocusMeteringAction)) - [`cancelFocusAndMetering`](https://developer.android.com/reference/androidx/camera/core/CameraControl#cancelFocusAndMetering()) - [`setExposureCompensationIndex`](https://developer.android.com/reference/androidx/camera/core/CameraControl#setExposureCompensationIndex(int)) `FocusMeteringAction` - `create` method for [this class](https://developer.android.com/reference/androidx/camera/core/FocusMeteringAction.Builder#Builder(androidx.camera.core.MeteringPoint,int)) `FocusMeteringResult` - `create` method for [this class](https://developer.android.com/reference/androidx/camera/core/FocusMeteringResult) - [`isFocusSuccessful`](https://developer.android.com/reference/kotlin/androidx/camera/core/FocusMeteringResult#isFocusSuccessful()) `MeteringPoint` - `create` method for the points that [`SurfaceOrientedMeteringPointFactory`](https://developer.android.com/reference/androidx/camera/core/SurfaceOrientedMeteringPointFactory) creates - [`getDefaultPointSize`](https://developer.android.com/reference/androidx/camera/core/MeteringPointFactory#getDefaultPointSize()) Part of flutter/flutter#120468 and flutter/flutter#120467.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps CameraX APIs needed to at least implement setting focus and exposure points and offset (
setFocusPoint,setExposurePoint,setExposureOffset). Listed by class:CameraControlstartFocusAndMeteringcancelFocusAndMeteringsetExposureCompensationIndexFocusMeteringActioncreatemethod for this classFocusMeteringResultcreatemethod for this classisFocusSuccessfulMeteringPointcreatemethod for the points thatSurfaceOrientedMeteringPointFactorycreatesgetDefaultPointSizePart of flutter/flutter#120468 and flutter/flutter#120467.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).