Uh oh!
There was an error while loading. Please reload this page.
[ci][web] Ignore always_specify_types for JSArray. - #5669
Merged
Conversation
ditman
commented
Dec 13, 2023
MemberAuthor
(I don't think this even warrants a |
kevmoo
approved these changes
Dec 13, 2023
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 14, 2023
auto-submitBot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 14, 2023
flutter/packages@b5958e2...1151191 2023-12-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.8 to 3.22.11 (flutter/packages#5674) 2023-12-13 ditman@gmail.com [ci][web] Ignore always_specify_types for JSArray. (flutter/packages#5669) 2023-12-13 mikemcguiness@protonmail.com [tool] Add support for `.java`, `.gradle`, `.sh`, and `.m` files� (flutter/packages#5567) 2023-12-13 ditman@gmail.com [google_sign_in] Update (web) example app. (flutter/packages#5634) 2023-12-13 34871572+gmackall@users.noreply.github.com [path_provider] De-flake getExternalStorageDirectories test (flutter/packages#5628) 2023-12-13 ditman@gmail.com [google_sign_in_web] Stop relying on framework internals. (flutter/packages#5660) 2023-12-13 43054281+camsim99@users.noreply.github.com [Android] Bump Gradle version to 7.6.3 (flutter/packages#5522) 2023-12-13 mikemcguiness@protonmail.com [google_sign_in] Adopt code excerpts in README (flutter/packages#5521) 2023-12-13 mikemcguiness@protonmail.com [css_colors] Adopt code excerpts in README (flutter/packages#5478) 2023-12-13 JeroenWeener@users.noreply.github.com [webview_flutter] Support for handling basic authentication requests (Android) (flutter/packages#5454) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closed
12 tasks
16 tasks
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
The definition of `JSArray` (and `JSPromise`) from `dart:js_interop` is changing to `JSArray<T>`, and our analyzer complains about our usage of it with default `T`s, blocking Dart SDK rolls. This PR ignores the `always_specify_types` lint in the usages of `JSArray`, so this code passes analysis both with the current version of `dart:js_interop` and the next one. ## Issues * Fixesflutter/flutter#140076 * Cleanup flutter/flutter#140095
bisor0627 pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
The definition of `JSArray` (and `JSPromise`) from `dart:js_interop` is changing to `JSArray<T>`, and our analyzer complains about our usage of it with default `T`s, blocking Dart SDK rolls. This PR ignores the `always_specify_types` lint in the usages of `JSArray`, so this code passes analysis both with the current version of `dart:js_interop` and the next one. ## Issues * Fixesflutter/flutter#140076 * Cleanup flutter/flutter#140095
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The definition of
JSArray(andJSPromise) fromdart:js_interopis changing toJSArray<T>, and our analyzer complains about our usage of it with defaultTs, blocking Dart SDK rolls.This PR ignores the
always_specify_typeslint in the usages ofJSArray, so this code passes analysis both with the current version ofdart:js_interopand the next one.Issues
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.