Skip to content

[webview_flutter] Implement platform interface for JavaScript dialog - #5670

Merged
auto-submit[bot] merged 4 commits into
flutter:mainfrom
jsharp83:platform-interface-for-javascript-panel
Dec 19, 2023
Merged

[webview_flutter] Implement platform interface for JavaScript dialog#5670
auto-submit[bot] merged 4 commits into
flutter:mainfrom
jsharp83:platform-interface-for-javascript-panel

Conversation

@jsharp83

@jsharp83jsharp83 commented Dec 13, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Adds the platform interface implementation for JavaScript dailog.

This PR is part of a series of PRs that aim to closeflutter/flutter#30358 (comment)
The PR that contains all changes can be found at #4704

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jsharp83
jsharp83force-pushed the platform-interface-for-javascript-panel branch from 645d289 to d1ae610CompareDecember 14, 2023 01:24
stuartmorgan-g
stuartmorgan-g approved these changes Dec 14, 2023
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some comment nits I missed in the main PR.

Comment thread...view_flutter/webview_flutter_platform_interface/lib/src/types/javascript_dialog_request.dart Outdated

@stuartmorgan-gstuartmorgan-gDec 14, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: URL

(In comments it should be capitalized normally, rather than as code.)

Comment thread...view_flutter/webview_flutter_platform_interface/lib/src/types/javascript_dialog_request.dart Outdated

@stuartmorgan-gstuartmorgan-gDec 14, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URL

Comment thread...view_flutter/webview_flutter_platform_interface/lib/src/types/javascript_dialog_request.dart Outdated

@stuartmorgan-gstuartmorgan-gDec 14, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URL

Comment thread...view_flutter/webview_flutter_platform_interface/lib/src/types/javascript_dialog_request.dart Outdated

@stuartmorgan-gstuartmorgan-gDec 14, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: The message [...]

(To be consistent with the other comments.)

Comment thread...view_flutter/webview_flutter_platform_interface/lib/src/types/javascript_dialog_request.dart Outdated

@stuartmorgan-gstuartmorgan-gDec 14, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message [...]

Comment thread...view_flutter/webview_flutter_platform_interface/lib/src/types/javascript_dialog_request.dart Outdated

@stuartmorgan-gstuartmorgan-gDec 14, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message [...]

@jsharp83
jsharp83force-pushed the platform-interface-for-javascript-panel branch from ca18ce9 to b535b22CompareDecember 14, 2023 18:41
@jsharp83
jsharp83force-pushed the platform-interface-for-javascript-panel branch from 88c04ee to 68bed91CompareDecember 16, 2023 00:28
@jsharp83

jsharp83 commented Dec 16, 2023

Copy link
Copy Markdown
ContributorAuthor

@bparrishMines Can you check this PR? Thanks

bparrishMines
bparrishMines approved these changes Dec 19, 2023
View reviewed changes

@bparrishMinesbparrishMines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMinesbparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 19, 2023
@auto-submit
auto-submitBot merged commit 65e0a81 into flutter:mainDec 19, 2023
@jsharp83jsharp83 mentioned this pull request Dec 20, 2023
Merged
11 tasks
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Dec 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2023
@engine-flutter-autoroll
65e0a81[webview_flutter] Implement platform interface for JavaScript…
e9a9427
… dialog (flutter/packages#5670)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Dec 20, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2023
@engine-flutter-autoroll
65e0a81[webview_flutter] Implement platform interface for JavaScript…
8144dfe
… dialog (flutter/packages#5670)
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Dec 20, 2023
@engine-flutter-autoroll
Roll Packages frombe52ac8todc5b267(5 revisions) (#140450)
0dc3b07
flutter/packages@be52ac8...dc5b267
2023-12-20 engine-flutter-autoroll@skia.org Roll Flutter from 0eb7881 to da0cd69 (15 revisions) (flutter/packages#5729)
2023-12-20 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#5702)
2023-12-19 jsharp83@gmail.com [webview_flutter] Implement platform interface for JavaScript dialog (flutter/packages#5670)
2023-12-19 JeroenWeener@users.noreply.github.com [webview_flutter] Support for handling basic authentication requests (iOS) (flutter/packages#5455)
2023-12-19 engine-flutter-autoroll@skia.org Roll Flutter from cdc83e5 to 0eb7881 (17 revisions) (flutter/packages#5722)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CoderDake pushed a commit to CoderDake/flutter that referenced this pull request Dec 28, 2023
@engine-flutter-autoroll@CoderDake
Roll Packages frombe52ac8todc5b267(5 revisions) (flutter#140450)
95ee6d3
flutter/packages@be52ac8...dc5b267
2023-12-20 engine-flutter-autoroll@skia.org Roll Flutter from 0eb7881 to da0cd69 (15 revisions) (flutter/packages#5729)
2023-12-20 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#5702)
2023-12-19 jsharp83@gmail.com [webview_flutter] Implement platform interface for JavaScript dialog (flutter/packages#5670)
2023-12-19 JeroenWeener@users.noreply.github.com [webview_flutter] Support for handling basic authentication requests (iOS) (flutter/packages#5455)
2023-12-19 engine-flutter-autoroll@skia.org Roll Flutter from cdc83e5 to 0eb7881 (17 revisions) (flutter/packages#5722)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jan 4, 2024
Merged
Merged
Closed
@reidbakerreidbaker mentioned this pull request Jan 12, 2024
Closed
auto-submitBot pushed a commit that referenced this pull request Jan 18, 2024
@jsharp83
[webview_flutter_wkwebview] Add javascript panel interface for wkwebv…
2762c54
…iew (#5795)
* There are cases where Web calls System Popup with javascript on webview_flutter
* At this time, the message comes in the WKUIDelegate part in iOS.
* https://developer.apple.com/documentation/webkit/wkuidelegate/1537406-webview
* https://developer.apple.com/documentation/webkit/wkuidelegate/1536489-webview
* Related issue: flutter/flutter#30358 (comment)
* Related Interface PR: #5670
* The PR that contains all changes can be found at #4704
@reidbakerreidbaker mentioned this pull request Jan 19, 2024
Merged
12 tasks
auto-submitBot pushed a commit that referenced this pull request Jan 24, 2024
@jsharp83
[webview_flutter_android] Add javascript panel interface for android (#…
5aa3d35
…5796)
* There are cases where Web calls System Popup with javascript on webview_flutter
* Android has a interface on WebChromeClient
* https://developer.android.com/reference/android/webkit/WebChromeClient#onJsAlert(android.webkit.WebView,%20java.lang.String,%20java.lang.String,%20android.webkit.JsResult)
* Related issue: flutter/flutter#30358 (comment)
* Related Interface PR: #5670
* The PR that contains all changes can be found at #4704
auto-submitBot pushed a commit that referenced this pull request Feb 9, 2024
@jsharp83
[webview_flutter] Add interface for showing javascript dialog message (…
11152d2
…#4704)
* there are cases where Web calls System Popup with javascript on webview_flutter
* At this time, the message comes in the WKUIDelegate part in iOS.
* https://developer.apple.com/documentation/webkit/wkuidelegate/1537406-webview
* https://developer.apple.com/documentation/webkit/wkuidelegate/1536489-webview
* Android also has a interface on WebChromeClient
* https://developer.android.com/reference/android/webkit/WebChromeClient#onJsAlert(android.webkit.WebView,%20java.lang.String,%20java.lang.String,%20android.webkit.JsResult)
* It was implemented according to the requirements of the code review of the #4555
* Related issue: flutter/flutter#30358 (comment)
* Related Interface PR: #5670
@reidbakerreidbaker mentioned this pull request Feb 19, 2024
Merged
16 tasks
@huycozyhuycozy mentioned this pull request Jul 15, 2024
Closed
Jyndigo pushed a commit to uesp/webview_flutter_x that referenced this pull request Jun 24, 2025
@jsharp83
[webview_flutter_wkwebview] Add javascript panel interface for wkwebv…
93b6354
…iew (#5795)
* There are cases where Web calls System Popup with javascript on webview_flutter
* At this time, the message comes in the WKUIDelegate part in iOS.
* https://developer.apple.com/documentation/webkit/wkuidelegate/1537406-webview
* https://developer.apple.com/documentation/webkit/wkuidelegate/1536489-webview
* Related issue: flutter/flutter#30358 (comment)
* Related Interface PR: flutter/packages#5670
* The PR that contains all changes can be found at flutter/packages#4704
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@jsharp83
[webview_flutter] Implement platform interface for JavaScript dialog (f…
adba185
…lutter#5670)
Adds the platform interface implementation for JavaScript dailog.
This PR is part of a series of PRs that aim to closeflutter/flutter#30358 (comment)
The PR that contains all changes can be found at flutter#4704
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@jsharp83
[webview_flutter_wkwebview] Add javascript panel interface for wkwebv…
2fd7c25
…iew (flutter#5795)
* There are cases where Web calls System Popup with javascript on webview_flutter
* At this time, the message comes in the WKUIDelegate part in iOS.
* https://developer.apple.com/documentation/webkit/wkuidelegate/1537406-webview
* https://developer.apple.com/documentation/webkit/wkuidelegate/1536489-webview
* Related issue: flutter/flutter#30358 (comment)
* Related Interface PR: flutter#5670
* The PR that contains all changes can be found at flutter#4704
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@jsharp83
[webview_flutter_android] Add javascript panel interface for android (f…
e20e6e5
…lutter#5796)
* There are cases where Web calls System Popup with javascript on webview_flutter
* Android has a interface on WebChromeClient
* https://developer.android.com/reference/android/webkit/WebChromeClient#onJsAlert(android.webkit.WebView,%20java.lang.String,%20java.lang.String,%20android.webkit.JsResult)
* Related issue: flutter/flutter#30358 (comment)
* Related Interface PR: flutter#5670
* The PR that contains all changes can be found at flutter#4704
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@jsharp83
[webview_flutter] Add interface for showing javascript dialog message (…
dbbc7fc
…flutter#4704)
* there are cases where Web calls System Popup with javascript on webview_flutter
* At this time, the message comes in the WKUIDelegate part in iOS.
* https://developer.apple.com/documentation/webkit/wkuidelegate/1537406-webview
* https://developer.apple.com/documentation/webkit/wkuidelegate/1536489-webview
* Android also has a interface on WebChromeClient
* https://developer.android.com/reference/android/webkit/WebChromeClient#onJsAlert(android.webkit.WebView,%20java.lang.String,%20java.lang.String,%20android.webkit.JsResult)
* It was implemented according to the requirements of the code review of the flutter#4555
* Related issue: flutter/flutter#30358 (comment)
* Related Interface PR: flutter#5670
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@jsharp83
[webview_flutter] Implement platform interface for JavaScript dialog (f…
995d3d4
…lutter#5670)
Adds the platform interface implementation for JavaScript dailog.
This PR is part of a series of PRs that aim to closeflutter/flutter#30358 (comment)
The PR that contains all changes can be found at flutter#4704
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@jsharp83
[webview_flutter_wkwebview] Add javascript panel interface for wkwebv…
2cbbdb3
…iew (flutter#5795)
* There are cases where Web calls System Popup with javascript on webview_flutter
* At this time, the message comes in the WKUIDelegate part in iOS.
* https://developer.apple.com/documentation/webkit/wkuidelegate/1537406-webview
* https://developer.apple.com/documentation/webkit/wkuidelegate/1536489-webview
* Related issue: flutter/flutter#30358 (comment)
* Related Interface PR: flutter#5670
* The PR that contains all changes can be found at flutter#4704
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@jsharp83
[webview_flutter_android] Add javascript panel interface for android (f…
600043d
…lutter#5796)
* There are cases where Web calls System Popup with javascript on webview_flutter
* Android has a interface on WebChromeClient
* https://developer.android.com/reference/android/webkit/WebChromeClient#onJsAlert(android.webkit.WebView,%20java.lang.String,%20java.lang.String,%20android.webkit.JsResult)
* Related issue: flutter/flutter#30358 (comment)
* Related Interface PR: flutter#5670
* The PR that contains all changes can be found at flutter#4704
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@jsharp83
[webview_flutter] Add interface for showing javascript dialog message (…
1eaa70c
…flutter#4704)
* there are cases where Web calls System Popup with javascript on webview_flutter
* At this time, the message comes in the WKUIDelegate part in iOS.
* https://developer.apple.com/documentation/webkit/wkuidelegate/1537406-webview
* https://developer.apple.com/documentation/webkit/wkuidelegate/1536489-webview
* Android also has a interface on WebChromeClient
* https://developer.android.com/reference/android/webkit/WebChromeClient#onJsAlert(android.webkit.WebView,%20java.lang.String,%20java.lang.String,%20android.webkit.JsResult)
* It was implemented according to the requirements of the code review of the flutter#4555
* Related issue: flutter/flutter#30358 (comment)
* Related Interface PR: flutter#5670
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes
@bparrishMinesbparrishMinesbparrishMines approved these changes

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: webview_flutter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

alert() method doesn't work in WebView

3 participants

@jsharp83@stuartmorgan-g@bparrishMines