Skip to content

[rfw] Add OverflowBar widget and Update ButtonBar widget implementation - #5807

Merged
auto-submit[bot] merged 2 commits into
flutter:mainfrom
TahaTesser:replace_button_bar
Jan 30, 2024
Merged

[rfw] Add OverflowBar widget and Update ButtonBar widget implementation#5807
auto-submit[bot] merged 2 commits into
flutter:mainfrom
TahaTesser:replace_button_bar

Conversation

@TahaTesser

@TahaTesserTahaTesser commented Jan 5, 2024

Copy link
Copy Markdown
Contributor

fixes[RFW] Replace ButtonBar with a backwards compatible implementation using OverflowBar

Description

This adds OverflowBar widget to material widgets and updates ButtonBar (to be deprecated widget) to use OverflowBar underneath for backwards compatibility.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actionsgithub-actionsBot added the p: rfw Remote Flutter Widgets label Jan 5, 2024
@TahaTesserTahaTesser changed the title [rfw] Introduce OverflowBar and Replace ButtonBar with a backwards compatible implementation[rfw] Add OverflowBar widget and Update ButtonBar widget implementationJan 5, 2024
@TahaTesser
TahaTesser marked this pull request as ready for review January 9, 2024 14:34
@TahaTesser
TahaTesser requested a review from Hixie as a code ownerJanuary 9, 2024 14:34
@TahaTesser

This comment was marked as resolved.

Sign in to view
Hixie
Hixie reviewed Jan 9, 2024
View reviewed changes
Comment threadpackages/rfw/lib/src/flutter/material_widgets.dart Outdated
Hixie
Hixie reviewed Jan 9, 2024
View reviewed changes
Comment threadpackages/rfw/lib/src/flutter/material_widgets.dart Outdated
@Hixie

Hixie commented Jan 9, 2024

Copy link
Copy Markdown
Contributor

I don't understand the diff, can you explain it in more detail? Why is the new rendering different?

@TahaTesser

TahaTesser commented Jan 11, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I don't understand the diff, can you explain it in more detail? Why is the new rendering different?

There is no more diff now (there was one before because I ran run_tests.sh --update-goldens on my M1 MacBook)

@TahaTesser
TahaTesser requested a review from HixieJanuary 11, 2024 14:26
Hixie
Hixie reviewed Jan 11, 2024
View reviewed changes
Comment threadpackages/rfw/test/material_widgets_test.dart Outdated
@TahaTesser
TahaTesser requested a review from HixieJanuary 16, 2024 11:48
Hixie
Hixie reviewed Jan 16, 2024
View reviewed changes
Comment threadpackages/rfw/lib/src/flutter/material_widgets.dart Outdated
Hixie
Hixie reviewed Jan 16, 2024
View reviewed changes
Comment threadpackages/rfw/lib/src/flutter/material_widgets.dart Outdated
@TahaTesser
TahaTesser requested a review from HixieJanuary 18, 2024 08:20
Hixie
Hixie reviewed Jan 18, 2024
View reviewed changes
Comment threadpackages/rfw/lib/src/flutter/material_widgets.dart Outdated
@TahaTesser
TahaTesser requested a review from HixieJanuary 19, 2024 11:49
@TahaTesser

TahaTesser commented Jan 23, 2024

Copy link
Copy Markdown
ContributorAuthor

@Hixie Resolved version conflicts.

@TahaTesser

TahaTesser commented Jan 29, 2024

Copy link
Copy Markdown
ContributorAuthor

Resolved new conflicts

Hixie
Hixie reviewed Jan 29, 2024
View reviewed changes
Comment threadpackages/rfw/lib/src/flutter/material_widgets.dart Outdated

@HixieHixieJan 29, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all needs to be markdown with hyperlinks and so on (sorry if i wasn't clear in the earlier comment).

What I mean is e.g. ButtonBar needs to be [ButtonBar], package:flutter/material.dart needs to be whatever the magic incantation is to reference the material library (maybe just [material]?), rfw needs to either be in backticks or uppercase, the parameters in the list should be in backticks, etc.

@TahaTesserTahaTesserJan 30, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh my bad. Thanks for the suggestion!

package:flutter/material.dart can be simply referenced as "Flutter's material library". We reference like this in the framework too in various classes

Hixie
Hixie approved these changes Jan 29, 2024
View reviewed changes

@HixieHixie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the documentation fixes requested above

@TahaTesserTahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2024
@auto-submit
auto-submitBot merged commit 25abb5d into flutter:mainJan 30, 2024
@TahaTesser
TahaTesser deleted the replace_button_bar branch January 30, 2024 10:30
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jan 30, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 30, 2024
@engine-flutter-autoroll
25abb5d[rfw] AddOverflowBarwidget and UpdateButtonBarwidget …
3787800
…implementation (flutter/packages#5807)
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Jan 30, 2024
@engine-flutter-autoroll
Roll Packages from516648ato25abb5d(6 revisions) (#142527)
461f0bf
flutter/packages@516648a...25abb5d
2024-01-30 tessertaha@gmail.com [rfw] Add `OverflowBar` widget and Update `ButtonBar` widget implementation (flutter/packages#5807)
2024-01-30 stuartmorgan@google.com [ci] Reduce tasks slightly (flutter/packages#6011)
2024-01-29 stuartmorgan@google.com Clarify issue requirement (flutter/packages#6010)
2024-01-29 stuartmorgan@google.com [various] Disambiguate TestDefaultBinaryMessengerBinding (flutter/packages#6009)
2024-01-29 engine-flutter-autoroll@skia.org Manual roll Flutter from a8efa77 to 2f6fdf2 (23 revisions) (flutter/packages#6008)
2024-01-29 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.23.1 to 3.23.2 (flutter/packages#5987)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@Hixie

Hixie commented Jan 30, 2024

Copy link
Copy Markdown
Contributor

Looks like the test coverage is no longer at 100% since this PR.

@TahaTesserTahaTesser mentioned this pull request Jan 31, 2024
Closed
@TahaTesser

TahaTesser commented Jan 31, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Looks like the test coverage is no longer at 100% since this PR.

Filed a fix #6020

@reidbakerreidbaker mentioned this pull request Feb 19, 2024
Merged
16 tasks
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@TahaTesser
[rfw] Add OverflowBar widget and Update ButtonBar widget implemen…
b1aa9de
…tation (flutter#5807)
fixes [[`RFW`] Replace `ButtonBar` with a backwards compatible implementation using `OverflowBar`](flutter/flutter#140381)
--- ### Description
This adds `OverflowBar` widget to material widgets and updates `ButtonBar` (to be deprecated widget) to use `OverflowBar` underneath for backwards compatibility.
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@TahaTesser
[rfw] Add OverflowBar widget and Update ButtonBar widget implemen…
b37621c
…tation (flutter#5807)
fixes [[`RFW`] Replace `ButtonBar` with a backwards compatible implementation using `OverflowBar`](flutter/flutter#140381)
--- ### Description
This adds `OverflowBar` widget to material widgets and updates `ButtonBar` (to be deprecated widget) to use `OverflowBar` underneath for backwards compatibility.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HixieHixieHixie approved these changes

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: rfwRemote Flutter Widgets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFW] Replace ButtonBar with a backwards compatible implementation using OverflowBar

2 participants

@TahaTesser@Hixie