Skip to content

[two_dimensional_scrollables] Fix TableSpanDecoration rects when axes are reversed - #5916

Merged
auto-submit[bot] merged 3 commits into
flutter:mainfrom
Piinks:fixReverseDeco
Jan 22, 2024
Merged

[two_dimensional_scrollables] Fix TableSpanDecoration rects when axes are reversed#5916
auto-submit[bot] merged 3 commits into
flutter:mainfrom
Piinks:fixReverseDeco

Conversation

@Piinks

@PiinksPiinks commented Jan 17, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixesflutter/flutter#141704

This fixes the rect computation for TableSpanDecorations when one or both axes are reversed.
We previously fixed similar issues when the clipRects applied to areas of the table did not account for reversed. This is another similar case.

image

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks

This comment was marked as outdated.

Sign in to view
Piinks
Piinks commented Jan 18, 2024
View reviewed changes
Comment threadpackages/two_dimensional_scrollables/lib/src/table_view/table.dart Outdated
@Piinks

Piinks commented Jan 18, 2024

Copy link
Copy Markdown
ContributorAuthor

Ok, ready for real now. 😜

@PiinksPiinks mentioned this pull request Jan 18, 2024
Merged
11 tasks
goderbauer
goderbauer approved these changes Jan 18, 2024
View reviewed changes

@goderbauergoderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadpackages/two_dimensional_scrollables/lib/src/table_view/table.dart Outdated
Comment threadpackages/two_dimensional_scrollables/lib/src/table_view/table.dart Outdated
Comment threadpackages/two_dimensional_scrollables/test/table_view/table_span_test.dart Outdated
@PiinksPiinks added the p: two_dimensional_scrollables Issues pertaining to the two_dimensional_scrollables package label Jan 22, 2024
@PiinksPiinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 22, 2024
@auto-submit
auto-submitBot merged commit 841fe90 into flutter:mainJan 22, 2024
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jan 23, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 23, 2024
@engine-flutter-autoroll
841fe90[two_dimensional_scrollables] Fix TableSpanDecoration rects w…
ef8ae6e
…hen axes are reversed (flutter/packages#5916)
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Jan 23, 2024
@engine-flutter-autoroll
Roll Packages frome4cbf23to841fe90(7 revisions) (#142047)
2b6c2ee
flutter/packages@e4cbf23...841fe90
2024-01-22 katelovett@google.com [two_dimensional_scrollables] Fix TableSpanDecoration rects when axes are reversed (flutter/packages#5916)
2024-01-22 43054281+camsim99@users.noreply.github.com [most on Android] Bump compile SDK version to 34 (flutter/packages#5783)
2024-01-22 dshukertjr@gmail.com [url_launcher]: Fix a grammar error in the comments of launchUrl method (flutter/packages#5919)
2024-01-22 10687576+bparrishMines@users.noreply.github.com [webview_platform_interface] Adds WebResourceRequest to HttpResponseError (flutter/packages#5790)
2024-01-22 43054281+camsim99@users.noreply.github.com [camerax] Update `Activity` references when `ActivityAware` lifecycle methods called (flutter/packages#5784)
2024-01-22 engine-flutter-autoroll@skia.org Roll Flutter from 5dea6b9 to 3ee8ff2 (9 revisions) (flutter/packages#5955)
2024-01-22 stuartmorgan@google.com [espresso] Replace deprecated `getObservatoryUri` (flutter/packages#5788)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbakerreidbaker mentioned this pull request Feb 19, 2024
Merged
16 tasks
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@Piinks
[two_dimensional_scrollables] Fix TableSpanDecoration rects when axes…
02c1da6
… are reversed (flutter#5916)
Fixesflutter/flutter#141704
This fixes the rect computation for TableSpanDecorations when one or both axes are reversed.
We previously fixed similar issues when the clipRects applied to areas of the table did not account for reversed. This is another similar case.
- flutter#5187
- flutter#5038
![image](https://github.com/flutter/packages/assets/16964204/ae7c6872-c740-4617-95a4-8302a3085d59)
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@Piinks
[two_dimensional_scrollables] Fix TableSpanDecoration rects when axes…
6788e47
… are reversed (flutter#5916)
Fixesflutter/flutter#141704
This fixes the rect computation for TableSpanDecorations when one or both axes are reversed.
We previously fixed similar issues when the clipRects applied to areas of the table did not account for reversed. This is another similar case.
- flutter#5187
- flutter#5038
![image](https://github.com/flutter/packages/assets/16964204/ae7c6872-c740-4617-95a4-8302a3085d59)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauergoderbauergoderbauer approved these changes

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: two_dimensional_scrollablesIssues pertaining to the two_dimensional_scrollables package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[two_dimensional_scrollables] TableSpanDecoration error in reverse

2 participants

@Piinks@goderbauer