Skip to content

Expose registered widget libraries and local widget library widgets. - #5936

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
johnmccutchan:rfw_access_
Jan 19, 2024
Merged

Expose registered widget libraries and local widget library widgets.#5936
auto-submit[bot] merged 1 commit into
flutter:mainfrom
johnmccutchan:rfw_access_

Conversation

@johnmccutchan

@johnmccutchanjohnmccutchan commented Jan 19, 2024

Copy link
Copy Markdown
Contributor

This exposes the necessary information to allow rfwpg to display registered libraries and widgets in a list or tree.

@github-actionsgithub-actionsBot added the p: rfw Remote Flutter Widgets label Jan 19, 2024
Hixie
Hixie requested changes Jan 19, 2024
View reviewed changes
Comment threadpackages/rfw/test/runtime_test.dart Outdated
Comment threadpackages/rfw/lib/src/flutter/runtime.dart Outdated
Comment threadpackages/rfw/lib/src/flutter/runtime.dart Outdated
Comment threadpackages/rfw/test/runtime_test.dart Outdated
Comment threadpackages/rfw/test/runtime_test.dart Outdated
Comment threadpackages/rfw/test/runtime_test.dart Outdated
@johnmccutchanjohnmccutchan mentioned this pull request Jan 19, 2024
Closed
@johnmccutchanjohnmccutchan added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 19, 2024
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 19, 2024
@auto-submit

auto-submitBot commented Jan 19, 2024

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/packages/5936, due to This PR has not met approval requirements for merging. Changes were requested by {Hixie}, please make the needed changes and resubmit this PR.
The PR author is a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit

auto-submitBot commented Jan 19, 2024

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/packages/5936, due to - The status or check suite Linux repo_tools_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

tugorez
tugorez reviewed Jan 19, 2024
View reviewed changes
Comment threadpackages/rfw/test/runtime_test.dart Outdated
Hixie
Hixie reviewed Jan 19, 2024
View reviewed changes
Comment threadpackages/rfw/CHANGELOG.md Outdated
Hixie
Hixie reviewed Jan 19, 2024
View reviewed changes
Comment threadpackages/rfw/lib/src/flutter/runtime.dart Outdated
Hixie
Hixie reviewed Jan 19, 2024
View reviewed changes
Comment threadpackages/rfw/test/runtime_test.dart Outdated
Hixie
Hixie approved these changes Jan 19, 2024
View reviewed changes

@HixieHixie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo minor comments

@johnmccutchan

johnmccutchan commented Jan 19, 2024

Copy link
Copy Markdown
ContributorAuthor

Thanks all for the reviews!

@johnmccutchan
Expose registered widget libraries and local widget library widgets.
3c21be1
This exposes the necessary information to allow rfwpg to display registered
libraries and widgets in a list or tree.
Include tests.
@johnmccutchanjohnmccutchan added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 19, 2024
@auto-submit
auto-submitBot merged commit 7901015 into flutter:mainJan 19, 2024
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jan 22, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2024
@engine-flutter-autoroll
7901015Expose registered widget libraries and local widget library w…
58ec65c
…idgets. (flutter/packages#5936)
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Jan 22, 2024
@engine-flutter-autoroll
Roll Packages from129e08ctoe4cbf23(11 revisions) (#141962)
bfa245f
flutter/packages@129e08c...e4cbf23
2024-01-21 engine-flutter-autoroll@skia.org Roll Flutter from ddf60fb to 5dea6b9 (5 revisions) (flutter/packages#5951)
2024-01-21 stuartmorgan@google.com Update platform label rules for shared iOS/macOS (flutter/packages#5801)
2024-01-20 stuartmorgan@google.com [pigeon] Support other hosts in generated file CI checks (flutter/packages#5944)
2024-01-20 stuartmorgan@google.com [pigeon] Improve style of generated Swift code (flutter/packages#5938)
2024-01-20 engine-flutter-autoroll@skia.org Roll Flutter from 684247a to ddf60fb (12 revisions) (flutter/packages#5949)
2024-01-20 41930132+hellohuanlin@users.noreply.github.com [camera]fix a sample buffer memory leak on pause resume recording (flutter/packages#5927)
2024-01-19 magder@google.com [ci] Run Swift formatter and linter during CI formatting (flutter/packages#5928)
2024-01-19 engine-flutter-autoroll@skia.org Manual roll Flutter from f77f824 to 684247a (39 revisions) (flutter/packages#5948)
2024-01-19 john@johnmccutchan.com Expose registered widget libraries and local widget library widgets. (flutter/packages#5936)
2024-01-19 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.1.0 to 4.2.0 (flutter/packages#5937)
2024-01-19 engine-flutter-autoroll@skia.org Manual roll Flutter (stable) from ef1af02 to 67457e6 (1 revision) (flutter/packages#5932)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbakerreidbaker mentioned this pull request Feb 19, 2024
Merged
16 tasks
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@johnmccutchan
Expose registered widget libraries and local widget library widgets. (f…
caac9a6
…lutter#5936)
This exposes the necessary information to allow rfwpg to display registered libraries and widgets in a list or tree.
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@johnmccutchan
Expose registered widget libraries and local widget library widgets. (f…
c77c540
…lutter#5936)
This exposes the necessary information to allow rfwpg to display registered libraries and widgets in a list or tree.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HixieHixieHixie approved these changes
+1 more reviewer
@tugoreztugoreztugorez left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: rfwRemote Flutter Widgets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@johnmccutchan@Hixie@tugorez