Skip to content

[tools] Ignore analysis options files in .symlinks - #6119

Merged
auto-submit[bot] merged 2 commits into
flutter:mainfrom
stuartmorgan-g:local-analysis-improvement
Feb 14, 2024
Merged

[tools] Ignore analysis options files in .symlinks#6119
auto-submit[bot] merged 2 commits into
flutter:mainfrom
stuartmorgan-g:local-analysis-improvement

Conversation

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

When running analyze in a local tree that has done builds, there can be false positives of the "unexpected analysis options" check due to the .symlinks directory making other packages' analysis options show up in the check. This avoids following links to prevent those false positives.

When running `analyze` in a local tree that has done builds, there can
be false positives of the "unexpected analysis options" check due to the
.symlinks directory making other packages' analysis options show up in
the check. This avoids following links to prevent those false positives.

@tarrinnealtarrinneal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this! Can all tooling ignore sylink files?

@stuartmorgan-g

Copy link
Copy Markdown
CollaboratorAuthor

Probably most of it? I should audit all the calls.

@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 14, 2024
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 14, 2024
@auto-submit

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/packages/6119, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_3 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 14, 2024
@auto-submit
auto-submitBot merged commit cbb676a into flutter:mainFeb 14, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 15, 2024
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Feb 15, 2024
flutter/packages@a864254...ef349be
2024-02-15 stuartmorgan@google.com [url_launcher] Replace deprecated RouteInformation APIs (flutter/packages#6127)
2024-02-15 stuartmorgan@google.com [rfw] Replace deprecated `textScaleFactor` (flutter/packages#6130)
2024-02-15 stuartmorgan@google.com [flutter_adaptive_scaffold] Replace deprecated APIs (flutter/packages#6129)
2024-02-14 engine-flutter-autoroll@skia.org Roll Flutter from eb5d0a4 to a628814 (72 revisions) (flutter/packages#6118)
2024-02-14 stuartmorgan@google.com [flutter_migrate] Replace deprecated APIs (flutter/packages#6128)
2024-02-14 stuartmorgan@google.com [flutter_image] Replace deprecated APIs (flutter/packages#6126)
2024-02-14 stuartmorgan@google.com [tools] Ignore analysis options files in .symlinks (flutter/packages#6119)
2024-02-14 stuartmorgan@google.com [various] Clean up `deprecated_member_use` ignores (flutter/packages#6123)
2024-02-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.0 to 3.24.1 (flutter/packages#6121)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
When running `analyze` in a local tree that has done builds, there can be false positives of the "unexpected analysis options" check due to the .symlinks directory making other packages' analysis options show up in the check. This avoids following links to prevent those false positives.
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
When running `analyze` in a local tree that has done builds, there can be false positives of the "unexpected analysis options" check due to the .symlinks directory making other packages' analysis options show up in the check. This avoids following links to prevent those false positives.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@stuartmorgan-g@tarrinneal