Skip to content

[webview_flutter_android][webview_flutter_wkwebview] Adds platform implementations for onHttpError - #6149

Merged
auto-submit[bot] merged 18 commits into
flutter:mainfrom
bparrishMines:on_http_errors
Mar 14, 2024
Merged

[webview_flutter_android][webview_flutter_wkwebview] Adds platform implementations for onHttpError#6149
auto-submit[bot] merged 18 commits into
flutter:mainfrom
bparrishMines:on_http_errors

Conversation

@bparrishMines

@bparrishMinesbparrishMines commented Feb 16, 2024

Copy link
Copy Markdown
Contributor

Copy of #3695 since it doesn't contain permission to edit from contributors.

Part of flutter/flutter#39502

Full PR #3278

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@bparrishMinesbparrishMines changed the title On http errors[webview_flutter] Adds platform implementations for onHttpErrorFeb 21, 2024
@bparrishMinesbparrishMines added the federated: partial_changes PR that contains changes for only a single package of a federated plugin change label Feb 21, 2024
@bparrishMinesbparrishMines changed the title [webview_flutter] Adds platform implementations for onHttpError[webview_flutter_android][webview_flutter_wkwebview] Adds platform implementations for onHttpErrorFeb 21, 2024
@bparrishMines
bparrishMines marked this pull request as ready for review February 21, 2024 03:19

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor feedback.

I do worry that doing the on-response-to-on-error mapping on the Dart side on iOS is going to make every load operation slower, but it's likely that the native->Dart->native round trip will be negligible compared to web load times. If it becomes a problem in practice, we'll need to revisit this and flex the API surface to do the response code checks on the native side and make it an on-error callback at the Pigeon protocol level.

Comment threadpackages/webview_flutter/webview_flutter_wkwebview/pigeons/web_kit.dart Outdated
Comment threadpackages/webview_flutter/webview_flutter_android/example/lib/main.dart Outdated
@jmagman

Copy link
Copy Markdown
Member

@bparrishMines is this ready to merge, or are you waiting for more reviewer feedback?

@bparrishMinesbparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 14, 2024
@auto-submit
auto-submitBot merged commit 92a8b7a into flutter:mainMar 14, 2024
@bparrishMines
bparrishMines deleted the on_http_errors branch March 14, 2024 19:03
@bparrishMines

Copy link
Copy Markdown
ContributorAuthor

It's ready, I just forgot about adding the label. I also wanted to respond to @stuartmorgan about including a is<FunctionName>Overriden feature in the pigeon wrapper once the initial implementation is done.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2024
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Mar 15, 2024
flutter/packages@b21c542...756dcc1
2024-03-15 32538273+ValentinVignal@users.noreply.github.com [go_router] Use `leak_tracker_flutter_testing` (flutter/packages#6210)
2024-03-15 10687576+bparrishMines@users.noreply.github.com [camera_web][google_maps_flutter] Fix tests throwing errors after test completion with manual roll (flutter/packages#6318)
2024-03-14 10687576+bparrishMines@users.noreply.github.com [pigeon] Fixes double prefixes added to enum names for Objc HostApis and FlutterApis (flutter/packages#6263)
2024-03-14 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android][webview_flutter_wkwebview] Adds platform implementations for onHttpError (flutter/packages#6149)
2024-03-14 34871572+gmackall@users.noreply.github.com [image_picker_android] Fix deprecation warnings by branching based on build version, and suppressing only when needed (flutter/packages#6233)
2024-03-14 30870216+gaaclarke@users.noreply.github.com [google_maps_flutter] Started dispatching platform messages from platform thread (flutter/packages#6069)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…plementations for onHttpError (flutter#6149)
Copy of flutter#3695 since it doesn't contain permission to edit from contributors.
Part of flutter/flutter#39502
Full PR flutter#3278
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
…plementations for onHttpError (flutter#6149)
Copy of flutter#3695 since it doesn't contain permission to edit from contributors.
Part of flutter/flutter#39502
Full PR flutter#3278
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appfederated: partial_changesPR that contains changes for only a single package of a federated plugin changep: webview_flutterplatform-androidplatform-ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@bparrishMines@jmagman@stuartmorgan-g@HugoOlthof