Uh oh!
There was an error while loading. Please reload this page.
[webview_flutter_android][webview_flutter_wkwebview] Adds platform implementations for onHttpError - #6149
Conversation
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM with minor feedback.
I do worry that doing the on-response-to-on-error mapping on the Dart side on iOS is going to make every load operation slower, but it's likely that the native->Dart->native round trip will be negligible compared to web load times. If it becomes a problem in practice, we'll need to revisit this and flex the API surface to do the response code checks on the native side and make it an on-error callback at the Pigeon protocol level.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jmagman
commented
Mar 13, 2024
@bparrishMines is this ready to merge, or are you waiting for more reviewer feedback? |
bparrishMines
commented
Mar 14, 2024
It's ready, I just forgot about adding the label. I also wanted to respond to @stuartmorgan about including a |
…tform implementations for onHttpError (flutter/packages#6149)
flutter/packages@b21c542...756dcc1 2024-03-15 32538273+ValentinVignal@users.noreply.github.com [go_router] Use `leak_tracker_flutter_testing` (flutter/packages#6210) 2024-03-15 10687576+bparrishMines@users.noreply.github.com [camera_web][google_maps_flutter] Fix tests throwing errors after test completion with manual roll (flutter/packages#6318) 2024-03-14 10687576+bparrishMines@users.noreply.github.com [pigeon] Fixes double prefixes added to enum names for Objc HostApis and FlutterApis (flutter/packages#6263) 2024-03-14 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android][webview_flutter_wkwebview] Adds platform implementations for onHttpError (flutter/packages#6149) 2024-03-14 34871572+gmackall@users.noreply.github.com [image_picker_android] Fix deprecation warnings by branching based on build version, and suppressing only when needed (flutter/packages#6233) 2024-03-14 30870216+gaaclarke@users.noreply.github.com [google_maps_flutter] Started dispatching platform messages from platform thread (flutter/packages#6069) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…plementations for onHttpError (flutter#6149) Copy of flutter#3695 since it doesn't contain permission to edit from contributors. Part of flutter/flutter#39502 Full PR flutter#3278
…plementations for onHttpError (flutter#6149) Copy of flutter#3695 since it doesn't contain permission to edit from contributors. Part of flutter/flutter#39502 Full PR flutter#3278
Copy of #3695 since it doesn't contain permission to edit from contributors.
Part of flutter/flutter#39502
Full PR #3278
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.