[google_maps_flutter] Add support for marker clustering - platform interface by jokerttu · Pull Request #6158 · flutter/packages

jokerttu · 2024-02-19T08:40:40Z

This PR introduces support for marker clustering

This is prequel PR for: #4319
Containing only changes to google_maps_flutter_platform_interface package.

Follow up PR:s will hold the platform and app-facing plugin implementations.

Linked issue: flutter/flutter#26863

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

stuartmorgan-g

LGTM

jokerttu · 2024-02-29T08:16:29Z

Rebased and version number updated from 2.5.0 to 2.6.0

stuartmorgan-g · 2024-02-29T14:28:02Z

This has approval, so you can add the autosubmit label any time.

jokerttu · 2024-02-29T17:28:01Z

This has approval, so you can add the autosubmit label any time.

@stuartmorgan This need to be done by someone who has permissions to add labels.

stuartmorgan-g · 2024-02-29T17:36:46Z

I can add it, but you're showing as an org member so you should be able to add labels. If that's not working there's a configuration problem somewhere, so please follow up in #server-support on Discord.

auto-submit · 2024-02-29T17:38:39Z

auto label is removed for flutter/packages/6158, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

stuartmorgan-g · 2024-02-29T17:40:07Z

Well now I'm very confused.

stuartmorgan-g · 2024-02-29T17:42:03Z

Oh I see, you're a member of Flutter, but not flutter-hackers. I'm not sure how that happened.

stuartmorgan-g · 2024-02-29T18:04:15Z

I've nominated you for full access, so once you confirm in Discord we'll be able to land this with the one review :)

…tform interface (flutter/packages#6158)

flutter/packages@6d02f03...a9c68b8 2024-03-01 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.5 to 3.24.6 (flutter/packages#6234) 2024-02-29 stuartmorgan@google.com [various] Standardize Obj-C doc comment style (flutter/packages#6232) 2024-02-29 joonas.kerttula@codemate.com [google_maps_flutter] Add support for marker clustering - platform interface (flutter/packages#6158) 2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter (stable) from abb292a to 7482962 (1 revision) (flutter/packages#6230) 2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter from d00bfe8 to e92bca3 (15 revisions) (flutter/packages#6227) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…terface (flutter#6158) This PR introduces support for marker clustering This is prequel PR for: flutter#4319 Containing only changes to `google_maps_flutter_platform_interface` package. Follow up PR:s will hold the platform and app-facing plugin implementations. Linked issue: flutter/flutter#26863

This PR introduces support for marker clustering for Android platform An example usage is available in the example application at `./packages/google_maps_flutter/google_maps_flutter_android/example` on the page `Manage clustering` This is prequel PR for: #4319 and sequel PR for: #6158 Containing only changes to `google_maps_flutter_android` package. Follow up PR will hold the app-facing plugin implementation. Linked issue: flutter/flutter#26863

This PR introduces support for marker clustering for Web platform This is prequel PR for: #4319 and sequel PR for: #6158 Containing only changes to `google_maps_flutter_web` package. Follow up PR will hold the app-facing plugin implementation. Linked issue: flutter/flutter#26863 --------- Co-authored-by: David Iglesias Teixeira <ditman@gmail.com>

…6185) This PR introduces support for marker clustering for Android platform An example usage is available in the example application at `./packages/google_maps_flutter/google_maps_flutter_android/example` on the page `Manage clustering` This is prequel PR for: flutter#4319 and sequel PR for: flutter#6158 Containing only changes to `google_maps_flutter_android` package. Follow up PR will hold the app-facing plugin implementation. Linked issue: flutter/flutter#26863

This PR introduces support for marker clustering for Web platform This is prequel PR for: flutter#4319 and sequel PR for: flutter#6158 Containing only changes to `google_maps_flutter_web` package. Follow up PR will hold the app-facing plugin implementation. Linked issue: flutter/flutter#26863 --------- Co-authored-by: David Iglesias Teixeira <ditman@gmail.com>

…ion (#6186) This PR introduces support for marker clustering for iOS platform An example usabe is available in the example application at ./packages/google_maps_flutter/google_maps_flutter_ios/example/ios12 on the page `Manage clustering` This is prequel PR for: #4319 and sequel PR for: #6158 Containing only changes to `google_maps_flutter_ios` package. Follow up PR will hold the app-facing plugin implementation. Linked issue: flutter/flutter#26863

…terface (flutter#6158) This PR introduces support for marker clustering This is prequel PR for: flutter#4319 Containing only changes to `google_maps_flutter_platform_interface` package. Follow up PR:s will hold the platform and app-facing plugin implementations. Linked issue: flutter/flutter#26863

This PR introduces support for marker clustering for Android platform An example usage is available in the example application at `./packages/google_maps_flutter/google_maps_flutter_android/example` on the page `Manage clustering` This is prequel PR for: flutter/packages#4319 and sequel PR for: flutter/packages#6158 Containing only changes to `google_maps_flutter_android` package. Follow up PR will hold the app-facing plugin implementation. Linked issue: flutter/flutter#26863

This PR introduces support for marker clustering for Web platform This is prequel PR for: flutter/packages#4319 and sequel PR for: flutter/packages#6158 Containing only changes to `google_maps_flutter_web` package. Follow up PR will hold the app-facing plugin implementation. Linked issue: flutter/flutter#26863 --------- Co-authored-by: David Iglesias Teixeira <ditman@gmail.com>

…ion (#6186) This PR introduces support for marker clustering for iOS platform An example usabe is available in the example application at ./packages/google_maps_flutter/google_maps_flutter_ios/example/ios12 on the page `Manage clustering` This is prequel PR for: flutter/packages#4319 and sequel PR for: flutter/packages#6158 Containing only changes to `google_maps_flutter_ios` package. Follow up PR will hold the app-facing plugin implementation. Linked issue: flutter/flutter#26863

…terface (flutter#6158) This PR introduces support for marker clustering This is prequel PR for: flutter#4319 Containing only changes to `google_maps_flutter_platform_interface` package. Follow up PR:s will hold the platform and app-facing plugin implementations. Linked issue: flutter/flutter#26863

…6185) This PR introduces support for marker clustering for Android platform An example usage is available in the example application at `./packages/google_maps_flutter/google_maps_flutter_android/example` on the page `Manage clustering` This is prequel PR for: flutter#4319 and sequel PR for: flutter#6158 Containing only changes to `google_maps_flutter_android` package. Follow up PR will hold the app-facing plugin implementation. Linked issue: flutter/flutter#26863

This PR introduces support for marker clustering for Web platform This is prequel PR for: flutter#4319 and sequel PR for: flutter#6158 Containing only changes to `google_maps_flutter_web` package. Follow up PR will hold the app-facing plugin implementation. Linked issue: flutter/flutter#26863 --------- Co-authored-by: David Iglesias Teixeira <ditman@gmail.com>

…ion (flutter#6186) This PR introduces support for marker clustering for iOS platform An example usabe is available in the example application at ./packages/google_maps_flutter/google_maps_flutter_ios/example/ios12 on the page `Manage clustering` This is prequel PR for: flutter#4319 and sequel PR for: flutter#6158 Containing only changes to `google_maps_flutter_ios` package. Follow up PR will hold the app-facing plugin implementation. Linked issue: flutter/flutter#26863

…terface (flutter#6158) This PR introduces support for marker clustering This is prequel PR for: flutter#4319 Containing only changes to `google_maps_flutter_platform_interface` package. Follow up PR:s will hold the platform and app-facing plugin implementations. Linked issue: flutter/flutter#26863

…6185) This PR introduces support for marker clustering for Android platform An example usage is available in the example application at `./packages/google_maps_flutter/google_maps_flutter_android/example` on the page `Manage clustering` This is prequel PR for: flutter#4319 and sequel PR for: flutter#6158 Containing only changes to `google_maps_flutter_android` package. Follow up PR will hold the app-facing plugin implementation. Linked issue: flutter/flutter#26863

This PR introduces support for marker clustering for Web platform This is prequel PR for: flutter#4319 and sequel PR for: flutter#6158 Containing only changes to `google_maps_flutter_web` package. Follow up PR will hold the app-facing plugin implementation. Linked issue: flutter/flutter#26863 --------- Co-authored-by: David Iglesias Teixeira <ditman@gmail.com>

…ion (flutter#6186) This PR introduces support for marker clustering for iOS platform An example usabe is available in the example application at ./packages/google_maps_flutter/google_maps_flutter_ios/example/ios12 on the page `Manage clustering` This is prequel PR for: flutter#4319 and sequel PR for: flutter#6158 Containing only changes to `google_maps_flutter_ios` package. Follow up PR will hold the app-facing plugin implementation. Linked issue: flutter/flutter#26863

jokerttu requested a review from stuartmorgan-g as a code owner February 19, 2024 08:40

github-actionsBot added the p: google_maps_flutter label Feb 19, 2024

jokerttu mentioned this pull request Feb 19, 2024
[google_maps_flutter] Marker clustering support #4319
Merged
11 tasks

stuartmorgan-g approved these changes Feb 20, 2024
View reviewed changes

This was referenced Feb 23, 2024
[google_maps_flutter] Add marker clustering support - android implementation #6185
Merged
[google_maps_flutter] Add marker clustering support - iOS implementation #6186
Merged
[google_maps_flutter] Add marker clustering support - web implementation #6187
Merged

[google_maps_flutter] Add clustering support - platform interface
4df8b06

jokerttu force-pushed the feature/google_maps_flutter_platform_interface_marker_clustering branch from 14096cb to 4df8b06Compare February 29, 2024 08:15

jokerttu changed the title ~~[google_maps_flutter_platform_interface] Add support for marker clustering~~[google_maps_flutter] Add support for marker clustering - platform interfaceFeb 29, 2024

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 29, 2024

auto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 29, 2024

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 29, 2024

auto-submitBot merged commit b3f10aa into flutter:mainFeb 29, 2024

engine-flutter-autoroll mentioned this pull request Mar 1, 2024
Roll Packages from 6d02f0359368 to a9c68b83356b (5 revisions) flutter/flutter#144477
Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 1, 2024
b3f10aa[google_maps_flutter] Add support for marker clustering - pla…
5b7c817
…tform interface (flutter/packages#6158)

RoarGronmo mentioned this pull request Mar 12, 2024
Newer version has some multiple import variable issue with latest version of flutter bpillon/google_maps_cluster_manager#58
Open

reidbaker mentioned this pull request Apr 1, 2024
[camera_android_camerax] Move integration_test dependency to tests reidbaker/packages#4
Closed
11 tasks

jokerttu deleted the feature/google_maps_flutter_platform_interface_marker_clustering branch September 9, 2024 10:44

Navigation Menu

Uh oh!

[google_maps_flutter] Add support for marker clustering - platform interface - #6158

[google_maps_flutter] Add support for marker clustering - platform interface#6158
auto-submit[bot] merged 1 commit into
flutter:mainfrom
CodemateLtd:feature/google_maps_flutter_platform_interface_marker_clustering

jokerttu commented Feb 19, 2024

Uh oh!

stuartmorgan-g left a comment

Uh oh!

jokerttu commented Feb 29, 2024

Uh oh!

stuartmorgan-g commented Feb 29, 2024

Uh oh!

jokerttu commented Feb 29, 2024

Uh oh!

stuartmorgan-g commented Feb 29, 2024

Uh oh!

auto-submitBot commented Feb 29, 2024

Uh oh!

stuartmorgan-g commented Feb 29, 2024

Uh oh!

stuartmorgan-g commented Feb 29, 2024

Uh oh!

stuartmorgan-g commented Feb 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jokerttu commented Feb 19, 2024

Pre-launch Checklist

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

jokerttu commented Feb 29, 2024

Uh oh!

stuartmorgan-g commented Feb 29, 2024

Uh oh!

jokerttu commented Feb 29, 2024

Uh oh!

stuartmorgan-g commented Feb 29, 2024

Uh oh!

auto-submitBot commented Feb 29, 2024

Uh oh!

stuartmorgan-g commented Feb 29, 2024

Uh oh!

stuartmorgan-g commented Feb 29, 2024

Uh oh!

stuartmorgan-g commented Feb 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants