Skip to content

[two_dimensional_scrollables] Fix layout offset of merged pinned cells - #6178

Merged
auto-submit[bot] merged 3 commits into
flutter:mainfrom
Piinks:mergedPinnedCells
Feb 22, 2024
Merged

[two_dimensional_scrollables] Fix layout offset of merged pinned cells#6178
auto-submit[bot] merged 3 commits into
flutter:mainfrom
Piinks:mergedPinnedCells

Conversation

@Piinks

Copy link
Copy Markdown
Contributor

Fixesflutter/flutter#143526

This fixes the layout offset computation when there are merged cells within pinned rows and/or columns in TableView.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@PiinksPiinks added the p: two_dimensional_scrollables Issues pertaining to the two_dimensional_scrollables package label Feb 22, 2024
@Piinks

Copy link
Copy Markdown
ContributorAuthor

Just when I thought #5917 had all the tests! 🤣

@goderbauergoderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment threadpackages/two_dimensional_scrollables/test/table_view/table_test.dart Outdated
@PiinksPiinks added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 22, 2024
@auto-submit
auto-submitBot merged commit 67470fc into flutter:mainFeb 22, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 23, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 23, 2024
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Feb 23, 2024
flutter/packages@078c2a3...7df2085
2024-02-22 ditman@gmail.com [web] Removes a few deprecated API usages. (flutter/packages#6177)
2024-02-22 katelovett@google.com [two_dimensional_scrollables] Fix layout offset of merged pinned cells (flutter/packages#6178)
2024-02-22 engine-flutter-autoroll@skia.org Roll Flutter from efee280 to 41581c9 (1 revision) (flutter/packages#6181)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu pushed a commit to LouiseHsu/packages that referenced this pull request Mar 7, 2024
flutter#6178)
Fixesflutter/flutter#143526
This fixes the layout offset computation when there are merged cells within pinned rows and/or columns in TableView.
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
flutter#6178)
Fixesflutter/flutter#143526
This fixes the layout offset computation when there are merged cells within pinned rows and/or columns in TableView.
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
flutter#6178)
Fixesflutter/flutter#143526
This fixes the layout offset computation when there are merged cells within pinned rows and/or columns in TableView.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: two_dimensional_scrollablesIssues pertaining to the two_dimensional_scrollables package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[two_dimensional_scrollables] Merged cells are not visible when pinned and scrolled

2 participants

@Piinks@goderbauer