Skip to content

[two_dimensional_scrollables] Fix another combo of pinned/unpinned merged TableViewCells - #6283

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
Piinks:b144100
Mar 7, 2024
Merged

[two_dimensional_scrollables] Fix another combo of pinned/unpinned merged TableViewCells#6283
auto-submit[bot] merged 1 commit into
flutter:mainfrom
Piinks:b144100

Conversation

@Piinks

Copy link
Copy Markdown
Contributor

Fixesflutter/flutter#144100
Picks up doc fix from #6154 as well

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@PiinksPiinks added the p: two_dimensional_scrollables Issues pertaining to the two_dimensional_scrollables package label Mar 7, 2024
@Piinks
Piinks requested a review from goderbauerMarch 7, 2024 18:09

@goderbauergoderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/// cellBuilder: (BuildContext context, TableVicinity vicinity) {
/// return Center(
/// child: Text('Cell ${vicinity.column} : ${vicinity.row}'),
/// return TableViewCell(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't a way to analyze snippets in this repo, right?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I am aware of. I searched the repo for cases of this but did not find any.

@PiinksPiinks added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 7, 2024
@auto-submit
auto-submitBot merged commit 0badb43 into flutter:mainMar 7, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 8, 2024
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Mar 8, 2024
flutter/packages@6701c9e...0badb43
2024-03-07 katelovett@google.com [two_dimensional_scrollables] Fix another combo of pinned/unpinned merged TableViewCells (flutter/packages#6283)
2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter from 8f84f3f to 471a828 (27 revisions) (flutter/packages#6281)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: two_dimensional_scrollablesIssues pertaining to the two_dimensional_scrollables package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[two_dimensional_scrollables] Merged cells is rendered in wrong position when pinned and scrolled

2 participants

@Piinks@goderbauer