[camerax] Use `AspectRatioStrategy` and `ResolutionFilter` to help automatic selection of expected resolution by camsim99 · Pull Request #6357 · flutter/packages

camsim99 · 2024-03-19T18:11:50Z

Defines AspectRatioStategys that will help CameraX select the resolution we expect.

Pre-launch Checklist

camsim99 · 2024-03-19T21:43:03Z

+ getProxyForTestingResolutionPreset(mockProcessCameraProvider);

- when(mockProcessCameraProvider.bindToLifecycle(mockBackCameraSelector, any))
+ when(mockProcessCameraProvider.bindToLifecycle(any, any))


I removed similar testing of this particular call in a couple of tests in this PR and felt comfortable doing so because it is tested in other createCamera tests.

gmackall

LGTM!

Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>

auto-submit · 2024-03-21T19:28:22Z

auto label is removed for flutter/packages/6357, due to - The status or check suite Linux_android android_device_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

camsim99 · 2024-03-25T19:24:35Z

I was going to try to fix the linked issue in two PRs but tests are failing because I didn't implement a resolution filter for the one resolution preset that this PR does not address. Will work on implementing the filter and getting the tests to pass to avoid disabling/changing any tests.

…amx_aspect

camsim99 · 2024-03-26T19:39:13Z

@gmackall if you are willing to take another look at this, I would greatly appreciate it!

Overview of the new changes:

The main change to the logic I made was adding a ResolutionFilter for automatic resolution selection.
This required that I wrap that native class: Dart wrapper, Java wrapper + added tests for both.
I also added the ResolutionFilter as a parameter for a ResolutionSelector (as it natively): Dart edits, Java edits + added tests.

gmackall

I left some comments about documentation/a class name but LGTM outside that!

gmackall · 2024-03-26T20:57:49Z

+ * <p>This class handles instantiating and adding native object instances that are attached to a
+ * Dart instance or handle method calls on the associated native class or an instance of the class.
+ */
+public class ResolutionFilterHostApiImpl implements ResolutionFilterHostApi {


(I don't think this matters that much but just for my understanding) Isn't this more of a ResolutionFilterConstructor/FactoryHostApiImpl? Because we aren't wrapping the methods of the ResolutionFilter interface but rather of a class that defines and creates an instance of a ResolutionFilter?

Ooo yes I like this, thank you! I will rename the proxy class it uses to clarify that this calls into a factory of sorts.

…on of expected resolution (flutter/packages#6357)

flutter/packages@e6b3e11...924c7e6 2024-03-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ci] Temporarily allow-warnings in podspec_check_command.dart (#6416)" (flutter/packages#6419) 2024-03-28 ditman@gmail.com [ci] Temporarily allow-warnings in podspec_check_command.dart (flutter/packages#6416) 2024-03-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[interactive_media_ads] Creates and adds the `interactive_media_ads` plugin (#6060)" (flutter/packages#6417) 2024-03-27 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Creates and adds the `interactive_media_ads` plugin (flutter/packages#6060) 2024-03-27 43054281+camsim99@users.noreply.github.com [camerax] Use `AspectRatioStrategy` to help automatic selection of expected resolution (flutter/packages#6357) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter/packages@e6b3e11...924c7e6 2024-03-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ci] Temporarily allow-warnings in podspec_check_command.dart (flutter#6416)" (flutter/packages#6419) 2024-03-28 ditman@gmail.com [ci] Temporarily allow-warnings in podspec_check_command.dart (flutter/packages#6416) 2024-03-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[interactive_media_ads] Creates and adds the `interactive_media_ads` plugin (flutter#6060)" (flutter/packages#6417) 2024-03-27 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Creates and adds the `interactive_media_ads` plugin (flutter/packages#6060) 2024-03-27 43054281+camsim99@users.noreply.github.com [camerax] Use `AspectRatioStrategy` to help automatic selection of expected resolution (flutter/packages#6357) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…pected resolution (flutter#6357) Defines `AspectRatioStategy`s that will help CameraX select the resolution we expect. Fixesflutter/flutter#144363.

Add aspect ratio where I can
fc073eb

github-actionsBot added the p: camera label Mar 19, 2024

camsim99 added 2 commits March 19, 2024 11:34

Start adding tests
a0da398

Add tests
3d6a9f1

camsim99 commented Mar 19, 2024
View reviewed changes

camsim99 added 2 commits March 19, 2024 14:45

Bump version
02d8bb0

Merge remote-tracking branch 'upstream/main' into camx_aspect
e22de74

camsim99 marked this pull request as ready for review March 20, 2024 17:29

camsim99 requested a review from a teamMarch 20, 2024 17:30

gmackall approved these changes Mar 20, 2024
View reviewed changes

Comment threadpackages/camera/camera_android_camerax/lib/src/camerax_proxy.dart Outdated

Update packages/camera/camera_android_camerax/lib/src/camerax_proxy.dart
4151936
Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>

camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2024

auto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2024

camsim99 marked this pull request as draft March 25, 2024 19:24

camsim99 added 5 commits March 26, 2024 10:43

Add functionality + java tests
559df9b

Add dart tests
67a324e

Merge remote-tracking branch 'upstream/main' into camx_aspect
e585343

Update changelog
f45e9d1

Merge remote-tracking branch 'refs/remotes/origin/camx_aspect' into c…
92939cd
…amx_aspect

github-actionsBot added the platform-android label Mar 26, 2024

Nits
196fd89

camsim99 marked this pull request as ready for review March 26, 2024 19:34

camsim99 requested a review from gmackall March 26, 2024 19:35

gmackall approved these changes Mar 26, 2024
View reviewed changes

Address review
29a77d5

camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 27, 2024

auto-submitBot merged commit f61723b into flutter:mainMar 27, 2024

camsim99 changed the title ~~[camerax] Use AspectRatioStrategy to help automatic selection of expected resolution~~[camerax] Use AspectRatioStrategy and ResolutionFilter to help automatic selection of expected resolutionMar 27, 2024

engine-flutter-autoroll mentioned this pull request Mar 28, 2024
Roll Packages from e6b3e11d9d5a to 924c7e6e899d (5 revisions) flutter/flutter#145904
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 28, 2024
f61723b[camerax] UseAspectRatioStrategyto help automatic selecti…
09802f3
…on of expected resolution (flutter/packages#6357)

engine-flutter-autoroll mentioned this pull request Mar 28, 2024
Roll Packages from e6b3e11d9d5a to 924c7e6e899d (5 revisions) flutter/flutter#145915
Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 28, 2024
f61723b[camerax] UseAspectRatioStrategyto help automatic selecti…
64006b5
…on of expected resolution (flutter/packages#6357)

reidbaker mentioned this pull request Apr 1, 2024
[camera_android_camerax] Move integration_test dependency to tests reidbaker/packages#4
Closed
11 tasks

Navigation Menu

Uh oh!

[camerax] Use `AspectRatioStrategy` and `ResolutionFilter` to help automatic selection of expected resolution - #6357

[camerax] Use `AspectRatioStrategy` and `ResolutionFilter` to help automatic selection of expected resolution#6357
auto-submit[bot] merged 13 commits into
flutter:mainfrom
camsim99:camx_aspect

camsim99 commented Mar 19, 2024•
edited
Loading

Uh oh!

camsim99Mar 19, 2024•
edited
Loading

Uh oh!

gmackall left a comment

Uh oh!

Uh oh!

auto-submitBot commented Mar 21, 2024

Uh oh!

camsim99 commented Mar 25, 2024•
edited
Loading

Uh oh!

camsim99 commented Mar 26, 2024•
edited
Loading

Uh oh!

gmackall left a comment

Uh oh!

Uh oh!

gmackallMar 26, 2024

Uh oh!

camsim99Mar 27, 2024•
edited
Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

camsim99 commented Mar 19, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

camsim99Mar 19, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gmackall left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

auto-submitBot commented Mar 21, 2024

Uh oh!

camsim99 commented Mar 25, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camsim99 commented Mar 26, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview of the new changes:

Uh oh!

gmackall left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gmackallMar 26, 2024

Choose a reason for hiding this comment

Uh oh!

camsim99Mar 27, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

camsim99 commented Mar 19, 2024•
edited
Loading

camsim99Mar 19, 2024•
edited
Loading

camsim99 commented Mar 25, 2024•
edited
Loading

camsim99 commented Mar 26, 2024•
edited
Loading

camsim99Mar 27, 2024•
edited
Loading