Uh oh!
There was an error while loading. Please reload this page.
[camera_web] Don't require enumerating cameras on web - #6369
[camera_web] Don't require enumerating cameras on web#6369kristoffer-zliide wants to merge 4 commits into
Conversation
kristoffer-zliide
commented
Mar 21, 2024
At the time of this writing, a version of the example app where the enumeration of can be tried out here. Note that, contrary to the normal example app, it doesn't ask for permission before you tap on a camera. |
45f54ec to
42480cfCompareThere was a problem hiding this comment.
Are the changes in this file because the example had an existing issue, or is the web change breaking to clients?
stuartmorgan-g
commented
May 8, 2024
@kristoffer-zliide This appears to be failing web tests in CI ( @ditman It looks like this is otherwise waiting for your review. |
stuartmorgan-g
commented
May 21, 2024
From triage: @kristoffer-zliide Are you planning on fixing the failing tests in this PR? |
stuartmorgan-g
commented
Jun 17, 2024
Marking as a draft pending resolution of the test failures. |
42480cf to
0e9c0fcCompare6e06d43 to
6fbdca5Compare6fbdca5 to
aafe0f2Comparekristoffer-zliide
commented
Jul 26, 2024
@stuartmorgan: The tests are passing now. |
stuartmorgan-g
commented
Jul 30, 2024
Please note that the PR won't be able to land without these steps, which is why they are in the checklist, and not doing it before review will add another round to the review process since things like the CHANGELOG wording are part of the review. |
ditman
commented
Aug 1, 2024
This will need to land until after the |
stuartmorgan-g
commented
Sep 10, 2024
@ditman Has that transition happened? If not, is there a tracking issue we can link to? |
ditman
commented
Sep 10, 2024
@stuartmorgan actually, yes, camera_web is in package:web since this PR: |
After merging
(@kristoffer-zliide I can move the changes to a new branch, if you'd prefer) |
stuartmorgan-g
commented
Oct 29, 2024
@kristoffer-zliide Are you still planning on updating this PR based on the review feedback? |
kristoffer-zliide
commented
Oct 31, 2024
I think I'm done here. Sorry if I wasted your time. Feel free to rebase/cherry-pick the four commits onto your own branches. |
Enumerating available cameras on web requires permission and activates hardware. This PR allows initializing the camera controller without having to enumerate available cameras first.
flutter/flutter#145541
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).If you need help, consider asking for advice on the #hackers-new channel on [Discord].