Skip to content

Add limit to image_picker_platform_interface - #6434

Merged
auto-submit[bot] merged 4 commits into
flutter:mainfrom
pdenert:add-limit-to-image-picker-platform-interface
Apr 7, 2024
Merged

Add limit to image_picker_platform_interface#6434
auto-submit[bot] merged 4 commits into
flutter:mainfrom
pdenert:add-limit-to-image-picker-platform-interface

Conversation

@pdenert

@pdenertpdenert commented Mar 28, 2024

Copy link
Copy Markdown
Contributor

Adds limit parameter to MediaOptions and MultiImagePickerOptions. The limit argument defines how many images or media files can be select.

Only platform interface package changes taken from: #6201

Fixes: flutter/flutter#85772

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@pdenertpdenert mentioned this pull request Mar 28, 2024
Merged
11 tasks
@pdenert
pdenertforce-pushed the add-limit-to-image-picker-platform-interface branch from db772a1 to c00d8deCompareMarch 29, 2024 14:11
tarrinneal
tarrinneal approved these changes Apr 1, 2024
View reviewed changes

@tarrinnealtarrinneal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuartmorgan for 2nd

stuartmorgan-g
stuartmorgan-g requested changes Apr 5, 2024
View reviewed changes
Comment threadpackages/image_picker/image_picker_platform_interface/lib/src/types/media_options.dart
Comment thread...cker/image_picker_platform_interface/lib/src/method_channel/method_channel_image_picker.dart Outdated
Comment threadpackages/image_picker/image_picker_platform_interface/lib/src/types/media_options.dart
Comment threadpackages/image_picker/image_picker_platform_interface/lib/src/types/media_options.dart Outdated
Comment thread...s/image_picker/image_picker_platform_interface/lib/src/types/multi_image_picker_options.dart
stuartmorgan-g
stuartmorgan-g approved these changes Apr 7, 2024
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 7, 2024
@auto-submit
auto-submitBot merged commit 3a21cfa into flutter:mainApr 7, 2024
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Apr 8, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 8, 2024
@engine-flutter-autoroll
3a21cfaAdd limit to image_picker_platform_interface (flutter/package…
be37dc4
…s#6434)
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Apr 8, 2024
@engine-flutter-autoroll
Roll Packages from764d997to6b4d8b6(5 revisions) (#146429)
56e9e2a
flutter/packages@764d997...6b4d8b6
2024-04-08 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.9 to 3.24.10 (flutter/packages#6480)
2024-04-07 pdenert09@gmail.com Add limit to image_picker_platform_interface (flutter/packages#6434)
2024-04-07 engine-flutter-autoroll@skia.org Roll Flutter from 477ebd8 to 98d23f7 (16 revisions) (flutter/packages#6478)
2024-04-05 engine-flutter-autoroll@skia.org Roll Flutter from ac2ca93 to 477ebd8 (32 revisions) (flutter/packages#6470)
2024-04-05 PROGrand@users.noreply.github.com [camera] Camera with MediaSettings: platform implementations (federated) (flutter/packages#5223)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
@engine-flutter-autoroll@gilnobrega
Roll Packages from764d997to6b4d8b6(5 revisions) (flutter#146429)
980a21b
flutter/packages@764d997...6b4d8b6
2024-04-08 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.9 to 3.24.10 (flutter/packages#6480)
2024-04-07 pdenert09@gmail.com Add limit to image_picker_platform_interface (flutter/packages#6434)
2024-04-07 engine-flutter-autoroll@skia.org Roll Flutter from 477ebd8 to 98d23f7 (16 revisions) (flutter/packages#6478)
2024-04-05 engine-flutter-autoroll@skia.org Roll Flutter from ac2ca93 to 477ebd8 (32 revisions) (flutter/packages#6470)
2024-04-05 PROGrand@users.noreply.github.com [camera] Camera with MediaSettings: platform implementations (federated) (flutter/packages#5223)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
@pdenert@TecHaxter
Add limit to image_picker_platform_interface (flutter#6434)
0ede02f
Adds limit parameter to `MediaOptions` and `MultiImagePickerOptions`. The `limit` argument defines how many images or media files can be select.
Only platform interface package changes taken from: flutter#6201
Fixes: [flutter/flutter#85772](flutter/flutter#85772)
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@pdenert
Add limit to image_picker_platform_interface (flutter#6434)
f76ed1c
Adds limit parameter to `MediaOptions` and `MultiImagePickerOptions`. The `limit` argument defines how many images or media files can be select.
Only platform interface package changes taken from: flutter#6201
Fixes: [flutter/flutter#85772](flutter/flutter#85772)
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@pdenert
Add limit to image_picker_platform_interface (flutter#6434)
14fd4dc
Adds limit parameter to `MediaOptions` and `MultiImagePickerOptions`. The `limit` argument defines how many images or media files can be select.
Only platform interface package changes taken from: flutter#6201
Fixes: [flutter/flutter#85772](flutter/flutter#85772)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes
@tarrinnealtarrinnealtarrinneal approved these changes

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: image_picker

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

image_picker add picture limit to getMultiImage

3 participants

@pdenert@stuartmorgan-g@tarrinneal