Uh oh!
There was an error while loading. Please reload this page.
[in_app_purchase_android] Introduced new ReplacementMode for Android's billing client - #6515
Conversation
vongrad
commented
Apr 20, 2024
@bparrishMines I have made this PR in favor of #6403 (comment). Any chance it can be reviewed? |
bparrishMines
left a comment
There was a problem hiding this comment.
LGTM
@gmackall could you give this a secondary review
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
gmackall
left a comment
There was a problem hiding this comment.
LGTM minus the nits @bparrishMines requested
vongrad
commented
May 9, 2024
I made the requested changes. I have however made a mistake with rebasing the branch with |
vongrad
commented
May 10, 2024
Anything missing from my end? |
Uh oh!
There was an error while loading. Please reload this page.
vongrad
commented
May 13, 2024
@bparrishMines I have made the changes you requested, could you review it? |
Introduced new
ReplacementModefor Android's billing client and deprecatedProrationMode.This PR is a follow-up on #6403, where it was decided that we should not replace the
ProrationModewithReplacementMode, but instead only deprecateProrationMode. The reason for a new PR is also thatin_app_purchase_androidversion0.3.3changed internal platform communication to Pigeon, which meant I had to make major changes to my original PR.List which issues are fixed by this PR. You must list at least one issue.
flutter/flutter#128957
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).