Skip to content

[in_app_purchase_android] Introduced new ReplacementMode for Android's billing client - #6515

Merged
auto-submit[bot] merged 9 commits into
flutter:mainfrom
vongrad:pr/replacement-mode
May 22, 2024
Merged

[in_app_purchase_android] Introduced new ReplacementMode for Android's billing client#6515
auto-submit[bot] merged 9 commits into
flutter:mainfrom
vongrad:pr/replacement-mode

Conversation

@vongrad

Copy link
Copy Markdown
Contributor

Introduced new ReplacementMode for Android's billing client and deprecated ProrationMode.

This PR is a follow-up on #6403, where it was decided that we should not replace the ProrationMode with ReplacementMode, but instead only deprecate ProrationMode. The reason for a new PR is also that in_app_purchase_android version 0.3.3 changed internal platform communication to Pigeon, which meant I had to make major changes to my original PR.

List which issues are fixed by this PR. You must list at least one issue.
flutter/flutter#128957

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@vongrad

Copy link
Copy Markdown
ContributorAuthor

@bparrishMines I have made this PR in favor of #6403 (comment). Any chance it can be reviewed?

@yaakovschectmanyaakovschectman changed the title Introduced new ReplacementMode for Android's billing client[in_app_purchase_android] Introduced new ReplacementMode for Android's billing clientMay 2, 2024

@bparrishMinesbparrishMines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmackall could you give this a secondary review

Comment threadpackages/in_app_purchase/in_app_purchase_android/CHANGELOG.md Outdated
Comment threadpackages/in_app_purchase/in_app_purchase_android/CHANGELOG.md Outdated

@gmackallgmackall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus the nits @bparrishMines requested

@vongrad

Copy link
Copy Markdown
ContributorAuthor

I made the requested changes. I have however made a mistake with rebasing the branch with main and pushing, hence all the new required reviewers. I rolled it back, but the extra reviewers remained on the PR, any chance that you can remove them?

@vongrad

Copy link
Copy Markdown
ContributorAuthor

Anything missing from my end?

Comment threadpackages/in_app_purchase/in_app_purchase_android/CHANGELOG.md Outdated
@vongrad

Copy link
Copy Markdown
ContributorAuthor

@bparrishMines I have made the changes you requested, could you review it?

@bparrishMinesbparrishMines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: in_app_purchaseplatform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@vongrad@domesticmouse@bparrishMines@gmackall