Skip to content

[video_player_android] Migrate ExoPlayer to ExoPlayer-Media3 1.3.1 - #6535

Merged
auto-submit[bot] merged 9 commits into
flutter:mainfrom
emakar:video_player_android-media3
Jun 7, 2024
Merged

[video_player_android] Migrate ExoPlayer to ExoPlayer-Media3 1.3.1#6535
auto-submit[bot] merged 9 commits into
flutter:mainfrom
emakar:video_player_android-media3

Conversation

@emakar

@emakaremakar commented Apr 15, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Resolves#130272

Migrated with https://developer.android.com/media/media3/exoplayer/migration-guide#usingscript

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@emakar
emakar marked this pull request as ready for review April 15, 2024 11:06
@emakar
emakar requested a review from camsim99 as a code ownerApril 15, 2024 11:06
@emakar
emakarforce-pushed the video_player_android-media3 branch from e33e5a9 to fc005d7CompareApril 15, 2024 11:43
@emakar
emakar marked this pull request as draft April 15, 2024 11:44
@emakar
emakarforce-pushed the video_player_android-media3 branch from fc005d7 to 76a2837CompareApril 15, 2024 12:21
emakar
emakar commented Apr 15, 2024
View reviewed changes
Comment threadpackages/video_player/video_player_android/android/build.gradle Outdated
emakar
emakar commented Apr 15, 2024
View reviewed changes
Comment threadpackages/video_player/video_player_android/android/build.gradle Outdated
@emakar
emakar marked this pull request as ready for review April 15, 2024 12:45
@emakaremakar mentioned this pull request Apr 15, 2024
Closed
camsim99
camsim99 reviewed Apr 15, 2024
View reviewed changes

@camsim99camsim99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!! Left a couple of thoughts.

Comment thread...r/video_player_android/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayer.java Outdated
Comment threadpackages/video_player/video_player_android/CHANGELOG.md Outdated
Comment threadpackages/video_player/video_player_android/android/build.gradle Outdated
Comment threadpackages/video_player/video_player_android/android/build.gradle Outdated
@emakar
emakarforce-pushed the video_player_android-media3 branch from 76a2837 to 5b0a1cfCompareApril 15, 2024 18:19
@emakaremakar changed the title [video_player_android] Migrate ExoPlayer to ExoPlayer-Media3 1.1.1[video_player_android] Migrate ExoPlayer to ExoPlayer-Media3 1.3.1Apr 15, 2024
@emakar
emakar marked this pull request as draft April 15, 2024 19:05
@emakar
emakarforce-pushed the video_player_android-media3 branch 5 times, most recently from 222c1a3 to a26491dCompareApril 16, 2024 12:30
emakar
emakar commented Apr 16, 2024
View reviewed changes
Comment threadpackages/video_player/video_player_android/android/build.gradle Outdated
emakar
emakar commented Apr 16, 2024
View reviewed changes
Comment threadpackages/espresso/android/build.gradle Outdated
@emakar
emakarforce-pushed the video_player_android-media3 branch 4 times, most recently from a6952b6 to eb4fd61CompareApril 16, 2024 17:54
stuartmorgan-g
stuartmorgan-g reviewed Apr 18, 2024
View reviewed changes
Comment threadpackages/espresso/android/build.gradle Outdated
Comment thread...r/video_player_android/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayer.java Outdated
@emakar
emakarforce-pushed the video_player_android-media3 branch from aa4c94b to 1ef9058CompareJune 6, 2024 21:14
@emakar

emakar commented Jun 6, 2024

Copy link
Copy Markdown
ContributorAuthor

thanks for the review!

@camsim99
camsim99 self-requested a review June 6, 2024 21:42
stuartmorgan-g
stuartmorgan-g approved these changes Jun 6, 2024
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread...r/video_player_android/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayer.java Outdated
@emakar
emakarforce-pushed the video_player_android-media3 branch from 1ef9058 to 14409b8CompareJune 7, 2024 07:56
@emakar
emakarforce-pushed the video_player_android-media3 branch from 14409b8 to a134c80CompareJune 7, 2024 08:14
@emakar

emakar commented Jun 7, 2024

Copy link
Copy Markdown
ContributorAuthor

@camsim99 could you please review this?

camsim99
camsim99 approved these changes Jun 7, 2024
View reviewed changes

@camsim99camsim99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@camsim99camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 7, 2024
@auto-submit
auto-submitBot merged commit 14722b7 into flutter:mainJun 7, 2024
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jun 10, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 10, 2024
@engine-flutter-autoroll
14722b7[video_player_android] Migrate ExoPlayer to ExoPlayer-Media3 …
a7daaa5
…1.3.1 (flutter/packages#6535)
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Jun 10, 2024
@engine-flutter-autoroll
Roll Packages from8a2c4e4toe95fe4a(3 revisions) (#149997)
03b487b
flutter/packages@8a2c4e4...e95fe4a
2024-06-07 engine-flutter-autoroll@skia.org Manual roll Flutter from 4608a89 to fc19ecf (38 revisions) (flutter/packages#6890)
2024-06-07 stuartmorgan@google.com [pigeon] Fix handling of null class args in C++ (flutter/packages#6881)
2024-06-07 eugene.makar@yandex.ru [video_player_android] Migrate ExoPlayer to ExoPlayer-Media3 1.3.1 (flutter/packages#6535)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbakerreidbaker mentioned this pull request Jul 2, 2024
Closed
11 tasks
@stuartmorgan-gstuartmorgan-g mentioned this pull request Jul 3, 2024
Open
@marvin-koljamarvin-kolja mentioned this pull request Apr 16, 2025
Closed
marvin-kolja added a commit to marvin-kolja/packages that referenced this pull request May 4, 2025
@marvin-kolja
fix(video_player_android): remove incorrect width/height swap for 90/…
a633aca
…270 rotation
Since flutter#6535 `VideoSize` is used to get width and height instead of getting them from the video `Format`. My testing concluded that `VideoSize` dimension values are post rotation and do not need to be swapped when there is a 90 or 270 degree rotation present.
@jmagmanjmagman mentioned this pull request Oct 6, 2025
Open
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@emakar
[video_player_android] Migrate ExoPlayer to ExoPlayer-Media3 1.3.1 (f…
901c96c
…lutter#6535)
Resolves [#130272](flutter/flutter#130272)
Migrated with https://developer.android.com/media/media3/exoplayer/migration-guide#usingscript
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@emakar
[video_player_android] Migrate ExoPlayer to ExoPlayer-Media3 1.3.1 (f…
ae6474c
…lutter#6535)
Resolves [#130272](flutter/flutter#130272)
Migrated with https://developer.android.com/media/media3/exoplayer/migration-guide#usingscript
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbakerreidbakerreidbaker left review comments
@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes
@camsim99camsim99camsim99 approved these changes
+1 more reviewer
@icbakericbakericbaker left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: video_playerplatform-androidtriage-androidShould be looked at in Android triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[video_player_android] Migrate to androidx.media3

6 participants

@emakar@stuartmorgan-g@gmackall@reidbaker@icbaker@camsim99