Uh oh!
There was an error while loading. Please reload this page.
[ci] Add more dev dependency checks, and fix errors - #6563
Merged
auto-submit[bot] merged 1 commit intoApr 18, 2024
Conversation
- Adds `build_runner`, `mockito`, and `pigeon` to the list of dependencies that we expect to only be in dev_dependencies. - Fixes the error message for violations; I had missed in initial review that the errorr message was the same as the one for non-repo-local depndencies, making it misleading about what the problem was and how to fix it. (Also fixed the indentation, which had always been wrong.) - Fixes `camera_avfoundation`, which had a violation introduced in my recent PR to start the Pigeon conversion. See flutter/flutter#117905
| 'test', | ||
| ]; | ||
| for (final String dependency in packages) { | ||
| test('fails when $dependency is used in non dev dependency', |
CollaboratorAuthor
There was a problem hiding this comment.
I switched the structure to a loop-constructed test set where each test only checks one package, because it's easier to ensure that everything is actually being covered (e.g., that we don't add a package to the list of dependencies, but forget to add it to the error message, so that it looks like it's being tested but actually isn't).
hellohuanlin
approved these changes
Apr 18, 2024
reidbaker
approved these changes
Apr 18, 2024
11 tasks
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 19, 2024
auto-submitBot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 19, 2024
flutter/packages@0e3809d...88a3a56 2024-04-19 stuartmorgan@google.com [camera] Convert iOS Obj-C->Dart calls to Pigeon (flutter/packages#6568) 2024-04-19 highdro0479@gmail.com [flutter_markdown] Ensure customize nested bullet list style. (flutter/packages#6384) 2024-04-18 stuartmorgan@google.com [ci] Add more dev dependency checks, and fix errors (flutter/packages#6563) 2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter from 3882afb to fb110b9 (56 revisions) (flutter/packages#6565) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
flutter/packages@0e3809d...88a3a56 2024-04-19 stuartmorgan@google.com [camera] Convert iOS Obj-C->Dart calls to Pigeon (flutter/packages#6568) 2024-04-19 highdro0479@gmail.com [flutter_markdown] Ensure customize nested bullet list style. (flutter/packages#6384) 2024-04-18 stuartmorgan@google.com [ci] Add more dev dependency checks, and fix errors (flutter/packages#6563) 2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter from 3882afb to fb110b9 (56 revisions) (flutter/packages#6565) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
- Adds `build_runner`, `mockito`, and `pigeon` to the list of dependencies that we expect to only be in dev_dependencies. - Fixes the error message for violations; I had missed in initial review that the errorr message was the same as the one for non-repo-local depndencies, making it misleading about what the problem was and how to fix it. (Also fixed the indentation, which had always been wrong.) - Fixes `camera_avfoundation`, which had a violation introduced in my recent PR to start the Pigeon conversion. See flutter/flutter#117905
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
- Adds `build_runner`, `mockito`, and `pigeon` to the list of dependencies that we expect to only be in dev_dependencies. - Fixes the error message for violations; I had missed in initial review that the errorr message was the same as the one for non-repo-local depndencies, making it misleading about what the problem was and how to fix it. (Also fixed the indentation, which had always been wrong.) - Fixes `camera_avfoundation`, which had a violation introduced in my recent PR to start the Pigeon conversion. See flutter/flutter#117905
bisor0627 pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
- Adds `build_runner`, `mockito`, and `pigeon` to the list of dependencies that we expect to only be in dev_dependencies. - Fixes the error message for violations; I had missed in initial review that the errorr message was the same as the one for non-repo-local depndencies, making it misleading about what the problem was and how to fix it. (Also fixed the indentation, which had always been wrong.) - Fixes `camera_avfoundation`, which had a violation introduced in my recent PR to start the Pigeon conversion. See flutter/flutter#117905
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build_runner,mockito, andpigeonto the list of dependencies that we expect to only be in dev_dependencies.camera_avfoundation, which had a violation introduced in my recent PR to start the Pigeon conversion.See flutter/flutter#117905
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).