[two_dimensional_scrollables] TreeView by Piinks · Pull Request #6592 · flutter/packages

Piinks · 2024-04-22T16:25:16Z

FYI for Reviewers: Much of the API surface matches that of the 1D SliverTree in flutter/flutter#147171 If it changes here, it should change there, and vice versa.

📜 Design Document

Adds classes and associated callbacks and controllers for TreeView. Core components:

TreeView
TreeViewport
RenderTreeViewport
TreeViewController
TreeViewNode
TreeViewStateMixin
TreeViewIndentationType
TreeRowDelegateMixin
TreeRowBuilderDelegate

Along with Span subclasses for trees:

TreeRowPadding
TreeRowExtentDelegate
TreeRowExtent (and subclasses)
TreeRowBorder

Fixesflutter/flutter#42332
Fixesflutter/flutter#126298

treeView_0.mov

treeView_1.mov

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Piinks · 2024-05-09T23:35:45Z

No rush on the re-review, it's a big one. Best taken in breaks. :)

Review feedback diff is contained in 5a0194c

goderbauer · 2024-05-10T20:35:13Z

+ final T _content;
+
+ /// Other [TreeViewNode]s this this node will be [parent] to.
+ List<TreeViewNode<T>> get children => _children;


Is this true? didUpdateWidget wouldn't be called if I pass a TreeViewNode to TreeView and then later on call .children.append(...) on that TreeViewNode? Or can you show in a test that that actually works?

Outdated.

Piinks · 2024-05-14T22:34:13Z

Filed follow up issues:

goderbauer

LGTM

auto-submit · 2024-05-15T17:34:20Z

auto label is removed for flutter/packages/6592, due to This PR has not met approval requirements for merging. Changes were requested by {TahaTesser}, please make the needed changes and resubmit this PR.
The PR author is a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

Piinks · 2024-05-15T17:39:13Z

Oh right, the autosubmit bot has a bug where if anyone submits a "changes requested" review, even if it is dismissed, the bot can't tell. I'll wait for CI to pass and merge it manually.

flutter/packages@87a02e3...ae4dd32 2024-05-17 engine-flutter-autoroll@skia.org Roll Flutter from 0d22d91 to 00425ef (14 revisions) (flutter/packages#6753) 2024-05-16 32538273+ValentinVignal@users.noreply.github.com [go_router_builder] Add test for `onExit` (flutter/packages#6614) 2024-05-16 32666446+hamdikahloun@users.noreply.github.com [camera_android_camerax] update to latest stable camerax 1.3.3 (flutter/packages#6737) 2024-05-16 magder@google.com [camera_avfoundation] Revert camera example PRODUCT_BUNDLE_IDENTIFIER (flutter/packages#6735) 2024-05-16 15619084+vashworth@users.noreply.github.com [file_selector_ios, image_picker_ios] Remove Swift Package Support (flutter/packages#6740) 2024-05-16 katelovett@google.com [two_dimensional_scrollables] TreeView (flutter/packages#6592) 2024-05-16 engine-flutter-autoroll@skia.org Roll Flutter from 39651e8 to 0d22d91 (23 revisions) (flutter/packages#6748) 2024-05-16 byoungchan.lee@gmx.com [pigeon][swift] Removes FlutterError in favor of PigeonError (flutter/packages#6611) 2024-05-16 15619084+vashworth@users.noreply.github.com [webview_flutter] Skip "Video playback policy" drive tests (flutter/packages#6747) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

**FYI for Reviewers:** Much of the API surface matches that of the 2D TreeView in flutter/packages#6592. If it changes here, it should change there, and vice versa. ð�� [Design Document](https://docs.google.com/document/d/1-aFI7VjkF9yMkWpP94J8T_JREDS-M3bOak26PVehUYg/edit?usp=sharing) This adds classes and associated callbacks and controllers for TreeSliver. Core components: - TreeSliver - RenderTreeSliver - TreeSliverNode - TreeSliverController - TreeSliverStateMixin - TreeSliverIndentationType Fixes#114299 https://github.com/flutter/flutter/assets/16964204/3facd095-7262-4068-aa33-d713e2deca99 https://github.com/flutter/flutter/assets/16964204/f851ae30-8e71-45c7-82a4-9606986a5872

Reverts: #147171 Initiated by: QuncCccccc Reason for reverting: tree is red due to a test in this PR Original PR Author: Piinks Reviewed By: {QuncCccccc, TahaTesser, bleroux} This change reverts the following previous change: **FYI for Reviewers:** Much of the API surface matches that of the 2D TreeView in flutter/packages#6592. If it changes here, it should change there, and vice versa. 📜 [Design Document](https://docs.google.com/document/d/1-aFI7VjkF9yMkWpP94J8T_JREDS-M3bOak26PVehUYg/edit?usp=sharing) This adds classes and associated callbacks and controllers for TreeSliver. Core components: - TreeSliver - RenderTreeSliver - TreeSliverNode - TreeSliverController - TreeSliverStateMixin - TreeSliverIndentationType Fixes#114299 https://github.com/flutter/flutter/assets/16964204/3facd095-7262-4068-aa33-d713e2deca99 https://github.com/flutter/flutter/assets/16964204/f851ae30-8e71-45c7-82a4-9606986a5872

Piinks added the p: two_dimensional_scrollables Issues pertaining to the two_dimensional_scrollables package label Apr 22, 2024

github-actionsBot added the platform-macos label Apr 22, 2024

Piinks force-pushed the treeView-7 branch from 4f6329e to f25dcd2Compare April 22, 2024 17:33

Piinks commented Apr 22, 2024
View reviewed changes

Comment threadpackages/two_dimensional_scrollables/lib/src/tree_view/tree.dart

Piinks mentioned this pull request Apr 22, 2024
TreeSliver & associated classes flutter/flutter#147171
Merged
9 tasks

Piinks commented Apr 23, 2024
View reviewed changes

Comment threadpackages/two_dimensional_scrollables/example/.pluginToolsConfig.yaml

Piinks force-pushed the treeView-7 branch from c20e3b8 to f3390caCompare April 24, 2024 00:29

Piinks marked this pull request as ready for review April 24, 2024 22:36

Piinks requested review from HansMuller, QuncCccccc, TahaTesser, bleroux and goderbauer April 24, 2024 22:37

TahaTesser reviewed Apr 25, 2024
View reviewed changes

TahaTesser suggested changes Apr 25, 2024
View reviewed changes

Comment threadpackages/two_dimensional_scrollables/example/lib/table_view/simple_table.dart
Comment threadpackages/two_dimensional_scrollables/example/lib/tree_view/custom_tree.dart
Comment threadpackages/two_dimensional_scrollables/example/lib/tree_view/simple_tree.dart

TahaTesser previously requested changes Apr 25, 2024
View reviewed changes

Comment threadpackages/two_dimensional_scrollables/example/test/tree_view/custom_tree_test.dart Outdated

bleroux reviewed Apr 25, 2024
View reviewed changes

Comment threadpackages/two_dimensional_scrollables/example/lib/table_view/infinite_table.dart Outdated

goderbauer reviewed May 7, 2024
View reviewed changes

Piinks force-pushed the treeView-7 branch from 81f7b10 to 5a0194cCompare May 9, 2024 23:24

Piinks requested review from TahaTesser, bleroux and goderbauer May 9, 2024 23:35

goderbauer reviewed May 10, 2024
View reviewed changes

Piinks added 6 commits May 14, 2024 17:20

Copy over from other branch
035367a

Some tidying
060b3f9

++
d945196

Fixed animation bug
4ea67d9

Formatting
4044bf7

Reworked depth handling
87d172d

Piinks force-pushed the treeView-7 branch from 318f7fd to d56702eCompare May 14, 2024 22:20

Piinks mentioned this pull request May 14, 2024
TreeSliver & TreeView alternate focus traversal options flutter/flutter#148357
Open

Format
eb32309

Piinks mentioned this pull request May 14, 2024
TreeSliver & TreeView support for lazy tree nodes flutter/flutter#148358
Open

Piinks requested a review from goderbauer May 14, 2024 22:34

goderbauer approved these changes May 15, 2024
View reviewed changes

Comment threadpackages/two_dimensional_scrollables/lib/src/tree_view/render_tree.dart Outdated
Comment threadpackages/two_dimensional_scrollables/lib/src/tree_view/tree.dart Outdated

Final feedback
50a232f

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label May 15, 2024

auto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 15, 2024

Piinks merged commit b83b63c into flutter:mainMay 16, 2024

engine-flutter-autoroll mentioned this pull request May 16, 2024
Roll Packages from 87a02e393be0 to 29101bf1ee37 (7 revisions) flutter/flutter#148502
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 16, 2024
b83b63c[two_dimensional_scrollables] TreeView (flutter/packages#6592)
008497e

engine-flutter-autoroll mentioned this pull request May 17, 2024
Roll Packages from 87a02e393be0 to 5690c378b494 (8 revisions) flutter/flutter#148545
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 17, 2024
b83b63c[two_dimensional_scrollables] TreeView (flutter/packages#6592)
9f1fef1

engine-flutter-autoroll mentioned this pull request May 17, 2024
Roll Packages from 87a02e393be0 to ae4dd32f4a66 (9 revisions) flutter/flutter#148555
Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 17, 2024
b83b63c[two_dimensional_scrollables] TreeView (flutter/packages#6592)
9916fcf

TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
[two_dimensional_scrollables] TreeView (flutter#6592)
f55d614

auto-submitBot mentioned this pull request Jun 5, 2024
Reverts "TreeSliver & associated classes (#147171)" flutter/flutter#149754
Merged
9 tasks

reidbaker mentioned this pull request Jul 2, 2024
i151188 update espresso dependencies v2 reidbaker/packages#6
Closed
11 tasks

creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
[two_dimensional_scrollables] TreeView (flutter#6592)
3c5c92e

bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
[two_dimensional_scrollables] TreeView (flutter#6592)
5aceb8f

Uh oh!

Conversation

Piinks commented Apr 22, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Piinks commented May 9, 2024

Uh oh!

Uh oh!

Uh oh!

goderbauerMay 10, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Piinks commented May 14, 2024

Uh oh!

goderbauer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

auto-submitBot commented May 15, 2024

Uh oh!

Piinks commented May 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Piinks commented Apr 22, 2024•
edited
Loading