Skip to content

[lifecycle]: Dependabot takeover Bump com.android.tools.build:gradle from 7.2.1 to 8.3.2 in /packages/flutter_plugin_android_lifecycle/android - #6595

Closed
reidbaker wants to merge 4 commits into
flutter:mainfrom
reidbaker:2024-04-22-dependabot-lifecycle-agp
Closed

[lifecycle]: Dependabot takeover Bump com.android.tools.build:gradle from 7.2.1 to 8.3.2 in /packages/flutter_plugin_android_lifecycle/android #6595
reidbaker wants to merge 4 commits into
flutter:mainfrom
reidbaker:2024-04-22-dependabot-lifecycle-agp

Conversation

@reidbaker

@reidbakerreidbaker commented Apr 22, 2024

Copy link
Copy Markdown
Contributor

Takeover from #6525

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@reidbaker

Copy link
Copy Markdown
ContributorAuthor

Recreated the ci issue by running
dart run ./script/tool/bin/flutter_plugin_tools.dart create-all-packages-app --legacy-source=.ci/legacy_project/all_packages --exclude script/configs/exclude_all_packages_app.yaml --output-dir=legacy
Followed by setting the java version to java 11 flutter config --jdk-dir=/Library/Java/JavaVirtualMachines/zulu-11.jre/Contents/Home
then running flutter build apk

@reidbaker

Copy link
Copy Markdown
ContributorAuthor

Hold progress on #6591

@reidbaker
reidbaker marked this pull request as ready for review April 24, 2024 14:06
@reidbaker
reidbaker requested review from a team and gmackallApril 24, 2024 14:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@reidbaker@yaakovschectman