Skip to content

[in_app_purchase] implement countryCode correctly - #6636

Merged
auto-submit[bot] merged 3 commits into
flutter:mainfrom
reidbaker:i147230-country-code-not-get
May 2, 2024
Merged

[in_app_purchase] implement countryCode correctly#6636
auto-submit[bot] merged 3 commits into
flutter:mainfrom
reidbaker:i147230-country-code-not-get

Conversation

@reidbaker

Copy link
Copy Markdown
Contributor

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reidbakerreidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label May 2, 2024
@auto-submit
auto-submitBot merged commit f4719ca into flutter:mainMay 2, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 3, 2024
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request May 3, 2024
flutter/packages@aea93d2...f4719ca
2024-05-02 reidbaker@google.com [in_app_purchase] implement countryCode correctly (flutter/packages#6636)
2024-05-02 15619084+vashworth@users.noreply.github.com Skip podspec Swift Search Path validation if only swift file is Package.swift for darwin plugins (flutter/packages#6635)
2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter from d33bb8f to bf7191f (34 revisions) (flutter/packages#6637)
2024-05-01 petermnt@users.noreply.github.com [webview_flutter_android] Fixes iframe navigation with `onNavigationRequest` (flutter/packages#6335)
2024-05-01 engine-flutter-autoroll@skia.org Roll Flutter from b597dd2 to d33bb8f (7 revisions) (flutter/packages#6633)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth pushed a commit to vashworth/packages that referenced this pull request May 6, 2024
- **Rename getCountryCode to country code for ios and android IAP**
- **Add changelog**
fixesflutter/flutter#147230
@reidbaker
reidbaker deleted the i147230-country-code-not-get branch May 7, 2024 15:45
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
- **Rename getCountryCode to country code for ios and android IAP**
- **Add changelog**
fixesflutter/flutter#147230
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
- **Rename getCountryCode to country code for ios and android IAP**
- **Add changelog**
fixesflutter/flutter#147230
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
- **Rename getCountryCode to country code for ios and android IAP**
- **Add changelog**
fixesflutter/flutter#147230
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: in_app_purchaseplatform-androidplatform-iosplatform-macos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

getCountryCode methods are not implementing countryCode platform interface method

4 participants

@reidbaker@stuartmorgan-g@gmackall@LouiseHsu