[image_picker] Adds comment for the limit parameter by LinXunFeng · Pull Request #6678 · flutter/packages

LinXunFeng · 2024-05-07T06:18:31Z

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
I signed the CLA.
The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
I linked to at least one issue that this PR fixes in the description above.
I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

tarrinneal · 2024-05-07T10:27:52Z

There should be [] around ImagePickerAndroid, and `` around useAndroidPhotoPicker
This also seems a little verbose, maybe shorten it to
On Android, [ImagePickerAndroid.useAndroidPhotoPicker] must be set to `true` to use the `limit` functionality
I'm not sure the see: [link] part is necessary either.
Same for the other instance of this comment.

Thanks for the review, I've readjusted it.

tarrinneal · 2024-05-07T18:08:17Z

I guess, before this gets merged, is this a feature that isn't available in the android sdk? or is it just not implemented properly in the plugin?

LinXunFeng · 2024-05-08T02:46:43Z

I made a reply here(flutter/flutter#147773 (comment)) and adjusted the comment. Please review again.

reidbaker · 2024-05-30T18:48:35Z

It looks like there are some comments here otherwise the PR looks good. Do you plan to update this pr? if not we understand and thank you for the effort you have already spent.

LinXunFeng · 2024-05-31T00:44:12Z

@reidbaker, thanks for your review.

I have previously moved the comments about the Android part to the README of image_picker_android according to @stuartmorgan 's suggestion. Then the PR is waiting for further review and there is no other update.

Now I have rebased the latest code and resolved the conflict.

stuartmorgan-g

LGTM with two small fixes.

…packages#6678)

flutter/packages@910fabb...d8e8e8c 2024-05-31 linxunfeng@yeah.net [image_picker] Adds comment for the limit parameter (flutter/packages#6678) 2024-05-30 jonahwilliams@google.com Revert "Migrate CameraX from SurfaceTexture to SurfaceProducer." (flutter/packages#6838) 2024-05-30 10687576+bparrishMines@users.noreply.github.com [pigeon] Updates `PigeonInstanceMangerApi` to use the shared api channel code in Dart (flutter/packages#6831) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Fixesflutter/flutter#147773

LinXunFeng requested a review from tarrinneal as a code owner May 7, 2024 06:18

github-actionsBot added the p: image_picker label May 7, 2024

tarrinneal reviewed May 7, 2024
View reviewed changes

tarrinneal requested a review from stuartmorgan-g May 8, 2024 09:57

stuartmorgan-g reviewed May 8, 2024
View reviewed changes

Comment threadpackages/image_picker/image_picker/lib/image_picker.dart Outdated

LinXunFeng requested a review from gmackall as a code owner May 9, 2024 01:04

github-actionsBot added the platform-android label May 9, 2024

LinXunFeng force-pushed the image_picker_comment branch 2 times, most recently from 7f80eaf to 5b0a880Compare May 17, 2024 01:05

reidbaker self-requested a review May 30, 2024 18:48

reidbaker approved these changes May 30, 2024
View reviewed changes

LinXunFeng added 5 commits May 31, 2024 08:25

Adds comment for the limit parameter
27ee417

Update comment
fca4bcb

Update comment
d9feefd

Update commnet
a6150df

Resolve conflicts
174414f

LinXunFeng force-pushed the image_picker_comment branch from 5b0a880 to 174414fCompare May 31, 2024 00:28

stuartmorgan-g approved these changes May 31, 2024
View reviewed changes

Comment threadpackages/image_picker/image_picker_android/README.md Outdated
Comment threadpackages/image_picker/image_picker_android/CHANGELOG.md Outdated

LinXunFeng added 2 commits May 31, 2024 21:06

Remove brackets
2e0a102

Update version
2bc3ba5

reidbaker approved these changes May 31, 2024
View reviewed changes

reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label May 31, 2024

auto-submitBot merged commit d8e8e8c into flutter:mainMay 31, 2024

engine-flutter-autoroll mentioned this pull request May 31, 2024
Roll Packages from 910fabb4886b to d8e8e8cee712 (3 revisions) flutter/flutter#149415
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 31, 2024
d8e8e8c[image_picker] Adds comment for the limit parameter (flutter/…
665392c
…packages#6678)

engine-flutter-autoroll mentioned this pull request May 31, 2024
Roll Packages from 910fabb4886b to d8e8e8cee712 (3 revisions) flutter/flutter#149429
Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 31, 2024
d8e8e8c[image_picker] Adds comment for the limit parameter (flutter/…
4d1bccc
…packages#6678)

reidbaker mentioned this pull request Jul 2, 2024
i151188 update espresso dependencies v2 reidbaker/packages#6
Closed
11 tasks

LinXunFeng deleted the image_picker_comment branch October 26, 2024 03:26

creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
[image_picker] Adds comment for the limit parameter (flutter#6678)
9a4e2ab
Fixesflutter/flutter#147773

bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
[image_picker] Adds comment for the limit parameter (flutter#6678)
08e4480
Fixesflutter/flutter#147773

Navigation Menu

Uh oh!

[image_picker] Adds comment for the limit parameter - #6678

[image_picker] Adds comment for the limit parameter#6678
auto-submit[bot] merged 7 commits into
flutter:mainfrom
LinXunFeng:image_picker_comment

LinXunFeng commented May 7, 2024

Uh oh!

tarrinnealMay 7, 2024

Uh oh!

LinXunFengMay 7, 2024

Uh oh!

tarrinneal commented May 7, 2024

Uh oh!

LinXunFeng commented May 8, 2024

Uh oh!

Uh oh!

reidbaker commented May 30, 2024

Uh oh!

LinXunFeng commented May 31, 2024

Uh oh!

stuartmorgan-g left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

LinXunFeng commented May 7, 2024

Pre-launch Checklist

Uh oh!

tarrinnealMay 7, 2024

Choose a reason for hiding this comment

Uh oh!

LinXunFengMay 7, 2024

Choose a reason for hiding this comment

Uh oh!

tarrinneal commented May 7, 2024

Uh oh!

LinXunFeng commented May 8, 2024

Uh oh!

Uh oh!

reidbaker commented May 30, 2024

Uh oh!

LinXunFeng commented May 31, 2024

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants