Skip to content

[google_maps_flutter_platform_interface] Add improvements to BitmapDescriptor API - #6687

Merged
auto-submit[bot] merged 2 commits into
flutter:mainfrom
CodemateLtd:feature/google_maps_flutter_platform_interface_bitmapdescriptor_improvements
May 24, 2024
Merged

[google_maps_flutter_platform_interface] Add improvements to BitmapDescriptor API#6687
auto-submit[bot] merged 2 commits into
flutter:mainfrom
CodemateLtd:feature/google_maps_flutter_platform_interface_bitmapdescriptor_improvements

Conversation

@jokerttu

@jokerttujokerttu commented May 8, 2024

Copy link
Copy Markdown
Contributor

This PR adds improvements to BitmapDescriptor API for google_maps_flutter_platform_interface

  • Adds better support for marker size and scaling behaviour with AssetMapBitmap and BytesMapBitmap.
  • Deprecates BitmapDescriptor.fromAssetImage in favor of BitmapDescriptor.asset and AssetMapBitmap.create.
  • Deprecates BitmapDescriptor.fromBytes in favor of BitmapDescriptor.bytes and BytesMapBitmap

This is prequel PR for: #4055
Containing only changes to google_maps_flutter_platform_interface package.

Follow up PR:s will hold the platform and app-facing plugin implementations.

Linked issue: flutter/flutter#34657

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

stuartmorgan-g
stuartmorgan-g requested changes May 8, 2024
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor notes.

Comment threadpackages/google_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/bitmap.dart Outdated
Comment threadpackages/google_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/bitmap.dart Outdated
Comment threadpackages/google_maps_flutter/google_maps_flutter_platform_interface/test/types/bitmap_test.dart Outdated
Comment threadpackages/google_maps_flutter/google_maps_flutter_platform_interface/test/types/bitmap_test.dart Outdated
@jokerttu
jokerttuforce-pushed the feature/google_maps_flutter_platform_interface_bitmapdescriptor_improvements branch from 04e97b8 to c7a56e4CompareMay 13, 2024 10:45
@jokerttu
jokerttuforce-pushed the feature/google_maps_flutter_platform_interface_bitmapdescriptor_improvements branch 3 times, most recently from 8fa54ff to 2970bbdCompareMay 20, 2024 19:39
@jokerttu
jokerttuforce-pushed the feature/google_maps_flutter_platform_interface_bitmapdescriptor_improvements branch from 2970bbd to a6a49a4CompareMay 23, 2024 06:44
@jokerttu

jokerttu commented May 23, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Just some minor notes.

@stuartmorgan
I’ve made the changes based on your review.

@jokerttu
[google_maps_flutter] Add improvements to BitmapDescriptor API
b3e6acd
@jokerttu
[google_maps_flutter_platform_interface] Documentation improvements
8b51bc0
- Improves public api for width and height values of the MapBitmap
- Also includes small fix to test naming.
@jokerttu
jokerttuforce-pushed the feature/google_maps_flutter_platform_interface_bitmapdescriptor_improvements branch from a6a49a4 to 8b51bc0CompareMay 24, 2024 09:05
stuartmorgan-g
stuartmorgan-g approved these changes May 24, 2024
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label May 24, 2024
@auto-submit
auto-submitBot merged commit 40268e7 into flutter:mainMay 24, 2024
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 27, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 27, 2024
@engine-flutter-autoroll
40268e7[google_maps_flutter_platform_interface] Add improvements to …
28c4702
…BitmapDescriptor API (flutter/packages#6687)
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request May 27, 2024
@engine-flutter-autoroll
Roll Packages from7b423f5tob7bcb4b(7 revisions) (#149136)
a821c21
flutter/packages@7b423f5...b7bcb4b
2024-05-26 engine-flutter-autoroll@skia.org Roll Flutter from cb26a01 to 6564471 (3 revisions) (flutter/packages#6796)
2024-05-26 stuartmorgan@google.com Update Flutter wiki links (flutter/packages#6789)
2024-05-25 engine-flutter-autoroll@skia.org Roll Flutter from 8dd0831 to cb26a01 (12 revisions) (flutter/packages#6794)
2024-05-24 stuartmorgan@google.com [ci] Switch podspec check over to ARM (flutter/packages#6791)
2024-05-24 stuartmorgan@google.com [pointer_interceptor] Add Swift Package Manager support (flutter/packages#6790)
2024-05-24 engine-flutter-autoroll@skia.org Roll Flutter from 8d955cd to 8dd0831 (22 revisions) (flutter/packages#6788)
2024-05-24 joonas.kerttula@codemate.com [google_maps_flutter_platform_interface] Add improvements to BitmapDescriptor API (flutter/packages#6687)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced May 29, 2024
Merged
Merged
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
@engine-flutter-autoroll@victorsanni
Roll Packages from7b423f5tob7bcb4b(7 revisions) (flutter#149136)
3ebc509
flutter/packages@7b423f5...b7bcb4b
2024-05-26 engine-flutter-autoroll@skia.org Roll Flutter from cb26a01 to 6564471 (3 revisions) (flutter/packages#6796)
2024-05-26 stuartmorgan@google.com Update Flutter wiki links (flutter/packages#6789)
2024-05-25 engine-flutter-autoroll@skia.org Roll Flutter from 8dd0831 to cb26a01 (12 revisions) (flutter/packages#6794)
2024-05-24 stuartmorgan@google.com [ci] Switch podspec check over to ARM (flutter/packages#6791)
2024-05-24 stuartmorgan@google.com [pointer_interceptor] Add Swift Package Manager support (flutter/packages#6790)
2024-05-24 engine-flutter-autoroll@skia.org Roll Flutter from 8d955cd to 8dd0831 (22 revisions) (flutter/packages#6788)
2024-05-24 joonas.kerttula@codemate.com [google_maps_flutter_platform_interface] Add improvements to BitmapDescriptor API (flutter/packages#6687)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submitBot pushed a commit that referenced this pull request Jun 4, 2024
@jokerttu
[google_maps_flutter] Custom marker size improvements - platform impls (
dcd8586
#6826)
Platform implementations portion of : #4055
Adds platform handling for new BitmapDescriptor classes `AssetMapBitmap` and `BytesMapBitmap` introduced in #6687
Containing only changes to packages
* `google_maps_flutter_android`
* `google_maps_flutter_ios`
* `google_maps_flutter_web`
Follow up PR will hold the app-facing plugin implementations.
Linked issue: flutter/flutter#34657
@jokerttu
jokerttu deleted the feature/google_maps_flutter_platform_interface_bitmapdescriptor_improvements branch June 5, 2024 12:40
@reidbakerreidbaker mentioned this pull request Jul 2, 2024
Closed
11 tasks
iandis pushed a commit to iandis/flutter-packages that referenced this pull request May 23, 2025
@jokerttu@iandis
gi[google_maps_flutter_platform_interface] Add improvements to Bitmap…
0ca630f
…Descriptor API (flutter#6687)
This PR adds improvements to BitmapDescriptor API for google_maps_flutter_platform_interface
* Adds better support for marker size and scaling behaviour with `AssetMapBitmap` and `BytesMapBitmap`.
* Deprecates `BitmapDescriptor.fromAssetImage` in favor of `BitmapDescriptor.asset` and `AssetMapBitmap.create`.
* Deprecates `BitmapDescriptor.fromBytes` in favor of `BitmapDescriptor.bytes` and `BytesMapBitmap`
This is prequel PR for: flutter#4055
Containing only changes to `google_maps_flutter_platform_interface` package.
Follow up PR:s will hold the platform and app-facing plugin implementations.
Linked issue: flutter/flutter#34657
dko5ki23t pushed a commit to dko5ki23t/google_maps_flutter_improved that referenced this pull request May 24, 2025
@jokerttu
[google_maps_flutter] Custom marker size improvements - platform impl…
8fec8e1
…s (#6826)
Platform implementations portion of : flutter/packages#4055
Adds platform handling for new BitmapDescriptor classes `AssetMapBitmap` and `BytesMapBitmap` introduced in flutter/packages#6687
Containing only changes to packages
* `google_maps_flutter_android`
* `google_maps_flutter_ios`
* `google_maps_flutter_web`
Follow up PR will hold the app-facing plugin implementations.
Linked issue: flutter/flutter#34657
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@jokerttu
[google_maps_flutter_platform_interface] Add improvements to BitmapDe…
0b01421
…scriptor API (flutter#6687)
This PR adds improvements to BitmapDescriptor API for google_maps_flutter_platform_interface * Adds better support for marker size and scaling behaviour with `AssetMapBitmap` and `BytesMapBitmap`.
* Deprecates `BitmapDescriptor.fromAssetImage` in favor of `BitmapDescriptor.asset` and `AssetMapBitmap.create`.
* Deprecates `BitmapDescriptor.fromBytes` in favor of `BitmapDescriptor.bytes` and `BytesMapBitmap`
This is prequel PR for: flutter#4055
Containing only changes to `google_maps_flutter_platform_interface` package.
Follow up PR:s will hold the platform and app-facing plugin implementations.
Linked issue: flutter/flutter#34657
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@jokerttu
[google_maps_flutter] Custom marker size improvements - platform impls (
9d63f53
flutter#6826)
Platform implementations portion of : flutter#4055
Adds platform handling for new BitmapDescriptor classes `AssetMapBitmap` and `BytesMapBitmap` introduced in flutter#6687
Containing only changes to packages
* `google_maps_flutter_android`
* `google_maps_flutter_ios`
* `google_maps_flutter_web`
Follow up PR will hold the app-facing plugin implementations.
Linked issue: flutter/flutter#34657
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@jokerttu
[google_maps_flutter_platform_interface] Add improvements to BitmapDe…
9f341a8
…scriptor API (flutter#6687)
This PR adds improvements to BitmapDescriptor API for google_maps_flutter_platform_interface * Adds better support for marker size and scaling behaviour with `AssetMapBitmap` and `BytesMapBitmap`.
* Deprecates `BitmapDescriptor.fromAssetImage` in favor of `BitmapDescriptor.asset` and `AssetMapBitmap.create`.
* Deprecates `BitmapDescriptor.fromBytes` in favor of `BitmapDescriptor.bytes` and `BytesMapBitmap`
This is prequel PR for: flutter#4055
Containing only changes to `google_maps_flutter_platform_interface` package.
Follow up PR:s will hold the platform and app-facing plugin implementations.
Linked issue: flutter/flutter#34657
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@jokerttu
[google_maps_flutter] Custom marker size improvements - platform impls (
22b91fd
flutter#6826)
Platform implementations portion of : flutter#4055
Adds platform handling for new BitmapDescriptor classes `AssetMapBitmap` and `BytesMapBitmap` introduced in flutter#6687
Containing only changes to packages
* `google_maps_flutter_android`
* `google_maps_flutter_ios`
* `google_maps_flutter_web`
Follow up PR will hold the app-facing plugin implementations.
Linked issue: flutter/flutter#34657
@coderabbitaicoderabbitaiBot mentioned this pull request Aug 20, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: google_maps_flutter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jokerttu@stuartmorgan-g