Skip to content

[google_maps_flutter] Undeprecate BitmapDescriptor methods - #6832

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
CodemateLtd:fix/undeprecates-bitmapdescriptor-methods
May 29, 2024
Merged

[google_maps_flutter] Undeprecate BitmapDescriptor methods#6832
auto-submit[bot] merged 1 commit into
flutter:mainfrom
CodemateLtd:fix/undeprecates-bitmapdescriptor-methods

Conversation

@jokerttu

Copy link
Copy Markdown
Contributor

Undeprecate BitmapDescriptor.fromAssetImage and BitmapDescriptor.fromBytes

  • Undeprecates BitmapDescriptor.fromAssetImage.
  • Undeprecates BitmapDescriptor.fromBytes.
  • Fixes issues with deprecation in version 2.7.0.

The new formats won't be supported until #6826 lands.
Deprecation notices can be re-added after the implementation PRs have landed.

Fixes: flutter/flutter#149183

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

… BitmapDescriptor.fromBytes
* Undeprecates `BitmapDescriptor.fromAssetImage`.
* Undeprecates `BitmapDescriptor.fromBytes`.
* Fixes issues with deprecation in version 2.7.0.

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Sorry I didn't catch this in review; that's one of the pitfalls of having things from the platform interface layer directly re-exposed in the app-facing layer.

@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2024
@auto-submit
auto-submitBot merged commit 28e8afd into flutter:mainMay 29, 2024
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request May 30, 2024
flutter/packages@31d3329...910fabb
2024-05-29 58529443+srujzs@users.noreply.github.com Amend package:web tweaks to allow package:web roll (flutter/packages#6793)
2024-05-29 matanlurey@users.noreply.github.com Migrate `video_player/android` from `SurfaceTexture`->`SurfaceProducer`. (flutter/packages#6456)
2024-05-29 joonas.kerttula@codemate.com [google_maps_flutter] Undeprecate BitmapDescriptor methods (flutter/packages#6832)
2024-05-29 matanlurey@users.noreply.github.com Migrate CameraX from SurfaceTexture to SurfaceProducer. (flutter/packages#6462)
2024-05-29 matanlurey@users.noreply.github.com Migrate `camera/android` from `SurfaceTexture`->`SurfaceProducer`. (flutter/packages#6461)
2024-05-29 katelovett@google.com [dynamic_layouts] Remove the dynamic_layouts package (flutter/packages#6830)
2024-05-29 43054281+camsim99@users.noreply.github.com [camerax] Add notes about Android permissions (flutter/packages#6741)
2024-05-29 43054281+camsim99@users.noreply.github.com [Re-land] Bump legacy all_packages project AGP version to 7.0.0, Gradle version to 7.0.2 (flutter/packages#6742)
2024-05-29 engine-flutter-autoroll@skia.org Roll Flutter from a1a33e6 to c85fa6a (20 revisions) (flutter/packages#6829)
2024-05-29 katelovett@google.com [rfw] Migrate deprecated doc references (flutter/packages#6744)
2024-05-29 katelovett@google.com [flutter_adaptive_scaffold] Migrate MaterialStateProperty to WidgetStateProperty (flutter/packages#6743)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
flutter/packages@31d3329...910fabb
2024-05-29 58529443+srujzs@users.noreply.github.com Amend package:web tweaks to allow package:web roll (flutter/packages#6793)
2024-05-29 matanlurey@users.noreply.github.com Migrate `video_player/android` from `SurfaceTexture`->`SurfaceProducer`. (flutter/packages#6456)
2024-05-29 joonas.kerttula@codemate.com [google_maps_flutter] Undeprecate BitmapDescriptor methods (flutter/packages#6832)
2024-05-29 matanlurey@users.noreply.github.com Migrate CameraX from SurfaceTexture to SurfaceProducer. (flutter/packages#6462)
2024-05-29 matanlurey@users.noreply.github.com Migrate `camera/android` from `SurfaceTexture`->`SurfaceProducer`. (flutter/packages#6461)
2024-05-29 katelovett@google.com [dynamic_layouts] Remove the dynamic_layouts package (flutter/packages#6830)
2024-05-29 43054281+camsim99@users.noreply.github.com [camerax] Add notes about Android permissions (flutter/packages#6741)
2024-05-29 43054281+camsim99@users.noreply.github.com [Re-land] Bump legacy all_packages project AGP version to 7.0.0, Gradle version to 7.0.2 (flutter/packages#6742)
2024-05-29 engine-flutter-autoroll@skia.org Roll Flutter from a1a33e6 to c85fa6a (20 revisions) (flutter/packages#6829)
2024-05-29 katelovett@google.com [rfw] Migrate deprecated doc references (flutter/packages#6744)
2024-05-29 katelovett@google.com [flutter_adaptive_scaffold] Migrate MaterialStateProperty to WidgetStateProperty (flutter/packages#6743)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@jokerttu
jokerttu deleted the fix/undeprecates-bitmapdescriptor-methods branch June 5, 2024 12:40
iandis pushed a commit to iandis/flutter-packages that referenced this pull request May 23, 2025
)
Undeprecate BitmapDescriptor.fromAssetImage and BitmapDescriptor.fromBytes
* Undeprecates `BitmapDescriptor.fromAssetImage`.
* Undeprecates `BitmapDescriptor.fromBytes`.
* Fixes issues with deprecation in version 2.7.0.
The new formats won't be supported until flutter#6826 lands.
Deprecation notices can be re-added after the implementation PRs have landed.
Fixes: flutter/flutter#149183
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
)
Undeprecate BitmapDescriptor.fromAssetImage and BitmapDescriptor.fromBytes
* Undeprecates `BitmapDescriptor.fromAssetImage`.
* Undeprecates `BitmapDescriptor.fromBytes`.
* Fixes issues with deprecation in version 2.7.0.
The new formats won't be supported until flutter#6826 lands.
Deprecation notices can be re-added after the implementation PRs have landed.
Fixes: flutter/flutter#149183
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
)
Undeprecate BitmapDescriptor.fromAssetImage and BitmapDescriptor.fromBytes
* Undeprecates `BitmapDescriptor.fromAssetImage`.
* Undeprecates `BitmapDescriptor.fromBytes`.
* Fixes issues with deprecation in version 2.7.0.
The new formats won't be supported until flutter#6826 lands.
Deprecation notices can be re-added after the implementation PRs have landed.
Fixes: flutter/flutter#149183
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: google_maps_flutter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Google_maps]After change BitmapDescriptor.fromBytes to BitmapDescriptor.bytes app crash

2 participants

@jokerttu@stuartmorgan-g