[pigeon] removes restriction on number of custom types per file by tarrinneal · Pull Request #6840 · flutter/packages

tarrinneal · 2024-05-31T05:17:27Z

removes restriction on number of custom types per file (except for gobject).

also fixes bug in objc with multiple enums in a class

resolves a couple other minor issues:
fixesflutter/flutter#150385
fixesflutter/flutter#150108
work toward flutter/flutter#152916

…-3-the-code-wars

stuartmorgan-g · 2024-08-05T17:54:53Z

 /// The name of the codec serializer.
 const String _codecSerializerName = 'PigeonCodecSerializer';

+const String _overflowClassName = '${varNamePrefix}CodecOverflow';


Could we put this class in an internal nested namespace instead of giving it a prefix name? We shouldn't start a type with __ in C++, as that's a reserved name group.

I changed the prefix, let me know if that is enough or if I need to internalize it still.

It would be more idiomatic C++ to put things that have to be in the header but aren't intended for direct use in an internal namespace, but it's not a big deal, so we can leave this as-is.

stuartmorgan-g · 2024-08-08T16:42:42Z

 /// The name of the codec serializer.
 const String _codecSerializerName = 'PigeonCodecSerializer';

+const String _overflowClassName = '${varNamePrefix}CodecOverflow';


It would be more idiomatic C++ to put things that have to be in the header but aren't intended for direct use in an internal namespace, but it's not a big deal, so we can leave this as-is.

…-3-the-code-wars

stuartmorgan-g

LGTM!

…le (flutter/packages#6840)

flutter/packages@f7b1256...d9a6de8 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/camera/camera_android/android (flutter/packages#7371) 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [path_provider]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/path_provider/path_provider_android/android (flutter/packages#7376) 2024-08-12 tarrinneal@gmail.com [pigeon] removes restriction on number of custom types per file (flutter/packages#6840) 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 2.0.0 to 2.0.10 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#7370) 2024-08-12 fertrig@gmail.com [shared_preferences] Fixes get-all when suite name is used (flutter/packages#7335) 2024-08-12 mhvdijk@gmail.com [flutter_adaptive_scaffold] Add expanded and extra large breakpoints (flutter/packages#7300) 2024-08-12 engine-flutter-autoroll@skia.org Manual roll Flutter from b12d861 to 9b84701 (8 revisions) (flutter/packages#7366) 2024-08-10 engine-flutter-autoroll@skia.org Manual roll Flutter from 76107bd to b12d861 (14 revisions) (flutter/packages#7358) 2024-08-09 tarrinneal@gmail.com [shared_preferences] fix cast error and mutable list error with `getStringList` (flutter/packages#7355) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…ter#6840) removes restriction on number of custom types per file (except for gobject). also fixes bug in objc with multiple enums in a class resolves a couple other minor issues: fixesflutter/flutter#150385fixesflutter/flutter#150108 work toward flutter/flutter#152916

github-actionsBot added p: pigeon platform-android platform-ios platform-macos platform-windows labels May 31, 2024

tarrinneal force-pushed the custom-codecs-3-the-code-wars branch 2 times, most recently from 7b759db to a415e7eCompare June 7, 2024 04:55

tarrinneal mentioned this pull request Jun 20, 2024
[pigeon] Issue in Java generated code when there is multiple Enums flutter/flutter#150108
Closed

tarrinneal force-pushed the custom-codecs-3-the-code-wars branch from a415e7e to 63d789cCompare June 20, 2024 15:34

tarrinneal requested a review from stuartmorgan-g August 1, 2024 04:06

github-actionsBot added the platform-linux label Aug 2, 2024

add test structure (probably not the best way)
e30c95c

tarrinneal force-pushed the custom-codecs-3-the-code-wars branch from 28392d0 to e30c95cCompare August 3, 2024 03:15

tarrinneal added 2 commits August 2, 2024 21:03

fix swift and windows bugs, more add overflow logic to ast
832a7cc

add another enum to integration tests, fix ios bug
0f87cac

tarrinneal force-pushed the custom-codecs-3-the-code-wars branch from 56aab69 to 0f87cacCompare August 3, 2024 12:28

tarrinneal added 6 commits August 5, 2024 01:09

learning about gobject
1018a36

missed one
e8edcf0

format
f738db2

another method method cb method
0f46168

Merge branch 'main' of github.com:flutter/packages into custom-codecs…
0fc17df
…-3-the-code-wars

another another
c4df8ca

tarrinneal changed the title ~~Custom codecs 3 the code wars~~[pigeon] removes restriction on number of custom types per fileAug 5, 2024

tarrinneal marked this pull request as ready for review August 5, 2024 14:17

tarrinneal requested review from LouiseHsu and hellohuanlin as code owners August 5, 2024 14:17

stuartmorgan-g requested changes Aug 5, 2024
View reviewed changes

tarrinneal mentioned this pull request Aug 6, 2024
[pigeon] linux generator only supports 123 total custom types flutter/flutter#152916
Open

change internal prefix names and add more tests to avoid conflicts
3800627

tarrinneal force-pushed the custom-codecs-3-the-code-wars branch from 6fc9e48 to 3800627Compare August 6, 2024 15:03

tarrinneal added 2 commits August 6, 2024 10:11

update unit tests
c634a02

missed var name
736a5ab

tarrinneal requested a review from stuartmorgan-g August 6, 2024 17:47

changelog
ae5419c

huycozy mentioned this pull request Aug 8, 2024
[Pigeon]Issue in objc generated code when there is multiple Enums flutter/flutter#153072
Closed

stuartmorgan-g requested changes Aug 8, 2024
View reviewed changes

nits
09c47de

tarrinneal requested a review from stuartmorgan-g August 12, 2024 15:00

Merge branch 'main' of github.com:flutter/packages into custom-codecs…
78f4040
…-3-the-code-wars

stuartmorgan-g approved these changes Aug 12, 2024
View reviewed changes

fix links for gobject issue
38304ef

tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 12, 2024

auto-submitBot merged commit cb0683e into flutter:mainAug 12, 2024

engine-flutter-autoroll mentioned this pull request Aug 12, 2024
Roll Packages from f7b12561aeb6 to d9a6de802e1f (9 revisions) flutter/flutter#153291
Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 12, 2024
cb0683e[pigeon] removes restriction on number of custom types per fi…
2405024
…le (flutter/packages#6840)

Uh oh!

Conversation

tarrinneal commented May 31, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-gAug 5, 2024

Choose a reason for hiding this comment

Uh oh!

tarrinnealAug 6, 2024

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-gAug 8, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-gAug 8, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tarrinneal commented May 31, 2024•
edited
Loading