[video_player] Try to address test flake by stuartmorgan-g · Pull Request #6899 · flutter/packages

stuartmorgan-g · 2024-06-10T17:09:44Z

This attempts to address two sources of flake:

A test that playing doesn't continue past the duration flakily fails, at least on Android, with a position a small amount past the duration. This seems like an unexpected library behavior that we wouldn't want to expose to clients, so rather than change the test, this makes the logic that updates the Value clamp the position to the duration.
A test that asset videos play has been restructured to actually wait for the future that should start playing to complete before checking whether it's playing. The test was previously not actually waiting for anything other than animations to complete, and there's no reason the placeholder layout couldn't have completed before the asset loaded. The fact that the test was already disabled for iOS is strong evidence that the flake we are seeing on Android is a problem with the test itself, so hopefully this addresses both platforms.

Pre-launch Checklist

This attempts to address two sources of flake: - A test that playing doesn't continue past the duration flakily fails, at least on Android, with a position a small amount past the duration. This seems like an unexpected library behavior that we wouldn't want to expose to clients, so rather than change the test, this makes the logic that updates the `Value` clamp the position to the duration. - A test that asset videos play has been restructured to actually wait for the future that should start playing to complete before checking whether it's playing. The test was previously not actually waiting for anything other than animations to complete, and there's no reason the placeholder layout couldn't have completed before the asset loaded. The fact that the test was already disabled for iOS is strong evidence that the flake we are seeing on Android is a problem with the test itself, so hopefully this addresses both platforms. Fixesflutter/flutter#86915

stuartmorgan-g · 2024-06-10T17:10:05Z

Since this is speculative I'll re-run the presubmit tests a few times at least to get better signal.

bparrishMines

LGTM

bparrishMines · 2024-06-10T18:04:47Z

+ // The underlying native implementation on some platforms sometimes reports
+ // a position slightly past the reported max duration. Clamp to the duration
+ // to insulate clients from this behavior.
+ if (position.compareTo(value.duration) > 0) {


nit: Would this not be easier to read as position > value.duration.

Weird, for some reason I thought that didn't work. Yes, definitely much better that way.

stuartmorgan-g · 2024-06-10T21:21:12Z

I'm going to land this on red because so much of the red today has been one of these two tests flaking.

flutter/packages@e95fe4a...8c24fd4 2024-06-11 engine-flutter-autoroll@skia.org Roll Flutter from 32081aa to 14df7be (21 revisions) (flutter/packages#6907) 2024-06-11 luthien256@gmail.com Ensure each code block specified in the markdown uses its own ScrollController. (flutter/packages#6904) 2024-06-10 stuartmorgan@google.com [video_player] Try to address test flake (flutter/packages#6899) 2024-06-10 stuartmorgan@google.com [ci] Allow `platform` references (flutter/packages#6903) 2024-06-10 magder@google.com Change CODEOWNERS for metrics_center (flutter/packages#6892) 2024-06-10 mit@google.com Remove package:platform source (flutter/packages#6898) 2024-06-10 engine-flutter-autoroll@skia.org Roll Flutter from fc19ecf to 32081aa (9 revisions) (flutter/packages#6896) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

This attempts to address two sources of flake: - A test that playing doesn't continue past the duration flakily fails, at least on Android, with a position a small amount past the duration. This seems like an unexpected library behavior that we wouldn't want to expose to clients, so rather than change the test, this makes the logic that updates the `Value` clamp the position to the duration. - A test that asset videos play has been restructured to actually wait for the future that should start playing to complete before checking whether it's playing. The test was previously not actually waiting for anything other than animations to complete, and there's no reason the placeholder layout couldn't have completed before the asset loaded. The fact that the test was already disabled for iOS is strong evidence that the flake we are seeing on Android is a problem with the test itself, so hopefully this addresses both platforms. Fixesflutter/flutter#86915

stuartmorgan-g requested a review from bparrishMines June 10, 2024 17:09

stuartmorgan-g requested a review from tarrinneal as a code owner June 10, 2024 17:09

github-actionsBot added the p: video_player label Jun 10, 2024

backticks
f8fa0da

bparrishMines approved these changes Jun 10, 2024
View reviewed changes

Simplify check
6cf07e3

stuartmorgan-g mentioned this pull request Jun 10, 2024
[video_player] Very frequent flake on Android emulators flutter/flutter#141145
Open

stuartmorgan-g added autosubmit Merge PR when tree becomes green via auto submit App emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label. labels Jun 10, 2024

auto-submitBot merged commit 61ed839 into flutter:mainJun 10, 2024

engine-flutter-autoroll mentioned this pull request Jun 11, 2024
Roll Packages from e95fe4a0cd3a to 31408205ff9a (6 revisions) flutter/flutter#150046
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 11, 2024
61ed839[video_player] Try to address test flake (flutter/packages#6899)
fb3b3fa

engine-flutter-autoroll mentioned this pull request Jun 11, 2024
Roll Packages from e95fe4a0cd3a to 8c24fd4ec947 (7 revisions) flutter/flutter#150051
Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 11, 2024
61ed839[video_player] Try to address test flake (flutter/packages#6899)
d8ae56a

reidbaker mentioned this pull request Jul 2, 2024
i151188 update espresso dependencies v2 reidbaker/packages#6
Closed
11 tasks

Navigation Menu

Uh oh!

[video_player] Try to address test flake - #6899

[video_player] Try to address test flake#6899
auto-submit[bot] merged 3 commits into
flutter:mainfrom
stuartmorgan-g:video-player-flake

stuartmorgan-g commented Jun 10, 2024

Uh oh!

stuartmorgan-g commented Jun 10, 2024

Uh oh!

bparrishMines left a comment

Uh oh!

bparrishMinesJun 10, 2024

Uh oh!

stuartmorgan-gJun 10, 2024

Uh oh!

stuartmorgan-g commented Jun 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

stuartmorgan-g commented Jun 10, 2024

Pre-launch Checklist

Uh oh!

stuartmorgan-g commented Jun 10, 2024

Uh oh!

bparrishMines left a comment

Choose a reason for hiding this comment

Uh oh!

bparrishMinesJun 10, 2024

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-gJun 10, 2024

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Jun 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants