[go_router] Fix Popping state and re-rendering scaffold at the same time doesn't update the URL on web #150312

[ahyangnb]

Change the 3 file palce, because issue #150312

The reason for the issue is when call counterStream.increment(); will notify notifyListeners() of StreamListener, and finally affect _handleRouteInformationProviderNotification of _RouterState in packages/flutter/lib/src/widgets/router.dart.

When pop should not call _handleRouteInformationProviderNotification otherwise will be path wrong.
because the value of GoRouteInformationProvider is not the latest.

solution:
always make the value of GoRouteInformationProvider knew the latest RouteInformation[but not to do notifyListeners()].

i don't know if adding pop to NavigatingType is reasonable, if any place needs to be changed please tell me.

Pre-launch Checklist

i was run shell_route_test.dart to check the change I am making, all existing and new tests are passing.

• I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
• I read the [Tree Hygiene] page, which explains my responsibilities.
• I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
• I signed the [CLA].
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I [linked to at least one issue that this PR fixes] in the description above.
• I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
• I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is [test-exempt].
• All existing and new tests are passing.

[flutter-dashboard]

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[ahyangnb]

Is this a big deal?

[ahyangnb]

Is this a big deal?

this email is my new computer set, i was forget to set, but know, i've set.

[chunhtai]

This may not work if the routerDelegate.pop removes pageless route such as dialog or modalbottomroute.

[ahyangnb]

I've try use go_router 14.2.0 of pub.dev and run demo follwing code also not work, I thought it was normal, see the picture above.

if misundestand please tell me how reproduce it.

demo code:

import'dart:async';
import'package:flutter/material.dart';
import'package:go_router/go_router.dart';
classCounterStream {
int _counter =0;
final _streamController =StreamController<int>.broadcast();
Stream<int> get stateStream => _streamController.stream.asBroadcastStream();
voidincrement() {
_streamController.sink.add(++_counter);
}
Future<void> delayedRerender() async {
increment();
increment();
}
voiddispose() {
_streamController.close();
}
}
finalCounterStream counterStream =CounterStream();
classStreamListenerextendsChangeNotifier {
StreamListener(Stream<dynamic> stream) {
notifyListeners();
_subscription = stream.asBroadcastStream().listen((_) {
notifyListeners();
});
}
latefinalStreamSubscription<dynamic> _subscription;
@overridevoidnotifyListeners() {
super.notifyListeners();
print('refreshing the router');
}
@overridevoiddispose() {
_subscription.cancel();
super.dispose();
}
}
voidmain() {
GoRouter.optionURLReflectsImperativeAPIs =true;
WidgetsFlutterBinding.ensureInitialized();
runApp(constMyApp());
}
classMyAppextendsStatefulWidget {
constMyApp({super.key});
@overrideState<MyApp> createState() =>_MyAppState();
}
final _rootNavigatorKey =GlobalKey<NavigatorState>();
finalGoRouter _router =GoRouter(
initialLocation:'/',
navigatorKey: _rootNavigatorKey,
refreshListenable:StreamListener(counterStream.stateStream),
routes:<RouteBase>[
ShellRoute(
builder: (context, state, child) {
returnGenericPage(child: child);
},
routes: [
GoRoute(
path:'/',
builder: (BuildContext context, GoRouterState state) =>constGenericPage(showPushButton:true, path:'a'),
routes: [
GoRoute(
path:'a',
name:'a',
builder: (BuildContext context, GoRouterState state) =>constGenericPage(showPushButton:true, path:'b'),
routes: [
GoRoute(
path:'b',
name:'b',
builder: (BuildContext context, GoRouterState state) =>constGenericPage(showBackButton:true),
),
],
),
],
),
],
),
],
);
class_MyAppStateextendsState<MyApp> {
lateStreamSubscription<int> _stateSubscription;
int _currentState =0;
@overridevoidinitState() {
super.initState();
_stateSubscription = counterStream.stateStream.listen((state) {
setState(() {
_currentState = state;
});
});
}
@overridevoiddispose() {
_stateSubscription.cancel();
super.dispose();
}
@overrideWidgetbuild(BuildContext context) {
returnMaterialApp.router(
title:'Flutter Demo',
theme:ThemeData(
primarySwatch:Colors.blue,
),
routerConfig: _router,
);
}
}
classDialogTestextendsStatelessWidget {
constDialogTest({super.key});
@overrideWidgetbuild(BuildContext context) {
returnMaterial(
type:MaterialType.transparency,
child:Center(
child:Container(
color:Colors.white,
width:300,
height:300,
alignment:Alignment.center,
child:Column(
children: ['Navigator::pop', 'GoRouter::pop'].map((e) {
returnInkWell(
child:Row(children: [
Text(e),
constIcon(Icons.close),
]),
onTap: () {
if (e =='GoRouter::pop') {
GoRouter.of(context).pop();
} else {
Navigator.of(context).pop();
}
},
);
}).toList(),
),
),
),
);
}
}
classGenericPageextendsStatefulWidget {
finalWidget? child;
finalbool showPushButton;
finalbool showBackButton;
finalString? path;
constGenericPage({
this.child,
Key? key,
this.showPushButton =false,
this.showBackButton =false,
this.path,
}) :super(key: key ??constValueKey<String>('ShellWidget'));
@overrideState<GenericPage> createState() =>_GenericPageState();
}
class_GenericPageStateextendsState<GenericPage> {
lateStreamSubscription<int> _stateSubscription;
int _currentState =0;
@overridevoidinitState() {
super.initState();
_stateSubscription = counterStream.stateStream.listen((state) {
setState(() {
_currentState = state;
});
});
}
@overridevoiddispose() {
_stateSubscription.cancel();
super.dispose();
}
@overrideWidgetbuild(BuildContext context) {
returnScaffold(
appBar: widget.child !=null?AppBar(
title:Text('Count: $_currentState'),
actions: [
TextButton(
onPressed: () {
showDialog(
context: context,
builder: (context) {
returnDialogTest();
},
);
},
child:constText('dialog1'),
),
TextButton(
onPressed: () {
showModalBottomSheet(
context: context,
builder: (context) {
returnDialogTest();
},
);
},
child:constText('dialog2'),
)
],
)
:null,
body:_buildWidget(context));
}
Widget_buildWidget(BuildContext context) {
if (widget.child !=null) {
return widget.child!;
}
if (widget.showBackButton) {
returnTextButton(
onPressed: () {
// WHEN THE USER PRESSES THIS BUTTON, THE URL// DOESN'T CHANGE, BUT THE SCREEN DOES
counterStream
.increment(); // <- when removing this line the issue is goneGoRouter.of(context).pop();
},
child:constText('<- Go Back'),
);
}
if (widget.showPushButton) {
returnTextButton(
onPressed: () {
GoRouter.of(context).goNamed(widget.path!);
},
child:constText('Push ->'),
);
}
returnText('Current state: $_currentState');
}
}

[chunhtai]

I have not looked into it more, but we can't guarantee the goRouter.pop will pop the last routematch.

[ahyangnb]

we can guarantee the goRouter.pop will pop the last routematch, because we just mark the RouteInformation in GoRouteInformationProvider, the pop will use navigatorKey to pop the router and use currentConfiguration of GoRouterDelegate to check last router and we have no change currentConfiguration GoRouterDelegate value.

pop of NavigatorState won't be affected either.

[ahyangnb]

value of GoRouteInformationProvider is self-management, will not use it outside.

so you can check the GoRouteInformationProvider in packages/go_router/lib/src/information_provider.dart

[chunhtai]

What I meant is that the pop can pop a dialog instead of the page. It is also possible that the page can contain localhistory, such as open drawer.

[chunhtai]

This seemed not addressed?

[ahyangnb]

I will continue to look into this.

[chunhtai]

Hi @ahyangnb Are you still planning on coming back to this pr?

[ahyangnb]

Hi @ahyangnb Are you still planning on coming back to this pr?
yes

[chunhtai]

Hi @ahyangnb I am going to close this pr for now, feel free to reopen once you have time

[ahyangnb]

hi, can we open it again? this pr is already tested by myself and no mistake with the code view