Skip to content

[ci] version_check_command now checks markdown of first CHANGELOG line. - #7266

Merged
auto-submit[bot] merged 5 commits into
flutter:mainfrom
ditman:fix-gmaps-web-changelog-typo
Aug 1, 2024
Merged

[ci] version_check_command now checks markdown of first CHANGELOG line.#7266
auto-submit[bot] merged 5 commits into
flutter:mainfrom
ditman:fix-gmaps-web-changelog-typo

Conversation

@ditman

@ditmanditman commented Jul 31, 2024

Copy link
Copy Markdown
Member

This PR:

  • Modifies the version_check_command test so it checks the leading markdown of the first line of a CHANGELOG file, to ensure it's '##'.
  • Fixes the CHANGELOG in two packages that were allowed by the tool before this fix:
    • google_maps_flutter_web
    • interactive_media_ads

Issues

Fixesflutter/flutter#152638

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman

ditman commented Jul 31, 2024

Copy link
Copy Markdown
MemberAuthor

(It's cool that this PR found the same issue in another package)

Use 'fixes a typo' instead of 'updates a typo'...

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ditman

ditman commented Jul 31, 2024

Copy link
Copy Markdown
MemberAuthor

Adding autosubmit to cheer up the pre-submit process :P

(PS: p: interactive_media_ads is not a label? /cc @stuartmorgan)

@ditmanditman added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 31, 2024
@auto-submit

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/packages/7266, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_5 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 31, 2024
@ditmanditman added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 31, 2024
@ditman

Copy link
Copy Markdown
MemberAuthor

Please try again, my dear Mac_arm64 ios_platform_tests_shard_5 master bot!

@ditman

Copy link
Copy Markdown
MemberAuthor

(Nah, flakes flaking, I'll try to land this later tonight when CI is better rested :/)

@auto-submit

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/packages/7266, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_5 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 31, 2024
@ditmanditman added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 1, 2024
@ditman

Copy link
Copy Markdown
MemberAuthor

Autosubmit bot, do your thang, all is 🟢

@auto-submit
auto-submitBot merged commit f8fbcdb into flutter:mainAug 1, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 1, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 1, 2024
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Aug 1, 2024
flutter/packages@46a712f...27896d1
2024-08-01 160153899+alexrabin-sentracam@users.noreply.github.com [local_auth_darwin] macOS Support (flutter/packages#6267)
2024-08-01 engine-flutter-autoroll@skia.org Manual roll Flutter from 4d12197 to f817e51 (7 revisions) (flutter/packages#7270)
2024-08-01 ditman@gmail.com [ci] version_check_command now checks markdown of first CHANGELOG line. (flutter/packages#7266)
2024-08-01 engine-flutter-autoroll@skia.org Manual roll Flutter from 031dc3d to 4d12197 (12 revisions) (flutter/packages#7259)
2024-07-31 louisehsu@google.com [in_app_purchase_storekit] convert TranslatorTests to swift (flutter/packages#7232)
2024-07-31 rexios@rexios.dev [google_maps_flutter_web] Migrate to `google_maps: 8.0.0` (flutter/packages#7077)
2024-07-31 stuartmorgan@google.com [tool] Run pre_publish.dart before publish --dry-run (flutter/packages#7258)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
flutter/packages@46a712f...27896d1
2024-08-01 160153899+alexrabin-sentracam@users.noreply.github.com [local_auth_darwin] macOS Support (flutter/packages#6267)
2024-08-01 engine-flutter-autoroll@skia.org Manual roll Flutter from 4d12197 to f817e51 (7 revisions) (flutter/packages#7270)
2024-08-01 ditman@gmail.com [ci] version_check_command now checks markdown of first CHANGELOG line. (flutter/packages#7266)
2024-08-01 engine-flutter-autoroll@skia.org Manual roll Flutter from 031dc3d to 4d12197 (12 revisions) (flutter/packages#7259)
2024-07-31 louisehsu@google.com [in_app_purchase_storekit] convert TranslatorTests to swift (flutter/packages#7232)
2024-07-31 rexios@rexios.dev [google_maps_flutter_web] Migrate to `google_maps: 8.0.0` (flutter/packages#7077)
2024-07-31 stuartmorgan@google.com [tool] Run pre_publish.dart before publish --dry-run (flutter/packages#7258)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
flutter/packages@46a712f...27896d1
2024-08-01 160153899+alexrabin-sentracam@users.noreply.github.com [local_auth_darwin] macOS Support (flutter/packages#6267)
2024-08-01 engine-flutter-autoroll@skia.org Manual roll Flutter from 4d12197 to f817e51 (7 revisions) (flutter/packages#7270)
2024-08-01 ditman@gmail.com [ci] version_check_command now checks markdown of first CHANGELOG line. (flutter/packages#7266)
2024-08-01 engine-flutter-autoroll@skia.org Manual roll Flutter from 031dc3d to 4d12197 (12 revisions) (flutter/packages#7259)
2024-07-31 louisehsu@google.com [in_app_purchase_storekit] convert TranslatorTests to swift (flutter/packages#7232)
2024-07-31 rexios@rexios.dev [google_maps_flutter_web] Migrate to `google_maps: 8.0.0` (flutter/packages#7077)
2024-07-31 stuartmorgan@google.com [tool] Run pre_publish.dart before publish --dry-run (flutter/packages#7258)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…e. (flutter#7266)
This PR:
* Modifies the `version_check_command` test so it checks the leading markdown of the first line of a CHANGELOG file, to ensure it's `'##'`.
* Fixes the CHANGELOG in two packages that were allowed by the tool before this fix:
* google_maps_flutter_web
* interactive_media_ads
## Issues
Fixesflutter/flutter#152638
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
…e. (flutter#7266)
This PR:
* Modifies the `version_check_command` test so it checks the leading markdown of the first line of a CHANGELOG file, to ensure it's `'##'`.
* Fixes the CHANGELOG in two packages that were allowed by the tool before this fix:
* google_maps_flutter_web
* interactive_media_ads
## Issues
Fixesflutter/flutter#152638
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: google_maps_flutterplatform-androidplatform-iosplatform-web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[packages] [ci] Validation script allows wrong entry in CHANGELOG file.

2 participants

@ditman@stuartmorgan-g