Uh oh!
There was an error while loading. Please reload this page.
[shared_preferences] fix stringlist bug - #7268
Merged
Merged
Conversation
stuartmorgan-g
requested changes
Aug 1, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 2, 2024
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 2, 2024
auto-submitBot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 2, 2024
flutter/packages@27896d1...cc9ff47 2024-08-02 rexios@rexios.dev [tool] Add note about clang version used in CI to tool readme (flutter/packages#7273) 2024-08-02 ditman@gmail.com [ci] Re-enable google_maps_flutter_web integration tests. (flutter/packages#7269) 2024-08-01 ditman@gmail.com [web] Update package:web to ">=0.5.1 <2.0.0" (flutter/packages#7202) 2024-08-01 tobias@leafnode.se [go_router] Documentation for StatefulShellRoute (flutter/packages#6308) 2024-08-01 stuartmorgan@google.com [google_maps_flutter] Switch Android examples to TLHC (flutter/packages#7282) 2024-08-01 engine-flutter-autoroll@skia.org Manual roll Flutter from f817e51 to e2e4398 (5 revisions) (flutter/packages#7276) 2024-08-01 stuartmorgan@google.com [various] Clean up C++ formatting (flutter/packages#7272) 2024-08-01 tarrinneal@gmail.com [shared_preferences] fix stringlist bug (flutter/packages#7268) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
flutter/packages@27896d1...cc9ff47 2024-08-02 rexios@rexios.dev [tool] Add note about clang version used in CI to tool readme (flutter/packages#7273) 2024-08-02 ditman@gmail.com [ci] Re-enable google_maps_flutter_web integration tests. (flutter/packages#7269) 2024-08-01 ditman@gmail.com [web] Update package:web to ">=0.5.1 <2.0.0" (flutter/packages#7202) 2024-08-01 tobias@leafnode.se [go_router] Documentation for StatefulShellRoute (flutter/packages#6308) 2024-08-01 stuartmorgan@google.com [google_maps_flutter] Switch Android examples to TLHC (flutter/packages#7282) 2024-08-01 engine-flutter-autoroll@skia.org Manual roll Flutter from f817e51 to e2e4398 (5 revisions) (flutter/packages#7276) 2024-08-01 stuartmorgan@google.com [various] Clean up C++ formatting (flutter/packages#7272) 2024-08-01 tarrinneal@gmail.com [shared_preferences] fix stringlist bug (flutter/packages#7268) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
flutter/packages@27896d1...cc9ff47 2024-08-02 rexios@rexios.dev [tool] Add note about clang version used in CI to tool readme (flutter/packages#7273) 2024-08-02 ditman@gmail.com [ci] Re-enable google_maps_flutter_web integration tests. (flutter/packages#7269) 2024-08-01 ditman@gmail.com [web] Update package:web to ">=0.5.1 <2.0.0" (flutter/packages#7202) 2024-08-01 tobias@leafnode.se [go_router] Documentation for StatefulShellRoute (flutter/packages#6308) 2024-08-01 stuartmorgan@google.com [google_maps_flutter] Switch Android examples to TLHC (flutter/packages#7282) 2024-08-01 engine-flutter-autoroll@skia.org Manual roll Flutter from f817e51 to e2e4398 (5 revisions) (flutter/packages#7276) 2024-08-01 stuartmorgan@google.com [various] Clean up C++ formatting (flutter/packages#7272) 2024-08-01 tarrinneal@gmail.com [shared_preferences] fix stringlist bug (flutter/packages#7268) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
I tested this a few different ways and there was never any savings by not casting when the list is already `List<String>`. fixesflutter/flutter#152607
bisor0627 pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
I tested this a few different ways and there was never any savings by not casting when the list is already `List<String>`. fixesflutter/flutter#152607
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested this a few different ways and there was never any savings by not casting when the list is already
List<String>.fixesflutter/flutter#152607