Skip to content

[google_maps_flutter] Disable setAndGetScrollPosition on iOS - #7609

Merged
auto-submit[bot] merged 3 commits into
mainfrom
maps-ios-disable-setandgetscrollposition
Sep 9, 2024
Merged

[google_maps_flutter] Disable setAndGetScrollPosition on iOS#7609
auto-submit[bot] merged 3 commits into
mainfrom
maps-ios-disable-setandgetscrollposition

Conversation

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

Disables tests that are suddenly flaking very badly and keeping the tree closed.

Tracked in flutter/flutter#154826

@bparrishMinesbparrishMines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-gstuartmorgan-g added emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label. autosubmit Merge PR when tree becomes green via auto submit App labels Sep 9, 2024
@auto-submit
auto-submitBot merged commit 8d1acdd into mainSep 9, 2024
@auto-submit
auto-submitBot deleted the maps-ios-disable-setandgetscrollposition branch September 9, 2024 16:41
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Sep 10, 2024
flutter/packages@b4e0fc1...bb53e5d
2024-09-09 magder@google.com [ci] Increase deprecation check minimum to macOS 14 (flutter/packages#7544)
2024-09-09 paulberry@google.com [camerax] Ignore new `unreachable_switch_default` warning. (flutter/packages#7592)
2024-09-09 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_platform_interface] Split `CameraUpdate` into derived classes to use structured data (flutter/packages#7596)
2024-09-09 stuartmorgan@google.com [google_maps_flutter] Disable setAndGetScrollPosition on iOS (flutter/packages#7609)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…#7609)
Disables tests that are suddenly flaking very badly and keeping the tree closed.
Tracked in flutter/flutter#154826
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
…#7609)
Disables tests that are suddenly flaking very badly and keeping the tree closed.
Tracked in flutter/flutter#154826
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit AppemergencyOverride tree-status signal (land even with closed tree), combine with the autosubmit label.p: webview_flutterplatform-ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@stuartmorgan-g@bparrishMines