Skip to content

[google_maps_flutter] Add ability to animate camera with duration - #7648

Merged
auto-submit[bot] merged 2 commits into
flutter:mainfrom
CodemateLtd:feature/animate-camera-duration
Mar 25, 2025
Merged

[google_maps_flutter] Add ability to animate camera with duration#7648
auto-submit[bot] merged 2 commits into
flutter:mainfrom
CodemateLtd:feature/animate-camera-duration

Conversation

@jokerttu

@jokerttujokerttu commented Sep 14, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Adds ability to configure camera animation duration on Android and iOS.

Resolves#39810
Resolves#44284

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jokerttu
jokerttuforce-pushed the feature/animate-camera-duration branch from fbf20bc to 68e52dfCompareSeptember 14, 2024 12:57
@jokerttujokerttu changed the title [google_maps_flutter] add ability to animate camera with duration[google_maps_flutter] Add ability to animate camera with durationSep 14, 2024
@jokerttu
jokerttuforce-pushed the feature/animate-camera-duration branch from 68e52df to 2c8caf1CompareSeptember 15, 2024 09:03
@jokerttu
jokerttuforce-pushed the feature/animate-camera-duration branch 2 times, most recently from 2256a07 to c39c721CompareNovember 7, 2024 16:41
@jokerttu
jokerttu marked this pull request as ready for review November 7, 2024 16:58
@stuartmorgan-gstuartmorgan-g added the federated: all_changes PR that contains changes for all packages for a federated plugin change label Nov 7, 2024
stuartmorgan-g
stuartmorgan-g requested changes Nov 7, 2024
View reviewed changes
Comment thread...ps_flutter_platform_interface/lib/src/method_channel/method_channel_google_maps_flutter.dart Outdated
Comment thread...ps_flutter_platform_interface/lib/src/method_channel/method_channel_google_maps_flutter.dart Outdated
Comment thread...maps_flutter_platform_interface/lib/src/platform_interface/google_maps_flutter_platform.dart Outdated
Comment thread...maps_flutter_platform_interface/lib/src/platform_interface/google_maps_flutter_platform.dart Outdated
Comment threadpackages/google_maps_flutter/google_maps_flutter/lib/google_maps_flutter.dart Outdated
Comment threadpackages/google_maps_flutter/google_maps_flutter_android/pigeons/messages.dart Outdated
Comment thread.../google_maps_flutter/google_maps_flutter_ios/example/ios14/ios/RunnerTests/GoogleMapsTests.m Outdated
Comment threadpackages/google_maps_flutter/google_maps_flutter_ios/pigeons/messages.dart Outdated
Comment threadpackages/google_maps_flutter/google_maps_flutter_web/lib/src/google_maps_flutter_web.dart Outdated
Comment thread...flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapController.java Outdated
@jokerttu
jokerttuforce-pushed the feature/animate-camera-duration branch from 7c30a33 to 167b519CompareNovember 11, 2024 14:13
@jokerttu
jokerttuforce-pushed the feature/animate-camera-duration branch from 167b519 to 6078134CompareNovember 21, 2024 11:42
@jokerttujokerttu mentioned this pull request Nov 21, 2024
Open
@jokerttu
jokerttuforce-pushed the feature/animate-camera-duration branch 2 times, most recently from eb71ec7 to b6807ecCompareNovember 22, 2024 08:24
@stuartmorgan-gstuartmorgan-g added triage-ios Should be looked at in iOS triage triage-android Should be looked at in Android triage labels Nov 22, 2024
stuartmorgan-g
stuartmorgan-g requested changes Nov 22, 2024
View reviewed changes
Comment thread...le_maps_flutter/google_maps_flutter_ios/example/ios14/integration_test/google_maps_test.dart Outdated
Comment threadpackages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/FGMCATransactionWrapper.h Outdated
Comment threadpackages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/FGMCATransactionWrapper.h Outdated
Comment threadpackages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/FGMCATransactionWrapper.m Outdated
Comment threadpackages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapController.m Outdated
Comment threadpackages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapController_Test.h Outdated
Comment threadpackages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapController_Test.h Outdated
Comment threadpackages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapController_Test.h Outdated
Comment threadpackages/google_maps_flutter/google_maps_flutter_ios/test/google_maps_flutter_ios_test.dart Outdated
Comment thread.../google_maps_flutter/google_maps_flutter_ios/example/ios14/ios/RunnerTests/GoogleMapsTests.m Outdated
@stuartmorgan-g

stuartmorgan-g commented Nov 22, 2024

Copy link
Copy Markdown
Collaborator

My comments are all minor, so once the iOS and Android reviewers have signed off this will be ready to split out the first sub-PR.

@jokerttu
jokerttuforce-pushed the feature/animate-camera-duration branch from b6807ec to 6bc7717CompareNovember 25, 2024 08:00
@jesswrd
jesswrd requested review from a team and jesswrdNovember 26, 2024 19:34
auto-submitBot pushed a commit that referenced this pull request Mar 24, 2025
@jokerttu
[google_maps_flutter] Add ability to animate camera with duration - p…
c27d2fe
…latform impls (#8659)
This PR contains platform implementations for the ability to animate camera with duration (#7648).
Linked issue: flutter/flutter#39810
Linked issue: flutter/flutter#44284
@jokerttu
jokerttuforce-pushed the feature/animate-camera-duration branch from 32c21af to 565b4c3CompareMarch 24, 2025 11:05
@flutter-dashboard

This comment was marked as resolved.

Sign in to view
@jokerttu

jokerttu commented Mar 24, 2025

Copy link
Copy Markdown
ContributorAuthor

@stuartmorgan this PR now contains only app-facing package changes

stuartmorgan-g
stuartmorgan-g approved these changes Mar 24, 2025
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jokerttujokerttu added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 25, 2025
@auto-submit
auto-submitBot merged commit 125c117 into flutter:mainMar 25, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
125c117[google_maps_flutter] Add ability to animate camera with dura…
562afda
…tion (flutter/packages#7648)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Mar 25, 2025
Merged
github-merge-queueBot pushed a commit to flutter/flutter that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
Roll Packages fromc27d2feto125c117(2 revisions) (#165884)
47c8320
flutter/packages@c27d2fe...125c117
2025-03-25 joonas.kerttula@codemate.com [google_maps_flutter] Add
ability to animate camera with duration (flutter/packages#7648)
2025-03-24 15619084+vashworth@users.noreply.github.com [webview_flutter]
Fix macOS test issues and skip some legacy iOS tests
(flutter/packages#8895)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
dko5ki23t pushed a commit to dko5ki23t/google_maps_flutter_improved that referenced this pull request May 24, 2025
@jokerttu
[google_maps_flutter] Platform interface for camera animation duratio…
95e1754
…n (#8596)
This PR contains platform interface changes for support to adjust camera animation speed (flutter/packages#7648).
Linked issue: flutter/flutter#39810
Linked issue: flutter/flutter#44284
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@jokerttu@androidseb
[google_maps_flutter] Platform interface for camera animation duration (
993f1f2
flutter#8596)
This PR contains platform interface changes for support to adjust camera animation speed (flutter#7648).
Linked issue: flutter/flutter#39810
Linked issue: flutter/flutter#44284
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@jokerttu@androidseb
[google_maps_flutter] Add ability to animate camera with duration - p…
8107316
…latform impls (flutter#8659)
This PR contains platform implementations for the ability to animate camera with duration (flutter#7648).
Linked issue: flutter/flutter#39810
Linked issue: flutter/flutter#44284
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@jokerttu@androidseb
[google_maps_flutter] Add ability to animate camera with duration (fl…
a10e5fd
…utter#7648)
Adds ability to configure camera animation duration on Android and iOS.
Resolves [#39810](flutter/flutter#39810)
Resolves [#44284](flutter/flutter#44284)
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@engine-flutter-autorollyuuangzhang
Roll Packages fromc27d2feto125c117(2 revisions) (flutter#165884)
9a71ce7
flutter/packages@c27d2fe...125c117
2025-03-25 joonas.kerttula@codemate.com [google_maps_flutter] Add
ability to animate camera with duration (flutter/packages#7648)
2025-03-24 15619084+vashworth@users.noreply.github.com [webview_flutter]
Fix macOS test issues and skip some legacy iOS tests
(flutter/packages#8895)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@jokerttu@FMorschel
[google_maps_flutter] Platform interface for camera animation duration (
0369bf6
flutter#8596)
This PR contains platform interface changes for support to adjust camera animation speed (flutter#7648).
Linked issue: flutter/flutter#39810
Linked issue: flutter/flutter#44284
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@jokerttu@FMorschel
[google_maps_flutter] Add ability to animate camera with duration - p…
52e193e
…latform impls (flutter#8659)
This PR contains platform implementations for the ability to animate camera with duration (flutter#7648).
Linked issue: flutter/flutter#39810
Linked issue: flutter/flutter#44284
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@jokerttu@FMorschel
[google_maps_flutter] Add ability to animate camera with duration (fl…
7540774
…utter#7648)
Adds ability to configure camera animation duration on Android and iOS.
Resolves [#39810](flutter/flutter#39810)
Resolves [#44284](flutter/flutter#44284)
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll@romanejaquez
Roll Packages fromc27d2feto125c117(2 revisions) (flutter#165884)
c9ebe0f
flutter/packages@c27d2fe...125c117
2025-03-25 joonas.kerttula@codemate.com [google_maps_flutter] Add
ability to animate camera with duration (flutter/packages#7648)
2025-03-24 15619084+vashworth@users.noreply.github.com [webview_flutter]
Fix macOS test issues and skip some legacy iOS tests
(flutter/packages#8895)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@jokerttu
jokerttu deleted the feature/animate-camera-duration branch March 6, 2026 16:51
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@jokerttu
[google_maps_flutter] Platform interface for camera animation duration (
163b1b2
flutter#8596)
This PR contains platform interface changes for support to adjust camera animation speed (flutter#7648).
Linked issue: flutter/flutter#39810
Linked issue: flutter/flutter#44284
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@jokerttu
[google_maps_flutter] Add ability to animate camera with duration - p…
b01b88f
…latform impls (flutter#8659)
This PR contains platform implementations for the ability to animate camera with duration (flutter#7648).
Linked issue: flutter/flutter#39810
Linked issue: flutter/flutter#44284
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@jokerttu
[google_maps_flutter] Add ability to animate camera with duration (fl…
9d39cce
…utter#7648)
Adds ability to configure camera animation duration on Android and iOS.
Resolves [#39810](flutter/flutter#39810)
Resolves [#44284](flutter/flutter#44284)
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@jokerttu
[google_maps_flutter] Platform interface for camera animation duration (
5819ad8
flutter#8596)
This PR contains platform interface changes for support to adjust camera animation speed (flutter#7648).
Linked issue: flutter/flutter#39810
Linked issue: flutter/flutter#44284
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@jokerttu
[google_maps_flutter] Add ability to animate camera with duration - p…
5bc398d
…latform impls (flutter#8659)
This PR contains platform implementations for the ability to animate camera with duration (flutter#7648).
Linked issue: flutter/flutter#39810
Linked issue: flutter/flutter#44284
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbakerreidbakerreidbaker left review comments
@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes
@camsim99camsim99camsim99 approved these changes
@cbrackencbrackenAwaiting requested review from cbracken
@jesswrdjesswrdAwaiting requested review from jesswrd
@ditmanditmanAwaiting requested review from ditman

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appfederated: all_changesPR that contains changes for all packages for a federated plugin changep: google_maps_fluttertriage-iosShould be looked at in iOS triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[google_maps_flutter] Zoom animations are extremely fast on iOS [google_maps_flutter] Change camera animation speed (and curve?)

6 participants

@jokerttu@stuartmorgan-g@devnoaman@reidbaker@ditman@camsim99