Skip to content

[webview_flutter_wkwebview] Support NTLM for authentication - #7670

Merged
auto-submit[bot] merged 4 commits into
flutter:mainfrom
jtanium:main
Oct 7, 2024
Merged

[webview_flutter_wkwebview] Support NTLM for authentication#7670
auto-submit[bot] merged 4 commits into
flutter:mainfrom
jtanium:main

Conversation

@jtanium

@jtaniumjtanium commented Sep 19, 2024

Copy link
Copy Markdown
Contributor

This change allows wkwebview to support NTLM on iOS.

#155427

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman

Copy link
Copy Markdown
Member

Sorry for the delay reviewing this. There was a timeout in one of the tests, I merged in main to run them again.
@cbracken when you get a chance can you review? Thank you!

@cbrackencbracken left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, and apologies for the delay!

LGTM stamp from a Japanese personal seal

Comment threadpackages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md Outdated

@jmagmanjmagman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jmagmanjmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 7, 2024
@auto-submit
auto-submitBot merged commit e21f1ee into flutter:mainOct 7, 2024
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Oct 8, 2024
flutter/packages@bb00d34...8fbf4cd
2024-10-08 engine-flutter-autoroll@skia.org Manual roll Flutter from 0975e61 to ec2e12b (54 revisions) (flutter/packages#7815)
2024-10-08 engine-flutter-autoroll@skia.org Manual roll Flutter from 6bba08c to 0975e61 (1 revision) (flutter/packages#7814)
2024-10-08 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.7 to 4.2.1 (flutter/packages#7813)
2024-10-08 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds remaining methods for internal wrapper of the iOS native `IMAAdsRenderingSettings` (flutter/packages#7745)
2024-10-08 stuartmorgan@google.com [url_launcher] Remove incorrect SMS instructions (flutter/packages#7807)
2024-10-08 engine-flutter-autoroll@skia.org Manual roll Flutter from ead6b0d to 6bba08c (37 revisions) (flutter/packages#7809)
2024-10-07 jtanium@gmail.com [webview_flutter_wkwebview] Support NTLM for authentication (flutter/packages#7670)
2024-10-07 stuartmorgan@google.com Revert "[in_app_purchase_storekit] Add support for purchase and transactions" (flutter/packages#7810)
2024-10-07 louisehsu@google.com [in_app_purchase_storekit] Add support for purchase and transactions (flutter/packages#7574)
2024-10-07 engine-flutter-autoroll@skia.org Manual roll Flutter from fa402c8 to ead6b0d (14 revisions) (flutter/packages#7806)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@jmagmanjmagman linked an issue Oct 23, 2024 that may be closed by this pull request
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: webview_flutterplatform-ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support NTLM for Authentication

4 participants

@jtanium@jmagman@cbracken@loic-sharma