Skip to content

[web_benchmarks] Replace initialPage parameter with benchmarkPath - #7743

Merged
auto-submit[bot] merged 24 commits into
flutter:mainfrom
kenzieschmoll:benchmarkPath
Sep 30, 2024
Merged

[web_benchmarks] Replace initialPage parameter with benchmarkPath#7743
auto-submit[bot] merged 24 commits into
flutter:mainfrom
kenzieschmoll:benchmarkPath

Conversation

@kenzieschmoll

@kenzieschmollkenzieschmoll commented Sep 30, 2024

Copy link
Copy Markdown
Member

This will unblock flutter/devtools#8320. This is a follow up to the initial attempt here: #7632

@eyebrowsoffireeyebrowsoffire left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenzieschmollkenzieschmoll added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 30, 2024
@auto-submit
auto-submitBot merged commit 33fa73a into flutter:mainSep 30, 2024
@kenzieschmoll
kenzieschmoll deleted the benchmarkPath branch October 1, 2024 01:40
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 1, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 1, 2024
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Oct 1, 2024
flutter/packages@27c9853...ebcc4f0
2024-10-01 43054281+camsim99@users.noreply.github.com [camerax] Correct assumption about preview being correctly rotated by default on API 29 (flutter/packages#7714)
2024-09-30 43759233+kenzieschmoll@users.noreply.github.com Replace `initialPage` parameter with `benchmarkPath` (flutter/packages#7743)
2024-09-30 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.webkit:webkit from 1.11.0 to 1.12.0 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#7681)
2024-09-30 49699333+dependabot[bot]@users.noreply.github.com [interactive_media_ads]: Bump com.google.ads.interactivemedia.v3:interactivemedia from 3.35.0 to 3.35.1 in /packages/interactive_media_ads/android (flutter/packages#7734)
2024-09-30 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Change the location of where the AdsLoader is initialized (flutter/packages#7721)
2024-09-30 stuartmorgan@google.com [file_selector] Update Windows Pigeon for non-nullable generics (flutter/packages#7730)
2024-09-30 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds internal wrapper for Android native `AdProgressInfo` (flutter/packages#7723)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@kenzieschmollkenzieschmoll changed the title Replace initialPage parameter with benchmarkPath[web_benchmarks] Replace initialPage parameter with benchmarkPathOct 2, 2024
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
This will unblock flutter/devtools#8320. This is a follow up to the initial attempt here: flutter#7632
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
This will unblock flutter/devtools#8320. This is a follow up to the initial attempt here: flutter#7632
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: web_benchmarks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@kenzieschmoll@eyebrowsoffire