Skip to content

Remove additional (harmless but annoying) native stack traces. - #7837

Merged
auto-submit[bot] merged 1 commit into
mainfrom
video_player-android-moreBackgrounding
Oct 9, 2024
Merged

Remove additional (harmless but annoying) native stack traces.#7837
auto-submit[bot] merged 1 commit into
mainfrom
video_player-android-moreBackgrounding

Conversation

@matanlurey

Copy link
Copy Markdown
Contributor

@camsim99camsim99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Just want to confirm that we don't need to care about calling stop? I see this note about needing to include it in a particular case so just double checking!

@matanlurey

Copy link
Copy Markdown
ContributorAuthor

I see this note about needing to include it in a particular case so just double checking!

Good callout! I think it's more of a "can stop be called" versus stop must be called, but thanks for checking!

@matanlureymatanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 9, 2024
@auto-submit
auto-submitBot merged commit f1a3da2 into mainOct 9, 2024
@auto-submit
auto-submitBot deleted the video_player-android-moreBackgrounding branch October 9, 2024 22:01
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Oct 10, 2024
flutter/packages@9d00fb1...f1a3da2
2024-10-09 matanlurey@users.noreply.github.com Remove additional (harmless but annoying) native stack traces. (flutter/packages#7837)
2024-10-09 engine-flutter-autoroll@skia.org Roll Flutter from 0917e9d to 2d45fb3 (50 revisions) (flutter/packages#7836)
2024-10-09 109111084+yaakovschectman@users.noreply.github.com [camera_android] Begin conversion to Pigeon (flutter/packages#7755)
2024-10-09 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Add `PlatformCap` pigeon type. (flutter/packages#7639)
2024-10-09 43054281+camsim99@users.noreply.github.com [camerax] Revert "Explicitly remove READ_EXTERNAL_STORAGE permission" (flutter/packages#7826)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: video_playerplatform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[video_player] Native Stack trace crashes when putting the app in inactive state while video is playing on Android

2 participants

@matanlurey@camsim99