[pigeon] Allows swift generator to skip error class generation

[wamynobe]

Since the Kotlin generator allows skipping error class generation, it makes sense for the Swift generator to have the same option.

Related to:
#6183
flutter/flutter#142099

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
• I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is test-exempt.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[wamynobe]

Hi @tarrinneal,
In your previous PR #6183 , there are a few parts that I don't really understand (mostly about how to generate test files), for example the code kotlinIncludeErrorClass: input != 'core_tests', in packages/pigeon/tool/shared/generation.dart. Could you please guide me through these test cases?

[wamynobe]

looks like the test cases using the default error class name in Swift have failed.

[wamynobe]

How can I run those custom_package_tests test cases on my local machine?

[tarrinneal]

if you navigate to the pigeon directory you can run dart run tool/test.dart -f -t ios_swift_integration_tests

[tarrinneal]

This code

 final bool kotlinErrorClassGenerationTestFiles =
input == 'core_tests' || input == 'background_platform_channels';
final String kotlinErrorName = kotlinErrorClassGenerationTestFiles
? 'FlutterError'
: '${pascalCaseName}Error';

and the corresponding usage of kotlinErrorName ensures that there are two files with the same error class name. You'll need to do that for swift as well.

[wamynobe]

if you navigate to the pigeon directory you can run dart run tool/test.dart -f -t ios_swift_integration_tests

Thanks @tarrinneal I am now able to run those test cases.

and the corresponding usage of kotlinErrorName ensures that there are two files with the same error class name. You'll need to do that for swift as well.

I saw swiftErrorUseDefaultErrorName which has the same purpose as kotlinErrorClassGenerationTestFiles. Updated!

[tarrinneal]

Thanks for putting this together! (looks like I forgot to submit my approval last week, sorry)

[tarrinneal]

@stuartmorgan for 2nd review

[stuartmorgan-g]

LGTM