Skip to content

[image_picker_web] Loosen mime dep to >=1.0.4 <3.0.0 - #7879

Merged
auto-submit[bot] merged 5 commits into
flutter:mainfrom
cbracken:mime-to-v2
Oct 17, 2024
Merged

[image_picker_web] Loosen mime dep to >=1.0.4 <3.0.0#7879
auto-submit[bot] merged 5 commits into
flutter:mainfrom
cbracken:mime-to-v2

Conversation

@cbracken

@cbrackencbracken commented Oct 15, 2024

Copy link
Copy Markdown
Member

Provides version interop for projects that depend on mime version 2.0.0 and later.

The breaking version change was due to a change in the return value of extensionFromMime, which is unused in image_picker.

See: https://github.com/dart-lang/tools/blob/main/pkgs/mime/CHANGELOG.md#200

Fixes: flutter/flutter#156905

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Provides version interop for projects that depend on mime version 2.0.0
and later.
The breaking version change was due to a change in the return value of
`extensionFromMime`, which is unused in `image_picker`.
See: https://github.com/dart-lang/tools/blob/main/pkgs/mime/CHANGELOG.md#200
Issue: #7875
Comment threadpackages/image_picker/image_picker/CHANGELOG.md Outdated
@cbrackencbracken mentioned this pull request Oct 16, 2024
11 tasks

@ditmanditman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making our package:mime dep more flexible!

@ditmanditman changed the title image_picker: Loosen mime dep to >=1.0.4 <3.0.0[image_picker_web] Loosen mime dep to >=1.0.4 <3.0.0Oct 16, 2024
@ditmanditman added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 16, 2024
@cbrackencbracken removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 16, 2024
@cbrackencbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 16, 2024
@emersion

Copy link
Copy Markdown

Many thanks!

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 17, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 17, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 17, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 17, 2024
@cbracken
cbracken deleted the mime-to-v2 branch October 17, 2024 18:30
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Oct 17, 2024
flutter/packages@a35f02d...5582669
2024-10-17 50643541+Mairramer@users.noreply.github.com [two_dimensional_scrollables] Fixes TreeViewNode collapsing not working (flutter/packages#7474)
2024-10-17 stuartmorgan@google.com Revert "[in_app_purchase_storekit] Add support for purchase and transactions #7574" (flutter/packages#7886)
2024-10-17 109111084+yaakovschectman@users.noreply.github.com [camera_android] Mark `description` in `sendCameraErrorEvent` as `@NonNull` (flutter/packages#7877)
2024-10-17 chris@bracken.jp [image_picker_web] Loosen mime dep to >=1.0.4 <3.0.0 (flutter/packages#7879)
2024-10-17 52160996+FMorschel@users.noreply.github.com Removing unnecessary parenthesis (flutter/packages#7881)
2024-10-17 louisehsu@google.com [in_app_purchase_storekit] Add support for purchase and transactions #7574 (flutter/packages#7812)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
Provides version interop for projects that depend on mime version 2.0.0 and later.
The breaking version change was due to a change in the return value of `extensionFromMime`, which is unused in `image_picker`.
See: https://github.com/dart-lang/tools/blob/main/pkgs/mime/CHANGELOG.md#200Fixes: flutter/flutter#156905
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
Provides version interop for projects that depend on mime version 2.0.0 and later.
The breaking version change was due to a change in the return value of `extensionFromMime`, which is unused in `image_picker`.
See: https://github.com/dart-lang/tools/blob/main/pkgs/mime/CHANGELOG.md#200Fixes: flutter/flutter#156905
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade mime to v2

6 participants

@cbracken@emersion@stuartmorgan-g@jmagman@ditman@tarrinneal